Message ID | 20240216163535.1997122-1-arnd@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-68967-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:c619:b0:108:e6aa:91d0 with SMTP id hn25csp634023dyb; Fri, 16 Feb 2024 08:36:26 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVQIjE56ZMe649zCri3bjnFKiGBB/WTwJnZzaLCEUWnFQD6+4eq5ltjImKgWn4K1EMdZEcKHczZ+xEE9auAT3S2wDZVMQ== X-Google-Smtp-Source: AGHT+IH3VPHAtCB0o+IO1YxIlZBdGGBICi6Gd+WYW9hIXZxnvoQcFNK0PpT+rY8hGhaQ5cEP1FEE X-Received: by 2002:a05:622a:190c:b0:42c:3f57:1e0d with SMTP id w12-20020a05622a190c00b0042c3f571e0dmr14474834qtc.10.1708101386063; Fri, 16 Feb 2024 08:36:26 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708101386; cv=pass; d=google.com; s=arc-20160816; b=gFxCaENTfuJ8eyIxkKvbhmecfn3fWAG9kL8PNnFScZkOQ36bgFJY6bszVlNQaQbHLo MtM3zVkba8+0TcaEzwzvh9ly35BhuqVgEG8FtmtmZ8/4sA5cDjQIGxUitUvGi+S06z+7 LVIKjdMRZRk37h3pfHgBA8zeshwh5fuFUcKd/pE7L7rfLOMDYrtuXkrArvLUWFV47mMq R4jIwjzyHfx2lTu4iQi8ZSM2qDHPQtTtFQ7a8qZhPFWY9LgVDrD7ZwA4Mo5YL1hp60v6 wCp7UO945af7dopWB+75SX9UkQKiUC+/oQxqPT64BHSAe0IJrnyOvnqJc9WO++l7IGVv dy1g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=2jfoMqHhwC8OZyHoSq2h2Ghc4nn+2sqHEtXV/XW7fi8=; fh=sTkK685326oocjKH3C7LM3LzmJPPJdxFHCazGZxa8D4=; b=mHuXSq3w6zWCh4mdCQSJbpi0/lo3AZ3xDtBacncpCcnfGDFong/+dYWohzgc/oSlOR CK+kREoaxXyH7z/2dEwEgoMPYEMIvPAWJUBeqo/sOg2P5fjt8RbQMZV4adf5O1rdqys0 wjTBeJC+9qU1G9B/MmKWRqJmNqVid48Xpr60vEFLS28lXg0siBtEEUbJWWzretwFWx6c pQlCRvMriyhDtGthM1iRDysDvsV9zQyloBSB4IG+HjLfFxYXWcFjEUcZ+5XbysHYjuL5 89HPAy4IM36ZVldNGROR0A2H9CaE83riMqnItepgOJSlF7s+baMv/r3ThNfgqoAx5Ch8 TZuw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Fhk33EVh; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-68967-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-68967-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id u28-20020a05622a199c00b0042de66836a0si208149qtc.454.2024.02.16.08.36.25 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Feb 2024 08:36:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-68967-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Fhk33EVh; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-68967-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-68967-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 376B31C22B24 for <ouuuleilei@gmail.com>; Fri, 16 Feb 2024 16:36:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B0DFE130AE5; Fri, 16 Feb 2024 16:35:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Fhk33EVh" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDD4E130AC8 for <linux-kernel@vger.kernel.org>; Fri, 16 Feb 2024 16:35:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708101349; cv=none; b=jpDKOFPZOB6ERRxdi/DNINGutLx46EEqOm4CheVKmnoluAeb4ydaXzQvATtyr4VdTAlbRbnBi49FImveCAq2R4LZN9umgdIOKz2UlxpElxBCZVOTcYWrnJmt53O9NeABulprCVERsWDybej6BCB03ZZGypf0AgWAZj2DVthVCck= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708101349; c=relaxed/simple; bh=raZvY0y+94L/NA9J1FyQdvorJ7LyjIGL527Ml81HsW0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=cvjX2gxG/UV/D8NvtzGJbKXUcvR8//iWxySmHRwawI7Am7MZxTMI5gqPNWmsGsqivKyjhmXxe/0LYkxyCAn1pV6B2t/08depgUjh5t6pQ/6vQLsYs0/u6lYbXp2wAgVqzlC4Wx5PW137AQVf27dA9ie8UUoZdHK+5pe9Ra9/yA0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Fhk33EVh; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8667BC433F1; Fri, 16 Feb 2024 16:35:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708101348; bh=raZvY0y+94L/NA9J1FyQdvorJ7LyjIGL527Ml81HsW0=; h=From:To:Cc:Subject:Date:From; b=Fhk33EVhnTbEtIAGR46HODhGb0Tkg9fP9bDxNBKTnshqywJDQR4JqCvhJmLNkBmFo GdzUzSpj/Y0is26wYNyB5vatu24z7YBMx9N7UOEbE1d+jMrGkYaZSnsjZjOG5p/ws3 3E/P/iaBNKXiLayIcjEWah2XyWOjbveqVvbrK/sinJlFSjgVc1e/v08nrg1skgH+pC kul8E4ppMuq+AIEdF10hImaQoSvNOAh4uozGAm2Rv5z6HTdsUdkp16zlcy+/oEtsjR AETU7AJsMc9MSXH6GDoriXdlFUullFz046AjJbEQAg9cO3jvbhlrF7RVL1cghCLBHN sUSI6KGoXPH7A== From: Arnd Bergmann <arnd@kernel.org> To: Tejun Heo <tj@kernel.org> Cc: Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org Subject: [PATCH] irq_work: allow building non-SMP again Date: Fri, 16 Feb 2024 17:35:07 +0100 Message-Id: <20240216163535.1997122-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791074118917805302 X-GMAIL-MSGID: 1791074118917805302 |
Series |
irq_work: allow building non-SMP again
|
|
Commit Message
Arnd Bergmann
Feb. 16, 2024, 4:35 p.m. UTC
From: Arnd Bergmann <arnd@arndb.de> A lot of important features rely on CONFIG_IRQ_WORK but can be enabled for non-SMP kernels, which now causes a Kconfig warning: WARNING: unmet direct dependencies detected for IRQ_WORK Depends on [n]: SMP [=n] Selected by [y]: - PRINTK [=y] - IRQ_SIM [=y] - BPF_SYSCALL [=y] - TASKS_RCU [=y] - TASKS_RUDE_RCU [=y] - TASKS_TRACE_RCU [=y] - PERF_EVENTS [=y] && HAVE_PERF_EVENTS [=y] - CPU_FREQ_GOV_COMMON [=y] && CPU_FREQ [=y] - DMA_SHARED_BUFFER [=y] - ATLAS_PH_SENSOR [=y] && IIO [=y] && I2C [=y] - GP2AP020A00F [=y] && IIO [=y] && I2C [=y] - IIO_SYSFS_TRIGGER [=y] && IIO [=y] && IIO_TRIGGER [=y] && SYSFS [=y] - RING_BUFFER [=y] Change it so that IRQ_WORK remains default-enabled for SMP kernels and disabled for UP but can still be selected by other subsystems. Fixes: 9d6efa8d0dd0 ("workqueue, irq_work: Build fix for !CONFIG_IRQ_WORK") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- I assume this has already been reported by others, but I didn't immediately see another patch for it. --- init/Kconfig | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
Comments
Hello, Arnd. On Fri, Feb 16, 2024 at 05:35:07PM +0100, Arnd Bergmann wrote: > I assume this has already been reported by others, but I didn't immediately > see another patch for it. Oh, I just replaced the broken one with the following: https://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git/commit/?h=for-6.9&id=fd0a68a2337b79a7bd4dad5e7d9dc726828527af Sorry about the hassle. Thanks.
diff --git a/init/Kconfig b/init/Kconfig index 694891231bd6..68024f5e8f02 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -115,9 +115,7 @@ config CONSTRUCTORS bool config IRQ_WORK - bool - depends on SMP - default y + def_bool SMP config BUILDTIME_TABLE_SORT bool