diff mbox series

[next] ASoC: tas2781: Remove redundant initialization of pointer 'data'

Message ID 20240216142219.2109050-1-colin.i.king@gmail.com
State New
Headers
Series [next] ASoC: tas2781: Remove redundant initialization of pointer 'data' |

Commit Message

Colin Ian King Feb. 16, 2024, 2:22 p.m. UTC 
  The pointer 'data' being initialized with a value that is never read, it
is being re-assigned inside a while-loop. The initialization is redundant
and can be removed.

Cleans up clang scan build warning
sound/soc/codecs/tas2781-fmwlib.c:1534:17: warning: Value stored to
'data' during its initialization is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 sound/soc/codecs/tas2781-fmwlib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Brown Feb. 21, 2024, 12:48 a.m. UTC | #1 
On Fri, 16 Feb 2024 14:22:19 +0000, Colin Ian King wrote:
> The pointer 'data' being initialized with a value that is never read, it
> is being re-assigned inside a while-loop. The initialization is redundant
> and can be removed.
> 
> Cleans up clang scan build warning
> sound/soc/codecs/tas2781-fmwlib.c:1534:17: warning: Value stored to
> 'data' during its initialization is never read [deadcode.DeadStores]
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: tas2781: Remove redundant initialization of pointer 'data'
      commit: e480c0991db00b24b39010bfd56eda5ec2417186

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/sound/soc/codecs/tas2781-fmwlib.c b/sound/soc/codecs/tas2781-fmwlib.c
index 85e14ff61769..45760fe19523 100644
--- a/sound/soc/codecs/tas2781-fmwlib.c
+++ b/sound/soc/codecs/tas2781-fmwlib.c
@@ -1531,7 +1531,7 @@  static int tasdev_load_blk(struct tasdevice_priv *tas_priv,
 	unsigned int sleep_time;
 	unsigned int len;
 	unsigned int nr_cmds;
-	unsigned char *data = block->data;
+	unsigned char *data;
 	unsigned char crc_chksum = 0;
 	unsigned char offset;
 	unsigned char book;