Message ID | 20240216140535.1434933-1-rf@opensource.cirrus.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-68705-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:c619:b0:108:e6aa:91d0 with SMTP id hn25csp546256dyb; Fri, 16 Feb 2024 06:23:20 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCW7C9HkoF9jxqPV5ryVKaCQNrH4xx3oPILi5sjuOornROEHyDTIpJbdYBtateC/cJrsMY3jrW+VTF6i5lKYiNJbSl3pMw== X-Google-Smtp-Source: AGHT+IFZMD5kLopPYwEoYvOA4BtmQAAusjObFBmYBX/XWlOKbW9fPBa9x+wco9xMRgkb3Az71q87 X-Received: by 2002:a05:6871:1ca:b0:21e:635c:a5b7 with SMTP id q10-20020a05687101ca00b0021e635ca5b7mr2524346oad.3.1708093400440; Fri, 16 Feb 2024 06:23:20 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708093400; cv=pass; d=google.com; s=arc-20160816; b=UU2LdIPqaQWXqhlbRI8T5B0zoUZ+kj61Ag4DlA+A0d6ULz/DZg+v15ae6RHTbw9yu5 hSa29d2247WIMsiItedQ0uF4TlCDW7Z/N5a2u0W7+o9XBHoo9dkacWQ9ro5s+OCcHEuw jBq61l2eBnsgbXtVqEnS/ezf1tCq1ekK7sUaPOYtoeRrruxwHX6efawkAg1X1huL+JJn WOWyMICsUqfbBCJ38hfpK55GQQ5KBY6jGx5EJOizq5aJTflHryGSuq4IGfggWvkwsXz2 ucjRB8QlXbjDTJ26QdHmjN136D4KfOtAl2dZlK/RMlyRDEt1ZokggsBIT5ojtUqFN3qE kocg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=Dw280V9Ji8JnDWHiX49rYuBF9Ede07pNOdQW29T5Qag=; fh=Nd1U+TCR5vj/z8fBK7QForLA2lSjTNgmNLOKOIZv0Mg=; b=cCOfPRpqdmDdLxB8sQk0Lieu9zZ69Fj8PdZFZv5IiyTKP4mgRRm2M0Oooe6i41d02I PcGtfPiaxzS2eqGyqbpm1+4+qN7o6Q/xPhUGq3oQXvDt47dA8goj2pMfLMEnZ7ImoaOs uRsUwvlcN/m+K/fOQIKzXQzjUgFVM2XmwcP8wOZtpssiWmT7O4FOgMzj/2/R+QuNR605 RbSbe9Bb6lMgENIoQQoqvsqLxFlqCmzx9p/qcfuGq0ZTu/Z03Vmm6e90g5g5pSvClcRW 1wzgLLxer0ZRN2XAacdOSrhS2gHhpy8bd9WXcfjbm9r7i0GjPogA9RLxAFuulgSW1627 IvTQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=F4OzVQbF; arc=pass (i=1 spf=pass spfdomain=opensource.cirrus.com dkim=pass dkdomain=cirrus.com dmarc=pass fromdomain=opensource.cirrus.com); spf=pass (google.com: domain of linux-kernel+bounces-68705-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-68705-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id p21-20020a637f55000000b005dc76f56a18si2970003pgn.559.2024.02.16.06.23.20 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Feb 2024 06:23:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-68705-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=F4OzVQbF; arc=pass (i=1 spf=pass spfdomain=opensource.cirrus.com dkim=pass dkdomain=cirrus.com dmarc=pass fromdomain=opensource.cirrus.com); spf=pass (google.com: domain of linux-kernel+bounces-68705-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-68705-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 450DDB210B5 for <ouuuleilei@gmail.com>; Fri, 16 Feb 2024 14:07:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3FC1812D74E; Fri, 16 Feb 2024 14:06:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="F4OzVQbF" Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0253E175A6; Fri, 16 Feb 2024 14:05:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=67.231.149.25 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708092358; cv=none; b=bb7hVTLiuIM+qUNlsjsr+n4XnwtnAPCLKwdAKaIapVXeUtBRDLVm8mbbV5hbgv4ZuB4HgFLxH8RY7zi7KuPqUj2Q85TdybHtcCtj0QcF0qmJxoVeHvlL0RI3k+QRtk/QvWf+OUHnuIOGPQGuXTld9e0JWKMbSzPJSjw/X91ibZw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708092358; c=relaxed/simple; bh=E6q5xrMcVV+0iqJ33ckm74DzEhM3R6Lm5oDsVEfUaZs=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=A4Ay+3rAE7thwbxBtU7zQ1HZKE3KKuLIbDPMgJDphxXLKEWdIDEZ7b7YVGf+FM5qO16djpZ+HTQJj8YWlYTdFCRYdFY8Qi8/YZA+Y7x2eHbNv1j9q76sXsYmdoxZUuyNKibqmNvHh30gpNOTfbeLlWWL/yqE/YdQwG4Zjqpn+I4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=F4OzVQbF; arc=none smtp.client-ip=67.231.149.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 41G5u5hg027308; Fri, 16 Feb 2024 08:05:37 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding:content-type; s=PODMain02222019; bh=D w280V9Ji8JnDWHiX49rYuBF9Ede07pNOdQW29T5Qag=; b=F4OzVQbFi4ewdFUlT uU1W+e+bVKsiFUa31R6u5z4IXVO27zdEmSOltdY5Iw+YBDHCYfKgI+BNTVv2m0sQ +BPskYVslty0imzHDz/rFu9mxnUjPiGcohi/EOzqpU6W/6N+6ytpwttGbUVh+TOE w5NB1ogPposbebzRFBJ67zw/kbA6gFnqe5ZjAUAlrKeSgF5NmltUlzWa+Ka8g3vb HQYQXno0cP2/mOeIhQl1Wy7kZhmL0ewC7ZiFnQVVAgrt5wakA61yHCOaq1F0La0Y A/Pw89vj0ZboxE9wI/TR9/GtCkXucbD7Ctp8zxw4RJ+1VMcR/djaVzqCbdekpcLC ojMag== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 3w67e2738b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 16 Feb 2024 08:05:37 -0600 (CST) Received: from ediex01.ad.cirrus.com (198.61.84.80) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Fri, 16 Feb 2024 14:05:35 +0000 Received: from ediswmail9.ad.cirrus.com (198.61.86.93) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40 via Frontend Transport; Fri, 16 Feb 2024 14:05:35 +0000 Received: from ediswws06.ad.cirrus.com (ediswws06.ad.cirrus.com [198.90.208.18]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTP id 5FA17820242; Fri, 16 Feb 2024 14:05:35 +0000 (UTC) From: Richard Fitzgerald <rf@opensource.cirrus.com> To: <broonie@kernel.org> CC: <alsa-devel@alsa-project.org>, <linux-sound@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <patches@opensource.cirrus.com>, "Richard Fitzgerald" <rf@opensource.cirrus.com> Subject: [PATCH] ASoC: cs35l56: Must clear HALO_STATE before issuing SYSTEM_RESET Date: Fri, 16 Feb 2024 14:05:35 +0000 Message-ID: <20240216140535.1434933-1-rf@opensource.cirrus.com> X-Mailer: git-send-email 2.30.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-ORIG-GUID: _z1cWPfNfG1gpNOCgIy6EkY_CyfG-Cwr X-Proofpoint-GUID: _z1cWPfNfG1gpNOCgIy6EkY_CyfG-Cwr X-Proofpoint-Spam-Reason: safe X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791065745376471924 X-GMAIL-MSGID: 1791065745376471924 |
Series |
ASoC: cs35l56: Must clear HALO_STATE before issuing SYSTEM_RESET
|
|
Commit Message
Richard Fitzgerald
Feb. 16, 2024, 2:05 p.m. UTC
The driver must write 0 to HALO_STATE before sending the SYSTEM_RESET
command to the firmware.
HALO_STATE is in DSP memory, which is preserved across a soft reset.
The SYSTEM_RESET command does not change the value of HALO_STATE.
There is period of time while the CS35L56 is resetting, before the
firmware has started to boot, where a read of HALO_STATE will return
the value it had before the SYSTEM_RESET. If the driver does not
clear HALO_STATE, this would return BOOT_DONE status even though the
firmware has not booted.
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Fixes: 8a731fd37f8b ("ASoC: cs35l56: Move utility functions to shared file")
---
sound/soc/codecs/cs35l56-shared.c | 1 +
1 file changed, 1 insertion(+)
Comments
On Fri, 16 Feb 2024 14:05:35 +0000, Richard Fitzgerald wrote: > The driver must write 0 to HALO_STATE before sending the SYSTEM_RESET > command to the firmware. > > HALO_STATE is in DSP memory, which is preserved across a soft reset. > The SYSTEM_RESET command does not change the value of HALO_STATE. > There is period of time while the CS35L56 is resetting, before the > firmware has started to boot, where a read of HALO_STATE will return > the value it had before the SYSTEM_RESET. If the driver does not > clear HALO_STATE, this would return BOOT_DONE status even though the > firmware has not booted. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: cs35l56: Must clear HALO_STATE before issuing SYSTEM_RESET commit: e33625c84b75e4f078d7f9bf58f01fe71ab99642 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/codecs/cs35l56-shared.c b/sound/soc/codecs/cs35l56-shared.c index 995d979b6d87..cb4e83126b08 100644 --- a/sound/soc/codecs/cs35l56-shared.c +++ b/sound/soc/codecs/cs35l56-shared.c @@ -335,6 +335,7 @@ void cs35l56_wait_min_reset_pulse(void) EXPORT_SYMBOL_NS_GPL(cs35l56_wait_min_reset_pulse, SND_SOC_CS35L56_SHARED); static const struct reg_sequence cs35l56_system_reset_seq[] = { + REG_SEQ0(CS35L56_DSP1_HALO_STATE, 0), REG_SEQ0(CS35L56_DSP_VIRTUAL1_MBOX_1, CS35L56_MBOX_CMD_SYSTEM_RESET), };