| Message ID | 20240216134918.2108262-1-colin.i.king@gmail.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel+bounces-68664-ouuuleilei=gmail.com@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a05:7300:c619:b0:108:e6aa:91d0 with SMTP id
hn25csp527542dyb;
Fri, 16 Feb 2024 05:59:27 -0800 (PST)
X-Forwarded-Encrypted: i=3;
AJvYcCXJXcQuWFGf8nf3eDNCVYAz+IE4f7R5U2d17ut5JT+LUNwXi8FjlXYdhIcaOTaYeDCmzMlAz1/iu220ofFihpsFyoDumA==
X-Google-Smtp-Source:
AGHT+IH2RtKYXdbON42CVH7o0gXeveWoZIuwDCSmGOf0+GrMqX2UWUQNML/D0bMRp6JxWin2hNqf
X-Received: by 2002:a17:902:a606:b0:1d8:b798:dfe3 with SMTP id
u6-20020a170902a60600b001d8b798dfe3mr5424432plq.43.1708091967365;
Fri, 16 Feb 2024 05:59:27 -0800 (PST)
ARC-Seal: i=2; a=rsa-sha256; t=1708091967; cv=pass;
d=google.com; s=arc-20160816;
b=ZA8weQ7IpQNT1BUyt1Sy8Wq8wSbLm6PD1ASiQU0tc2L0objBwwOzbdcN366AKq7aJi
vZGSHgrTSwufLO868tQtCaQNcTBrZJXyXQeZAmv1jAOxolqnTWfteGa9Tz9CQ38KgTGH
BPfd/ZxFfkuTwhqeaotGAeHlgdlR8RpIWYvonMt6k8EIxwJzN3x5THPa2X3ylQw2v244
x1gvu66m2tjKg7BZswEZfBLRIGOLwFZuMwnOnBHNvhnkPjQTGRE4p38leSbw2vkS0cCr
k4oyP1gCYIUvLJdRWts4sjH2d9fc44BiYRxqPpRV96vHCdCaIwDrg7eLpDWKw3nzkLBj
K+qw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=content-transfer-encoding:mime-version:list-unsubscribe
:list-subscribe:list-id:precedence:message-id:date:subject:cc:to
:from:dkim-signature;
bh=14+mC4rW9qPm6BJ5liAT/H15Nh4bSLCkqgnbdBJo+rQ=;
fh=Ml4k7TBo0dBsk/c5cz2Cd1DVAxyJOf+sdZKGZBd0EFs=;
b=oBlpWQEj0uZzjtifGwHdlBvAHrbLsJvihhWr93qIZPj//c7IY6vNithTNYqa4rQl3g
gPZdQS7X9NvZKixcleKTOCWrHbjsWCpvBcBKSS9kH4yvegfyfYDd6JmJ5PMsyWx9bzAg
Mhsz9haJUNAywUj4jJ5S8sDjCulmUjm0fwli4Vqav0PYn+34rVTcTzYA6eEJO1ehs54p
c5F5RDDWqQcycsRWOpHqeyMY5Myjbr3zJO1Lww336CP8fWX1TrP/cWfQ0eg8y3lSCfwn
dilt0F0uTg6hox8rfMGNqxF/HqzUkTLNWU7ouI1nkdR8PQ4YsTYzmEAB1kfVqv5O0l62
IkgA==;
dara=google.com
ARC-Authentication-Results: i=2; mx.google.com;
dkim=pass header.i=@gmail.com header.s=20230601 header.b=QGzrjMVB;
arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com
dmarc=pass fromdomain=gmail.com);
spf=pass (google.com: domain of
linux-kernel+bounces-68664-ouuuleilei=gmail.com@vger.kernel.org designates
147.75.48.161 as permitted sender)
smtp.mailfrom="linux-kernel+bounces-68664-ouuuleilei=gmail.com@vger.kernel.org";
dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com
Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161])
by mx.google.com with ESMTPS id
s5-20020a17090302c500b001d9ec0edac7si3014784plk.382.2024.02.16.05.59.26
for <ouuuleilei@gmail.com>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 16 Feb 2024 05:59:27 -0800 (PST)
Received-SPF: pass (google.com: domain of
linux-kernel+bounces-68664-ouuuleilei=gmail.com@vger.kernel.org designates
147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Authentication-Results: mx.google.com;
dkim=pass header.i=@gmail.com header.s=20230601 header.b=QGzrjMVB;
arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com
dmarc=pass fromdomain=gmail.com);
spf=pass (google.com: domain of
linux-kernel+bounces-68664-ouuuleilei=gmail.com@vger.kernel.org designates
147.75.48.161 as permitted sender)
smtp.mailfrom="linux-kernel+bounces-68664-ouuuleilei=gmail.com@vger.kernel.org";
dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com
Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org
[52.25.139.140])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by sy.mirrors.kernel.org (Postfix) with ESMTPS id C6562B21327
for <ouuuleilei@gmail.com>; Fri, 16 Feb 2024 13:49:39 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
by smtp.subspace.kernel.org (Postfix) with ESMTP id 5DA0E12C52D;
Fri, 16 Feb 2024 13:49:25 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
header.b="QGzrjMVB"
Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com
[209.85.128.54])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EF31129A9E;
Fri, 16 Feb 2024 13:49:20 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
arc=none smtp.client-ip=209.85.128.54
ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
t=1708091362; cv=none;
b=U81voowWE7wVTnmZEbwoGURDl+/mzBPm6PHjG4OOiDl6mgbzVR7H7Ln+uvXa4oL2nxfcJznXq+ZxS32nfTf8gvl5XI/m2fj1iO1PxkUal51WIHq+yNfzaeUqw7Y0Qf9B/5QS+ppaO6G9PHpH5EEOKTEMf2mfrnksb58rmOrVmlE=
ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org;
s=arc-20240116; t=1708091362; c=relaxed/simple;
bh=H+T5FYgKFojb6M4WitBTre0vhWBwiXJLpEA07zWHYGM=;
h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Type;
b=I/wy332IzO97BmTDCGlnGWvh9iFclUBdneXGdH5Qni194B8R+nAibOuV4y2rI+mi+aMc7wR47/MSL60edCzrhLlqKqEnzM0JBOJxFZFcoWDVgwZMhF3y0FKyrM6rfzoBXx6pkaGOdxOydrH170NRC+2H5JZpoqPfmLo9DKC/Fnw=
ARC-Authentication-Results: i=1; smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=gmail.com;
spf=pass smtp.mailfrom=gmail.com;
dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
header.b=QGzrjMVB; arc=none smtp.client-ip=209.85.128.54
Authentication-Results: smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: smtp.subspace.kernel.org;
spf=pass smtp.mailfrom=gmail.com
Received: by mail-wm1-f54.google.com with SMTP id
5b1f17b1804b1-411d715c401so16061715e9.1;
Fri, 16 Feb 2024 05:49:20 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1708091359; x=1708696159;
darn=vger.kernel.org;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=14+mC4rW9qPm6BJ5liAT/H15Nh4bSLCkqgnbdBJo+rQ=;
b=QGzrjMVB7jvkJLiymRIlvUBJxugcUsCE26C0UGbC+R2n+KDVgbEIBWrQ8EDbeESPQG
aUB0Bc6S7XCreBxhk6gU89AaKKNHaColX/dHz5jgfwN8fPy8v2wv3i0aaM4UPFJSny0w
/0K09BtWMLgIBCYt8fNcREj9thyIR0KGqIA763f6jPqbWhVt9GYvY/7RJrywxlpVdnhJ
3sRnAxLn+6rf4shgeY0CQuhJ40RKYrSQWHAlcRe42qT2TBB3ZaUF5w4basxREGDDCrf4
phg/fcMnB+WEu9IKdgHv8DXP4H8lYojEi4MNclMzFIpppeS7a/0Ot0kAXDL9rGFvvmxv
xpaA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1708091359; x=1708696159;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=14+mC4rW9qPm6BJ5liAT/H15Nh4bSLCkqgnbdBJo+rQ=;
b=WZDh3+CvC98eF1LJmU9tN0vZx3eyhquSJ+dXiHAnLMqiDxpAZNCpUqqeyD9GcF0e9z
ZOWNx1Btu+jwjvxIaEr7tHy2mKNhk+aqQOR0PmsqU+/1Mx+XWojItuMdgK/f6ginDlPR
mvAaUyMyjswyHHD7K5+SpB4AKsQNLM9diBoTE+CEdc9obKuatMG7kvIafWVrFpnHlXKw
OnBiGZNDSRKrPhsKet/ChGHknqj4gGabzNzIbtri2XJkQP+G54frGBMqQbDvp9HvY3Z8
tCFJR7wyX+tKLCG9Fa1/yByXNt5IjjaSnJJZ39IbZhw21LqYcj9dq9ioQO45B5hqtjxp
rmSw==
X-Forwarded-Encrypted: i=1;
AJvYcCXAtWLGCE1Ds1t5jA612d71N0BNEk9pxdKYhz7c6nEAD1bu+JCUpR2/03DcMG7n5cf9CZC9G1bYlGqPP/TueJkGUAIJ3IiC6wBF0WBe
X-Gm-Message-State: AOJu0Yz8ZouUVyXUkBcNiM4uIMJ2C+PFRf8o0Qqtr7GlYYsidwPq9qpE
9fM/1WeT+wnDmWTUuNngfCSbBTpcF+c8OF3YCNDI6I6VR3LDCvrb
X-Received: by 2002:a05:600c:2305:b0:411:e2bf:73b9 with SMTP id
5-20020a05600c230500b00411e2bf73b9mr3595831wmo.39.1708091359176;
Fri, 16 Feb 2024 05:49:19 -0800 (PST)
Received: from localhost (cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net.
[80.193.200.194])
by smtp.gmail.com with ESMTPSA id
21-20020a05600c229500b0041228b2e179sm2351489wmf.39.2024.02.16.05.49.18
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 16 Feb 2024 05:49:18 -0800 (PST)
From: Colin Ian King <colin.i.king@gmail.com>
To: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH][next] regulator: core: Remove redundant assignment to
variable possible_uV
Date: Fri, 16 Feb 2024 13:49:18 +0000
Message-Id: <20240216134918.2108262-1-colin.i.king@gmail.com>
X-Mailer: git-send-email 2.39.2
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1791064242469635549
X-GMAIL-MSGID: 1791064242469635549
|
| Series |
[next] regulator: core: Remove redundant assignment to variable possible_uV
|
|
Commit Message
Colin Ian King
Feb. 16, 2024, 1:49 p.m. UTC
The variable possible_uV being assigned a value that is never read, the
control flow via the following goto statement takes a path where the
variable is not accessed. The assignment is redundant and can be removed.
Cleans up clang scan build warning:
drivers/regulator/core.c:3935:3: warning: Value stored to 'possible_uV'
is never read [deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/regulator/core.c | 1 -
1 file changed, 1 deletion(-)
Comments
On Fri, 16 Feb 2024 13:49:18 +0000, Colin Ian King wrote: > The variable possible_uV being assigned a value that is never read, the > control flow via the following goto statement takes a path where the > variable is not accessed. The assignment is redundant and can be removed. > > Cleans up clang scan build warning: > drivers/regulator/core.c:3935:3: warning: Value stored to 'possible_uV' > is never read [deadcode.DeadStores] > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next Thanks! [1/1] regulator: core: Remove redundant assignment to variable possible_uV commit: 055100d1a3b27ce154b3e3041d3cef24778821b3 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index a968dabb48f5..17c98c5fa45f 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -3932,7 +3932,6 @@ static int regulator_get_optimal_voltage(struct regulator_dev *rdev, if (ret < 0) return ret; - possible_uV = desired_min_uV; done = true; goto finish;