From patchwork Fri Feb 16 09:54:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 202037 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:c619:b0:108:e6aa:91d0 with SMTP id hn25csp406368dyb; Fri, 16 Feb 2024 01:58:17 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCV5jYUHdbQdr4WcvPz5KqT3dpRR+ubC6tgfajXlWuFfqVH7v0KG09I7kyq2tUPBf+bWk4QbJmlvUxDM/b/jLXA89s+X9A== X-Google-Smtp-Source: AGHT+IGAF13x5NpQqOL5JNbCB+FyVFbTwfEMy9LPrRcsSKvRswrqJNiixhUCkxEs5mlWquDaTpKa X-Received: by 2002:a0d:dd82:0:b0:607:9ea5:64a6 with SMTP id g124-20020a0ddd82000000b006079ea564a6mr4093589ywe.39.1708077497437; Fri, 16 Feb 2024 01:58:17 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708077497; cv=pass; d=google.com; s=arc-20160816; b=lR+YaasyBeqnlLbAYa2sWeNRAatGd2pihzZEQ2Pq147u09OU5IMtXU341PrvSFAmEV 7WoeKwMm+xm5AVPTJ7krj4XlIk1TObrGh+zbRIBheAwwfDl8UcQjTaL2GXOU7lX8w7pD ezRY20RbISDnbaS7vF+kLY7UtMsGDQrQ8fmTwLn4olbZrGjOYpijK/XJVegbYJuz1YFw +TzPwq1e8HiztlnxAKHbYX9JlamMQyIstEQlIeKX7k/q5I2Hh+Efg+2JCzp7tv3wCvps bIhAMByRqKIp2BA0P7h93eYiVA6W4joCQsGOXvh3ltiJTWHqN8VyH4e5uFrROB3Oy8bT abtQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=/252E7E9rHvdE4Vh1Ct14md+rj0q8EJ6U+aeAJaeD2w=; fh=wMnX2JVBtS2NrVgo2CnGDWraHKef72/T+fbwIIcSOXY=; b=V3pTO/bUcb2gO9TaNVZcun9o2AMavKUL5ahPFJDNCsaE4Kt/U8T3mSbUffVLoFq6Uw cfctCgwrZKZaq+LOtTYKYWPLkZijmCPINH0iMUnpb3YRoB/cbROfzl1bXtcFSPJXo7NR 6S9VYN1cMxMJnpDlCrY0zKpKWdsp7E8unUahKf1tTeV4fsgp+W45AIrhohYt3n7WCPcd kMZw6Km+yIYzuCXAxB8rQCUBpcWbBXutooERd9WJxkL1qheXn3T3zjMCXRNJ1cxpthMQ 23GhKP250F6PUJJQNpXrz9A+2h8I4NOZMlwgK07ZxjN3OOmAVgmwUzPHXNk/l6s49fBd TqhQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=EFPd4Hz1; arc=pass (i=1 spf=pass spfdomain=ideasonboard.com dkim=pass dkdomain=ideasonboard.com); spf=pass (google.com: domain of linux-kernel+bounces-68388-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-68388-ouuuleilei=gmail.com@vger.kernel.org" Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id h17-20020ac87451000000b0042ddd784ca5si1212806qtr.172.2024.02.16.01.58.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Feb 2024 01:58:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-68388-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=EFPd4Hz1; arc=pass (i=1 spf=pass spfdomain=ideasonboard.com dkim=pass dkdomain=ideasonboard.com); spf=pass (google.com: domain of linux-kernel+bounces-68388-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-68388-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 3DCF71C217C0 for ; Fri, 16 Feb 2024 09:58:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C14D421114; Fri, 16 Feb 2024 09:55:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="EFPd4Hz1" Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A45B620DCC; Fri, 16 Feb 2024 09:55:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708077346; cv=none; b=RFXv+7Nps/Q1F9Ha1mGY2n7VBSYaYN+RivcbPCpEV6Q4TH+ebkD2m02W+aI+Kb5dk1gzSZAD+s5QMp+wYLR1A25815FD9o5imEqNJNEEGS9bwFRB9owCEWCV58bmcLl5iWW2UdRPNtQVja6hjVF9ie//49BEJ7cV1HgyoD0lpnw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708077346; c=relaxed/simple; bh=+W3iDB8WTozj1nqYH1DK/H9GSSjDUiV71a1AKS5P110=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=YYGkJKUVa13Xnqj7Zw2kd4UnukHoMs1JAAnBp2FxnGmdvrUJNwkhDsPvlrGC5IvcFUrB0nuODIHMCLx2jV64p8YhwAlZnvxsgG0n6paPebheeZN0f2/BSrwnDvYDwcVoPHD4AgHk1OhnhNbqu8QYCc9N0eZgoRxgjnxnOXDhp7o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=EFPd4Hz1; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Received: from pyrite.hamster-moth.ts.net (h175-177-049-156.catv02.itscom.jp [175.177.49.156]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 455CC6B3; Fri, 16 Feb 2024 10:55:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1708077338; bh=+W3iDB8WTozj1nqYH1DK/H9GSSjDUiV71a1AKS5P110=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EFPd4Hz167Z6n9h4GJX/56gSHTCjQoYr8ejI5V8F0EupmAC2a6YIiC2Lp51WdAylt NTgVjRd4nxV2V61M/JT0jNTADPv4if63qXrzFtNg84TUn5Al0KAMGOz5hMGyHoErwu an9fE3TLqF5JTZaW2L2c21T5B1iE4Ukdsa61m4C0= From: Paul Elder To: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org Cc: kieran.bingham@ideasonboard.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, aford173@gmail.com, Paul Elder , Laurent Pinchart , Rob Herring , Alexander Stein , Dafna Hirschfeld , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Helen Koike , linux-arm-kernel@lists.infradead.org (moderated list:ARM/Rockchip SoC support), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v12 05/12] dt-bindings: media: rkisp1: Add i.MX8MP ISP to compatible Date: Fri, 16 Feb 2024 18:54:51 +0900 Message-Id: <20240216095458.2919694-6-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240216095458.2919694-1-paul.elder@ideasonboard.com> References: <20240216095458.2919694-1-paul.elder@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791049070106142495 X-GMAIL-MSGID: 1791049070106142495 The i.MX8MP ISP is compatbile with the rkisp1 driver. Add it to the list of compatible strings. While at it, expand on the description of the clocks to make it clear which clock in the i.MX8MP ISP they map to, based on the names from the datasheet. Signed-off-by: Paul Elder Reviewed-by: Laurent Pinchart Reviewed-by: Rob Herring Tested-by: Alexander Stein Tested-by: Adam Ford --- Changes since v1: - Add fsl,blk-ctrl property - Make iommus, phys and phy-names conditional on compatible --- .../bindings/media/rockchip-isp1.yaml | 37 ++++++++++++++++--- 1 file changed, 31 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/media/rockchip-isp1.yaml b/Documentation/devicetree/bindings/media/rockchip-isp1.yaml index afcaa427d48b..6be00aca4181 100644 --- a/Documentation/devicetree/bindings/media/rockchip-isp1.yaml +++ b/Documentation/devicetree/bindings/media/rockchip-isp1.yaml @@ -16,6 +16,7 @@ description: | properties: compatible: enum: + - fsl,imx8mp-isp - rockchip,px30-cif-isp - rockchip,rk3399-cif-isp @@ -36,9 +37,9 @@ properties: minItems: 3 items: # isp0 and isp1 - - description: ISP clock - - description: ISP AXI clock - - description: ISP AHB clock + - description: ISP clock (for imx8mp, clk) + - description: ISP AXI clock (for imx8mp, m_hclk) + - description: ISP AHB clock (for imx8mp, hclk) # only for isp1 - description: ISP Pixel clock @@ -52,6 +53,13 @@ properties: # only for isp1 - const: pclk + fsl,blk-ctrl: + $ref: /schemas/types.yaml#/definitions/phandle-array + maxItems: 1 + description: + A phandle to the media block control for the ISP, followed by a cell + containing the index of the gasket. + iommus: maxItems: 1 @@ -113,9 +121,6 @@ required: - interrupts - clocks - clock-names - - iommus - - phys - - phy-names - power-domains - ports @@ -143,6 +148,26 @@ allOf: required: - interrupt-names + - if: + properties: + compatible: + contains: + const: fsl,imx8mp-isp + then: + properties: + iommus: false + phys: false + phy-names: false + required: + - fsl,blk-ctrl + else: + properties: + fsl,blk-ctrl: false + required: + - iommus + - phys + - phy-names + additionalProperties: false examples: