From patchwork Fri Feb 16 07:59:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leonardo Bras Soares Passos X-Patchwork-Id: 201986 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:c619:b0:108:e6aa:91d0 with SMTP id hn25csp367665dyb; Fri, 16 Feb 2024 00:12:33 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWbyQu4BvXfPAEafe+JPNddNbnaLQTWSkxNQ/eEa7EH8L7Xa/ZSvjtE3Y7pvbDUCnseMe5PHOKextwGyOZU5gxAnovMLQ== X-Google-Smtp-Source: AGHT+IETwGxNBmtz2u0lcURDVIj4XgfflWOFvkAcdB3zmEetpguu7SlRJLD8mbYj+/bxFLBMuxWl X-Received: by 2002:a05:6a00:3a81:b0:6e0:392b:c236 with SMTP id fk1-20020a056a003a8100b006e0392bc236mr3969497pfb.11.1708071152881; Fri, 16 Feb 2024 00:12:32 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708071152; cv=pass; d=google.com; s=arc-20160816; b=q5fp5J2v9Nb00od5URM5XVsy9nT3cHfMZIr8sTfdgPt7q8SuksbG+l3oIPA41fWyUp /bW9Jnct91orMUnLCVjtHtdPZxEpnCWVlEV2zgHFz/1hmrgxp3g0gSpFJHKveUh4sayG lCkJQmC8b/JPx9iUBKrfGSHbcdjdnUbftjjIbEV1amSbz7tNGwMeH24cTzoGP9HrBBBn MRRG/xUcdzmGq+zLhVkzFQiXbOOQEP95mhB/4yAnTSFmAGBNBYWdbYuDgFYoHLWJBqEM ACQl2+APuwNPb99BCvJ6+MgkmDfKVgYCSmm4xdO8HPZJdeFccpi4j+TV4dkRTt6AsG8G t86A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=LC1bKFmWstjcuRp0NCZgXGUr7lDByzyZO+jUi4bsRIg=; fh=k34Nnq/Kwq/SZsiVv5WWtSAM8XrsxgnVMy19Vz8zceU=; b=iLVRydp/5OT5l/8uFWhm16lVdhZjKL2o4MYt2EcBfnBcpxp2QB+6i4F2XIrPZOhkMH JC9vCdysPLNbtWyu98RqPQQLSsdPKkKV89gOyyjoLpRP7pe2tcuWqnsnX4RaLwVx3fGt I/+mJy8Fsh6rHoT9ybN+5Jw/hyTuAFsXdYE7ccbR0d8539a6SLZP0cgcUpNb8llbYCCc TRn9sDaMBahNlkSPZcm1R5r+eWu/gW+k4X+/cHD6SWKEbvkb4y7B2DbdVYjjAUF4wmpf hjrOQlq2CWhkxvkl34HZdLduIaixXXv+6we2TqYgISdBLJcvgxli9ZPMG7viD5ynAyQM 08ww==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DBE+Xc9t; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-68205-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-68205-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id s186-20020a635ec3000000b005ced6c45233si2543785pgb.712.2024.02.16.00.12.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Feb 2024 00:12:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-68205-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DBE+Xc9t; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-68205-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-68205-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 9076C281F27 for ; Fri, 16 Feb 2024 08:12:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 527DB1BC3F; Fri, 16 Feb 2024 08:00:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DBE+Xc9t" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C19A21B966 for ; Fri, 16 Feb 2024 08:00:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708070428; cv=none; b=CdX0945px40GpcT6BGfG2GIeY7si7WZwEBNeNnYNm+eKFfMM9cPCWFXOC35io+c5wWMR7YwSrBHs51PuGhSnUhx0x4/uA56YjXbN+fILYR7EyBaiaxqmxSnoKwVOiG5/13SSh3aPWdD/f9Uhty29z/jZoAW0xEP5milxOGjgOQo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708070428; c=relaxed/simple; bh=I7YQyvteIahvp42EiZA+1wJMmZSJKR2ugc165xDp9JA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Dnw6qHnGze9x/vuyHwwZQr8s+BE5O8gAofGLcp8S6MNleGj/W9+QegQ7C2JXn31RE2Y9ji1D3UIQ2MS31Z5/qbTMqMNrhn2jtDW56UJ/UKyM7l0hTwze4TnXs8Ua+l+1QrCLFaTVciqaMDbFRwlT1pn/jrG1+OTYg9KSHrlx+Xw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DBE+Xc9t; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708070424; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LC1bKFmWstjcuRp0NCZgXGUr7lDByzyZO+jUi4bsRIg=; b=DBE+Xc9tJl/0LeLAU81fPIj28BzWM1ii/y6wBbv4DwWcoXtvCZGEDhVTvP7eYtrQPZvXcm 6cTQXWriR/KdfVQrGY27/kxWmtGuoDZD8kP/QxrSZy50NCf7DiKeeTCeiu3ret5WUlQJdl Q3ob2rSwXumZjTCEyfMqLrEksd10hrc= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-245-FaZWLHlCNle43F5nURfdvg-1; Fri, 16 Feb 2024 03:00:21 -0500 X-MC-Unique: FaZWLHlCNle43F5nURfdvg-1 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-781d8e14fd8so229610385a.3 for ; Fri, 16 Feb 2024 00:00:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708070420; x=1708675220; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LC1bKFmWstjcuRp0NCZgXGUr7lDByzyZO+jUi4bsRIg=; b=Q9kj+fyAmwB+fzbr9FRKaCLXWN/lockWZvS6V35OdWQ2CJQV/jf+wZtIzGwpflYloI BMciXkj0iqoRW28F8gX8pIUfr0nFBgGOToh87t4KrxUmV8gPFfEbxtaHxDAwNmSSTYY2 jq/SWWlw72xmJjNBRDYnzKEzuJI7pav29rlnm1tAYr9kO2narBS2XVaCmhPuJx0xhqUb cuYsRKnaMVkjc7wc0fwKjHLkbmnUbR/iQJDD9K5HFwtWoDs+B4xDSC4QT4rrma5845Nl DS6nKKanvwTNjQjyJ+XhvlR+iPBVZjmB2mlvwkwbyspVMyA5V0vn4H+1uyHlPurhkUTn 0jrQ== X-Gm-Message-State: AOJu0YzhgiZslAMbBauRh6OtYpeLJO9X7/RomN9zIcV6nCKscRb+9eWV kVd2/xeCS9AnvNEqJiS1VrRBisCwMFlFdhFKOgcD1WYpUyZjDHG3l+JQk1iyAgxunMH1EZm2dcj BrlpFk1u6aSs/+BQZUvnN4XgWF8r/ZYsqvDXlbsC/VCndZEGz01M+oLEITh1g2Q== X-Received: by 2002:a05:620a:810:b0:787:28cb:5ab8 with SMTP id s16-20020a05620a081000b0078728cb5ab8mr4048020qks.41.1708070420521; Fri, 16 Feb 2024 00:00:20 -0800 (PST) X-Received: by 2002:a05:620a:810:b0:787:28cb:5ab8 with SMTP id s16-20020a05620a081000b0078728cb5ab8mr4047996qks.41.1708070420262; Fri, 16 Feb 2024 00:00:20 -0800 (PST) Received: from LeoBras.redhat.com ([2804:1b3:a800:4770:9d0:4bac:1782:4637]) by smtp.gmail.com with ESMTPSA id br37-20020a05620a462500b00787346f1edasm1300756qkb.54.2024.02.16.00.00.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Feb 2024 00:00:19 -0800 (PST) From: Leonardo Bras To: Greg Kroah-Hartman , Jiri Slaby , Thomas Gleixner , Tony Lindgren , Andy Shevchenko , John Ogness , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , =?utf-8?q?U?= =?utf-8?q?we_Kleine-K=C3=B6nig?= , Leonardo Bras , Florian Fainelli , Shanker Donthineni Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: [RFC PATCH v2 1/4] irq: Move spurious_deferred bit from BIT(31) to BIT(0) Date: Fri, 16 Feb 2024 04:59:43 -0300 Message-ID: <20240216075948.131372-3-leobras@redhat.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240216075948.131372-2-leobras@redhat.com> References: <20240216075948.131372-2-leobras@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791042417158091522 X-GMAIL-MSGID: 1791042417158091522 Makes sure the threads_handled reserve a bit for that. This will be useful in the next patch in this series. Signed-off-by: Leonardo Bras --- include/linux/irqdesc.h | 9 +++++++++ kernel/irq/manage.c | 4 ++-- kernel/irq/spurious.c | 6 ++---- 3 files changed, 13 insertions(+), 6 deletions(-) diff --git a/include/linux/irqdesc.h b/include/linux/irqdesc.h index d9451d456a733..62aff209315fe 100644 --- a/include/linux/irqdesc.h +++ b/include/linux/irqdesc.h @@ -251,4 +251,13 @@ irq_set_lockdep_class(unsigned int irq, struct lock_class_key *lock_class, __irq_set_lockdep_class(irq, lock_class, request_class); } +#define SPURIOUS_DEFERRED (0x1) +#define SPURIOUS_DEFERRED_SHIFT (1) + +static inline void irq_add_handled(struct irq_desc *desc, int i) +{ + i <<= SPURIOUS_DEFERRED_SHIFT; + atomic_add(i, &desc->threads_handled); +} + #endif diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c index 1782f90cd8c6c..5bc609c7b728c 100644 --- a/kernel/irq/manage.c +++ b/kernel/irq/manage.c @@ -1191,7 +1191,7 @@ irq_forced_thread_fn(struct irq_desc *desc, struct irqaction *action) local_irq_disable(); ret = action->thread_fn(action->irq, action->dev_id); if (ret == IRQ_HANDLED) - atomic_inc(&desc->threads_handled); + irq_add_handled(desc, 1); irq_finalize_oneshot(desc, action); if (!IS_ENABLED(CONFIG_PREEMPT_RT)) @@ -1212,7 +1212,7 @@ static irqreturn_t irq_thread_fn(struct irq_desc *desc, ret = action->thread_fn(action->irq, action->dev_id); if (ret == IRQ_HANDLED) - atomic_inc(&desc->threads_handled); + irq_add_handled(desc, 1); irq_finalize_oneshot(desc, action); return ret; diff --git a/kernel/irq/spurious.c b/kernel/irq/spurious.c index 02b2daf074414..d92f33b2e31ee 100644 --- a/kernel/irq/spurious.c +++ b/kernel/irq/spurious.c @@ -267,8 +267,6 @@ try_misrouted_irq(unsigned int irq, struct irq_desc *desc, return action && (action->flags & IRQF_IRQPOLL); } -#define SPURIOUS_DEFERRED 0x80000000 - void note_interrupt(struct irq_desc *desc, irqreturn_t action_ret) { unsigned int irq; @@ -312,7 +310,7 @@ void note_interrupt(struct irq_desc *desc, irqreturn_t action_ret) if (action_ret == IRQ_WAKE_THREAD) { int handled; /* - * We use bit 31 of thread_handled_last to + * We use bit 0 of thread_handled_last to * denote the deferred spurious detection * active. No locking necessary as * thread_handled_last is only accessed here @@ -328,7 +326,7 @@ void note_interrupt(struct irq_desc *desc, irqreturn_t action_ret) * returned IRQ_HANDLED since the last * interrupt happened. * - * For simplicity we just set bit 31, as it is + * For simplicity we just set bit 0, as it is * set in threads_handled_last as well. So we * avoid extra masking. And we really do not * care about the high bits of the handled