diff mbox series

ACPI: Fix CXL 3.0 structure (RDPAS) in the CEDT table

Message ID 20240216072931.34305-1-hj96.nam@samsung.com
State New
Headers
Series ACPI: Fix CXL 3.0 structure (RDPAS) in the CEDT table |

Commit Message

Hojin Nam Feb. 16, 2024, 7:29 a.m. UTC 
  From: Hojin Nam <hj96.nam@samsung.com>

struct acpi_cedt_rdpas does not match with CXL r3.0 9.17.1.5
Table 9-24. reserved1 and length fields are already added by
struct acpi_cedt_header.

Signed-off-by: Hojin Nam <hj96.nam@samsung.com>
---
 include/acpi/actbl1.h | 2 --
 1 file changed, 2 deletions(-)


base-commit: d37e1e4c52bc60578969f391fb81f947c3e83118

Comments

Rafael J. Wysocki Feb. 16, 2024, 6:39 p.m. UTC | #1 
On Fri, Feb 16, 2024 at 8:29 AM <hj96.nam@samsung.com> wrote:
>
> From: Hojin Nam <hj96.nam@samsung.com>
>
> struct acpi_cedt_rdpas does not match with CXL r3.0 9.17.1.5
> Table 9-24. reserved1 and length fields are already added by
> struct acpi_cedt_header.
>
> Signed-off-by: Hojin Nam <hj96.nam@samsung.com>
> ---
>  include/acpi/actbl1.h | 2 --

This file is part of ACPICA which is a separate project whose code is
used by the Linux kernel.  In order to make changes in the ACPICA
code, please submit a pull request to the upstream ACPICA project on
GitHub.  Once this pull request is merged, you can send a
corresponding Linux patch with a Link: tag pointing to it.  However,
it is not necessary to do so, as the changes will be automatically
included into the ACPICA code in the kernel once a new version of
ACPICA is out.

>  1 file changed, 2 deletions(-)
>
> diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h
> index a33375e055ad..7aff8c39dbd6 100644
> --- a/include/acpi/actbl1.h
> +++ b/include/acpi/actbl1.h
> @@ -571,8 +571,6 @@ struct acpi_cedt_cxims {
>
>  struct acpi_cedt_rdpas {
>         struct acpi_cedt_header header;
> -       u8 reserved1;
> -       u16 length;
>         u16 segment;
>         u16 bdf;
>         u8 protocol;
>
> base-commit: d37e1e4c52bc60578969f391fb81f947c3e83118
> --
> 2.34.1
>
Hojin Nam Feb. 19, 2024, 3:46 a.m. UTC | #2 
On Fri, Feb 16, 2024 at 07:39:15PM +0100, Rafael J. Wysocki wrote:
> On Fri, Feb 16, 2024 at 8:29 AM <hj96.nam@samsung.com> wrote:
> >
> > From: Hojin Nam <hj96.nam@samsung.com>
> >
> > struct acpi_cedt_rdpas does not match with CXL r3.0 9.17.1.5
> > Table 9-24. reserved1 and length fields are already added by
> > struct acpi_cedt_header.
> >
> > Signed-off-by: Hojin Nam <hj96.nam@samsung.com>
> > ---
> >  include/acpi/actbl1.h | 2 --
> 
> This file is part of ACPICA which is a separate project whose code is
> used by the Linux kernel.  In order to make changes in the ACPICA
> code, please submit a pull request to the upstream ACPICA project on
> GitHub.  Once this pull request is merged, you can send a
> corresponding Linux patch with a Link: tag pointing to it.  However,
> it is not necessary to do so, as the changes will be automatically
> included into the ACPICA code in the kernel once a new version of
> ACPICA is out.
>

I submitted PR to the ACPICA project on Github[1].
Thanks for the guide!

Link: https://github.com/acpica/acpica/pull/928 [1]
 
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h
> > index a33375e055ad..7aff8c39dbd6 100644
> > --- a/include/acpi/actbl1.h
> > +++ b/include/acpi/actbl1.h
> > @@ -571,8 +571,6 @@ struct acpi_cedt_cxims {
> >
> >  struct acpi_cedt_rdpas {
> >         struct acpi_cedt_header header;
> > -       u8 reserved1;
> > -       u16 length;
> >         u16 segment;
> >         u16 bdf;
> >         u8 protocol;
> >
> > base-commit: d37e1e4c52bc60578969f391fb81f947c3e83118
> > --
> > 2.34.1
> >
>
diff mbox series

Patch

diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h
index a33375e055ad..7aff8c39dbd6 100644
--- a/include/acpi/actbl1.h
+++ b/include/acpi/actbl1.h
@@ -571,8 +571,6 @@  struct acpi_cedt_cxims {
 
 struct acpi_cedt_rdpas {
 	struct acpi_cedt_header header;
-	u8 reserved1;
-	u16 length;
 	u16 segment;
 	u16 bdf;
 	u8 protocol;