From patchwork Fri Feb 16 06:53:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 201942 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:c619:b0:108:e6aa:91d0 with SMTP id hn25csp338010dyb; Thu, 15 Feb 2024 22:53:58 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVFq+Eqq+ZbcX0YUKiWZatS5mTg01TaVss5HbVQ9HLkpdlZR4K3RhCAyCaORA4Vs9JbHCe1LFdi8UQwxd4e6tJAz21XWw== X-Google-Smtp-Source: AGHT+IFOebBeWH+FfGLhwzzat9RHzcevcRyz8e0GmjN7su9WUfzCebnhnOn3Z/Q3MBC86rBQf7Sl X-Received: by 2002:a17:90a:ee96:b0:28f:ef30:804a with SMTP id i22-20020a17090aee9600b0028fef30804amr3874719pjz.35.1708066438246; Thu, 15 Feb 2024 22:53:58 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708066438; cv=pass; d=google.com; s=arc-20160816; b=Kp/v+cK5W9reLB/YtJmOsFuHHnydv6Ih9ZA5r1Y/QyXt2QixxM7s+TG6/gp2G0hxNX qJG1h4LfKxm2xiTrUuJOPz8RCWsVVi/5z2muZ7nwsB+AY9mRdKOYYqciShlnVuk+2yjy kP++43FdT9aghyWOp+R6luzn81USEC6CepuG0kPyuP7q2PLk1oMq8GmkxjLeIzygs/wf D+mxugCR9Wdqz+GtZfygvojJWdKImQZiQ/lpJAsvepR1txGjLI0UcpCYXNHHVuHk6l8f GGGbRfp3VWUxv11EkYmMyt6IFjN4lq1BCedzvgy/AS19oqCyWp7jtnip6N8sTyOygG0R THbg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=Mzj0DBut/S//5YnuLSAF0Muv8+CzgLlXFX7VoZPX680=; fh=7ii8bnn+ZTeQOxdHt+mw4UkYyxgNVZW5u4vTB84Vals=; b=MFTzjnr2dIUKNEq8EulXggOrM2SjQRK4828vJWK2mIDElrhH06cmoTpmozQHTVV8Cr dJEW2QYirhTPNZELnazw2GtwNJgE7PzAr4CZIlVODo9fjZimldW1KbLITqJXgwfgFcB4 Hcox6wW8o3qSEMQD3z/NjiWcfclNv+JEhOqsm13oQ+g8kwhsKRBC+U0bKa4N6VYM62IP 9tsvNK33aaPyEzt/LC9xwcnCmaNKs9CPUP2lWkp15aLUIH4rc4vS16ifp1d7mzjM17WZ UgidtMR/6g4eXago86MziXfqMhzF0ZB1m0Bxjl2/oeZAPii10ah3pjxmThmfWwV4lpJK qryQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=W6rw1uNd; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-68115-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-68115-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id su8-20020a17090b534800b00298d4416077si2646982pjb.82.2024.02.15.22.53.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 22:53:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-68115-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=W6rw1uNd; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-68115-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-68115-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 149CB286B83 for ; Fri, 16 Feb 2024 06:53:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E9C9E17BB5; Fri, 16 Feb 2024 06:53:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="W6rw1uNd" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68F0E175BC for ; Fri, 16 Feb 2024 06:53:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708066415; cv=none; b=YtChO9X/0SmOtOc1PSdaeVhBO0DnBrdTUiE9NZhY5MwhO7Wr43NkK8wpxTSgj2zyRp1Jo9n9yr2x/yGwiVKYnCFqJt4t8DbKRUjuXafLlDFfocQgm0O9Z/pG+e9yooGXmZrLcoVZOhKMlbLUVoubGmpB+WPi2GFL6ax+NQS0Oew= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708066415; c=relaxed/simple; bh=S4KYIAgS4mvLQSOwp8dAYCk+tnxgKRZCI0XPqNFrrhs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qfh5J0Rc6rT2yJ7cN5DY3PsN+RTPmHxFRMHJWUAMTfIIkFR8MrCYyp0bv0TXJWebga48ajxnNMe/LvdL96EuhQHShqG6HvxCqZDFDHlAHyoeOtNN/Vv2bT1dtRZWA1aG2jvPtrvrG6grnApBzJyocpYfKSBKhd58OeIXkWzXZEA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=W6rw1uNd; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6C93C43390; Fri, 16 Feb 2024 06:53:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708066415; bh=S4KYIAgS4mvLQSOwp8dAYCk+tnxgKRZCI0XPqNFrrhs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=W6rw1uNdI2qWadebU+FZ6zBEiJarygA8OEobGVeQkQxUePa25tpohVS4Yh7qOF7jm QKlWeEUAAqX63u7U4OTFKOQvqEAr/CqKLiZIdyHflQk7meZpfAqw1HdvrUWPHONJmA 943Iuu9VBxclR6A1xNs/H3IJGfsprJrAeylDbmtfCx6ZaYOBqlo0CwxLYYZA/je7nw W/oESRD+0BCAHMxtta6RdXxl5WK0shyOFj1N7f9jlCgUc6P+78zTYb2KY8KXPgh8rR NG/WjZaVKRWSNQ4syOmwIqGR2MZNDTHcfFzdJj5vghS6n2NlUYVFQ2LBWW8svk59pz TVtcWD3fspCKw== From: "Jiri Slaby (SUSE)" To: jani.nikula@linux.intel.com Cc: linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org Subject: [PATCH 01/21] drm/i915: remove unused intel_dvo_dev_ops hooks Date: Fri, 16 Feb 2024 07:53:06 +0100 Message-ID: <20240216065326.6910-2-jirislaby@kernel.org> X-Mailer: git-send-email 2.43.1 In-Reply-To: <20240216065326.6910-1-jirislaby@kernel.org> References: <20240216065326.6910-1-jirislaby@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791037473679711681 X-GMAIL-MSGID: 1791037473679711681 struct intel_dvo_dev_ops's ::create_resources(), ::prepare(), ::commit::, and get_modes() are all unused since their addition in 79e539453b34 (DRM: i915: add mode setting support). Drop all of them. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org --- drivers/gpu/drm/i915/display/intel_dvo_dev.h | 25 -------------------- 1 file changed, 25 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dvo_dev.h b/drivers/gpu/drm/i915/display/intel_dvo_dev.h index f7e98e1c6470..af7b04539b93 100644 --- a/drivers/gpu/drm/i915/display/intel_dvo_dev.h +++ b/drivers/gpu/drm/i915/display/intel_dvo_dev.h @@ -53,12 +53,6 @@ struct intel_dvo_dev_ops { bool (*init)(struct intel_dvo_device *dvo, struct i2c_adapter *i2cbus); - /* - * Called to allow the output a chance to create properties after the - * RandR objects have been created. - */ - void (*create_resources)(struct intel_dvo_device *dvo); - /* * Turn on/off output. * @@ -79,16 +73,6 @@ struct intel_dvo_dev_ops { enum drm_mode_status (*mode_valid)(struct intel_dvo_device *dvo, struct drm_display_mode *mode); - /* - * Callback for preparing mode changes on an output - */ - void (*prepare)(struct intel_dvo_device *dvo); - - /* - * Callback for committing mode changes on an output - */ - void (*commit)(struct intel_dvo_device *dvo); - /* * Callback for setting up a video mode after fixups have been made. * @@ -111,15 +95,6 @@ struct intel_dvo_dev_ops { */ bool (*get_hw_state)(struct intel_dvo_device *dev); - /** - * Query the device for the modes it provides. - * - * This function may also update MonInfo, mm_width, and mm_height. - * - * \return singly-linked list of modes or NULL if no modes found. - */ - struct drm_display_mode *(*get_modes)(struct intel_dvo_device *dvo); - /** * Clean up driver-specific bits of the output */