From patchwork Thu Feb 15 09:26:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pairman Guo X-Patchwork-Id: 201320 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:b825:b0:106:860b:bbdd with SMTP id da37csp283899dyb; Thu, 15 Feb 2024 01:52:59 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUFBwhSN9QsGWqSewxj9QnrRHMVJrPhl3naUscDP6rFQcdeHbZlRjL1IUYcj9gUtqGYopJnyr1iSXZkqtYrvuOfZHQmkg== X-Google-Smtp-Source: AGHT+IE9rhW4FLifQL+5eJ6N2Tp9bu3sWxlJMZPu0NUz/s31W0yPg8ZlqCK9XOr9uRRBWmFKcHLC X-Received: by 2002:a05:6870:9111:b0:219:5a9b:1213 with SMTP id o17-20020a056870911100b002195a9b1213mr1131832oae.15.1707990779332; Thu, 15 Feb 2024 01:52:59 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707990779; cv=pass; d=google.com; s=arc-20160816; b=q9tWVwfeqrXmdnDQ4YElCEALfmG7oxRJevVQeZ2vJBoMjMDSrUlJzl4L2pBipIhZTG z4kCbrpraIyNRhz2QU3SeUPNyXXw5wPb5AbtkftWvxTLqIahEu7aLKBlY+fvdxu77V5s Jn/CD89iCtIHiWGsFT+mYJCeNTH8Jy2MhMxkYpLuSraOAimgzpVjQ+1/5M97Ypj6Xtzb YZt6kst2pSmasSzy07q4v2DAf7zag/vdmyPk1MccWRpJ84/4P0JJqhoXW1WQqENu6F5l V7V/2mq53YjRDDQ+6qMYBMFihXlAC/JKm3vOkNvzcn6fmO3Q8eQL/2EWXQ9P+TwNctAs DA8Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=2k3gIo/M5uDVIvhy4OiNcjz9A7CEfotDP9LhZ8c61hs=; fh=xgG9x4rglCrMBk/Ln4fEpirQtxOun75bCNYKXl310MA=; b=siTeRyjO3Ck8QVOrboKZNQXgdgSkj5Y+/J28Sdrcd8iPyMkTX/EqBnCPoCjJbnNsJ+ C0R+9FJ4HTOwJZ30UFI3IgPGOOqlHHhBS+ccbEGGZIHaJbACWi8zyHWWrPpaboWgccdk RmNKvzBWn8x7kemQgEigHi6CuXyWw3arKxNE0Wp/lIsuJoS1o5oxzN8rX/f/r3qBJFwF /wNn7PbdMXfWUQjMXYX8jSaZSaja6ac/KfnoB/t6ZLyBJwN2yqNmG5inJiDvbTMfGhoW iS1x0D8hfJQU+SxoWdWKUHluDl1NdYbO0XuMlkZr8EKJYC9ylpQrIC2nk+L9Tz3TmSa2 5+yA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=UieDUjTI; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-66535-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-66535-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id s16-20020a63af50000000b005d8e28279bcsi862230pgo.540.2024.02.15.01.52.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 01:52:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-66535-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=UieDUjTI; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-66535-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-66535-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id C95D4B2C32A for ; Thu, 15 Feb 2024 09:28:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 90E7A1B96E; Thu, 15 Feb 2024 09:27:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UieDUjTI" Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB53217BC4; Thu, 15 Feb 2024 09:27:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707989233; cv=none; b=dSUJDV1vUVeCgiMNzKbzK412hahCsMtCBFSSW5Y4C1XRzxSz4PuZD0qMkzcASgVtoclJmNltg0emCH8fCTk1g/i7CeR9LABO7e9dQgWRqmgNWnkLeKmbjZp4XGYXerQKQsOKoNjQZLQRCVUjAfeZYdaWuFjVdxpWPkQhG5BmS4o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707989233; c=relaxed/simple; bh=LRQBpeMvzZRQfMCsOVQ7ufZKVewgbToqGM+AZlaC194=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=GoeccqPK2MXTUGp6ZyGZrnDVsH7+HUpLjIuqI60z1zq304OKRv+I9bj2g4B9lao1iagh6LEgkhWFT4pKkV0IV99Xf8pQUQ584AD9eKM/n3s/jJPpH7M6FxGg6kHN8HbYWe+rWxKWTegH2QCebh+Wq5LgLlv96f0hFedFhU0o0Q8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UieDUjTI; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1d751bc0c15so6180665ad.2; Thu, 15 Feb 2024 01:27:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707989231; x=1708594031; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=2k3gIo/M5uDVIvhy4OiNcjz9A7CEfotDP9LhZ8c61hs=; b=UieDUjTIpjXVCsHqTFl2RUX3lwrUqx3FOraYNREiCdQj5crAdOwQjTdAd+afohDqbz 0PlPQENdJcWiMnQAvomsCH3kEFSNzKlltyKgGBr7DbozjqHphW3kl4Qn1LYsoqACUUci 8BHNTwGhn7z3mJ8+yemM5QBAb4ZKJMKsOuf1cou+EUdJBqoxdMSqTZUfyIBp/Wvg9phd M2ZCiHCi9aU/4fbvwlIIFxLa3bpzIT8By3NeDOVQGC0Q5ZEgxetAsVhK5wQcu75APquU Y9JMBf3xqYNjIY7U7bNsM3keu6k216w3lCd3LaISfGdjZXs6NOcTOlnJIHNsBA4/t8CL NE8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707989231; x=1708594031; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2k3gIo/M5uDVIvhy4OiNcjz9A7CEfotDP9LhZ8c61hs=; b=Y7zu0nOC6501HF5qw0zyA9Z59YCXcHxYppHq0Unv3LgcAaCNCDUu26ELyl3Yqh9TwQ vVVRsA0W5FzpFSNAL2HGy03AfgM3ktOJdxK8C5RDZMFfVrKyPbCx4L7mGpP5nS5rNu7w a2zz3MT2z+co0Q1W0anWoLoizxD8Aj3zxoRhMmxGRl81rtE6nxtXLsvMYOZ7ggXxNkEx wS6c0FeCCRvJ1fRrzezzJdnob7oUvs4VQjucHdpRn+/EeL20HBShFH15PYdk85u4HQyg 8nT7WJmJxdRDbHDHAnsqmkT7ih0nPZDlPiorrO4OcYQvqUM/yh8UCT/YB2SvyRWAccZ0 VCJg== X-Forwarded-Encrypted: i=1; AJvYcCV5BOTahTEZmyrq1+uVqwy/mvjcqhOpBVEGol1zYILFmMyAAhR89wgCLnb8L5B0IQFeQrpQRmihsH/+KhjHYdlxbeoGALZanuEKPKSd X-Gm-Message-State: AOJu0YxtvdvEbb4iLwSy058wgZVn/qLpOpIgdrR1iLaaTV0XIci7Jkju xOg/Pk1MM4THHy3AQVmDVeE5eqYgRLWh/lf0GKgQDYQFsdmx5jdV X-Received: by 2002:a17:902:ce01:b0:1db:96d3:3608 with SMTP id k1-20020a170902ce0100b001db96d33608mr134275plg.2.1707989230953; Thu, 15 Feb 2024 01:27:10 -0800 (PST) Received: from pairface.. ([111.18.198.117]) by smtp.gmail.com with ESMTPSA id j2-20020a170902758200b001d93a85ae13sm798871pll.309.2024.02.15.01.27.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 01:27:10 -0800 (PST) From: Pairman Guo To: mingo@redhat.com, namhyung@kernel.org Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Pairman Guo Subject: [PATCH] Perf: Use fallthrough pseudo-keyword Date: Thu, 15 Feb 2024 17:26:59 +0800 Message-ID: <20240215092659.148946-1-pairmanxlr@gmail.com> X-Mailer: git-send-email 2.43.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790958139237779349 X-GMAIL-MSGID: 1790958139237779349 Hi maintainers, There is a usage of ``/* fall thru */`` in a switch statement in hist_browser__handle_hotkey() that have long been untouched. This patch replaced it with the better and proper pseudo-keyword ``fallthrough;``. Please merge if it is the case. Thank you in advance. Signed-off-by: Pairman Guo --- tools/perf/ui/browsers/hists.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c index 0c02b3a8e..aed835946 100644 --- a/tools/perf/ui/browsers/hists.c +++ b/tools/perf/ui/browsers/hists.c @@ -732,7 +732,7 @@ static int hist_browser__handle_hotkey(struct hist_browser *browser, bool warn_l case '+': if (hist_browser__toggle_fold(browser)) break; - /* fall thru */ + fallthrough; default: return -1; }