From patchwork Wed Feb 14 22:34:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mina Almasry X-Patchwork-Id: 201161 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:b825:b0:106:860b:bbdd with SMTP id da37csp24957dyb; Wed, 14 Feb 2024 14:37:29 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXJs++Y8+5xYlYzUhy7LZxZdiMlqXOwTQ07IsDqvfMd/sRDEEJC2SUjaFJPvRRuwNonWe3DYwS6YDjUSyX7v6aNaxP5rg== X-Google-Smtp-Source: AGHT+IEViPqKHbeSL5MhChf7dXVLHABHjt2nfhlgiaz+H/oGsfVnuBhGIh1Jasv1Fak3g9N9PgNs X-Received: by 2002:ac8:5c0f:0:b0:42d:b25e:4b with SMTP id i15-20020ac85c0f000000b0042db25e004bmr255531qti.34.1707950248914; Wed, 14 Feb 2024 14:37:28 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707950248; cv=pass; d=google.com; s=arc-20160816; b=DBoLUIevxamPg9r2OYyLNweYvXTWenMdIfgWSF3Vz2tvmMCVFSlKWzOuYUfBtvgrdP ZVmp+bKYoAH4Zj+a1miriXlFd0fEwWmwr2YQiiDJL9qPMC3gxSnKiIzcI+hzKB6GQkMD FHQ/5uho2ocPY8U0rp31J4DGFgQV/S3qGUKoldYESXdesn0YunOoTpA1FK2BXObU21SL ELR7wpl4eXL8sMSAbhCYBnJzem9TkCO3dKs6CRsnj9YhzR6J5Fw/B6PWqta5x5amzane w9eo/97t/cBRe7ijICNxvaqs23olE1Zsl3GUNOV85wWuZFHf4WXVsuksAQWE/LGNyqIP J1fA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:from:subject:message-id:references:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:in-reply-to:date :dkim-signature; bh=ODLPgmrC2GnAqjAqHk0mi7EspXfDsuvboDPS66T9iTs=; fh=tZ5SwOGoHz9GNwjeNCkok3dpfLN3HNkkHB04vgxN59M=; b=J0Zzx0cp8h9nSXD9fpRIXzoGzdv3mvqg/tjm3Io8UfvZ0aa+yxqqUpOBe3JwvBWNUg XxB7fllcpOals+itp34mp48jO0Yw4Q8906Vi7xKVDp3RqvG5a6A/7c2aK8nvCx9S8JOB aw1JfmZt2fsMqGF7XpUTgpGW3GaUwXs6A1VML2SfTlcnDlKz3rQFXAFbTP/IYgI9iZmy WoLoMDhy0tVm+mX26ibaFoTEuCfsimMVk+ESQNZ5klrTkQAxwGaBg7EuQV5FGI7ez5Et 6UtY3Fw+WSqmakM3fvOUIWVYJKAWpjwFbzaR1mqCeNhx/jEyWikY+9bMg+4/jeqNeCkk S3tQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=YrF1ny+C; arc=pass (i=1 spf=pass spfdomain=flex--almasrymina.bounces.google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-66057-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-66057-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com X-Forwarded-Encrypted: i=2; AJvYcCWTTkTxIks/CCHa89CBrrMqSZozsPcUMH+yJBxfmVW06BupA2Le6fgS3+QhpaGf0KdEjeAACa7I9cTsSyeARs5g9AkcNw== Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id o22-20020ac87c56000000b0042c3a10bb44si6997736qtv.313.2024.02.14.14.37.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Feb 2024 14:37:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-66057-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=YrF1ny+C; arc=pass (i=1 spf=pass spfdomain=flex--almasrymina.bounces.google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-66057-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-66057-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 794811C24445 for ; Wed, 14 Feb 2024 22:36:52 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E65BB145B1A; Wed, 14 Feb 2024 22:34:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="YrF1ny+C" Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23F162E629 for ; Wed, 14 Feb 2024 22:34:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707950052; cv=none; b=abdzzJ/0jGu8nlRtritZxvmui8RjY7fNmhR7QSk5Z4gs/80G7wY8C+/pIOzeSrMQUmnSEg0z3r12Mol0UgyQ6ObiyQ83+tFRxFfRrZcoj2/Ef1iipyOD2mEknaMruSbdZnJ7GksTpd08PfnQuLVE9FVLcGM8daSMXA57NM3JnI4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707950052; c=relaxed/simple; bh=leH3pMjjZZlhwesnoi+WanMfgfX5sx1qPhM1PONSqZM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=V2cETILpOOuznw1m1DaDXDcR2H0J23dCT/6gdn7DYneArrlnIZM8ifPLffui9isx8L/ByAoiqQDbLho9EeKDBK70FVu+7bg9Lq7B87cNh+POA2Bv801+hoYlR+SGqHCuMHDnxpC4SA/BCUAfGsMFeAR9GDqdwWQZYFvnNgjHcsM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--almasrymina.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=YrF1ny+C; arc=none smtp.client-ip=209.85.219.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--almasrymina.bounces.google.com Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-dc6b26783b4so328345276.0 for ; Wed, 14 Feb 2024 14:34:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707950050; x=1708554850; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=ODLPgmrC2GnAqjAqHk0mi7EspXfDsuvboDPS66T9iTs=; b=YrF1ny+CtmOwFPVMMerAqymwxfndKW1ll0ksnnT9yFezpEgEFrB6p1IN5rvCV04Ycq 1ESeisaVaG3Fs3h+YbEDiCTpqPi2f1AXLImHpBDH1iONH31YckW6kqnOWET6lKPkSig2 ZlfOayTdwT2nVIJL5dT8mKRj9aqPTLHs0dSzRIfPNmEEAF4hz7pp60bW/X+ZxM8wM9+t 06Iwc8Idy2T3FieeadJLFsVTtdzHj2mF21Np1pDf3k7v/i9rzGqPDhdERHwJLtUAteVN w+4+XGWotFR4zlKN1jDGnwjb269j32hiI5VUaJCDzD/qVwOnJReVrnb/eXf8PfQd+uYo 2ACA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707950050; x=1708554850; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ODLPgmrC2GnAqjAqHk0mi7EspXfDsuvboDPS66T9iTs=; b=ghvX/rMxD3JYpjLu3te131lro+kLRkkZlf3Z7AcmZoKAH84eta6iicqXU2WZx2GXXm 9h0eJAEjMHJfurICQiJZekhnTwsnRzvn1BQ9fBR4dmkbpDhCBe6v5iuIKpVgm0NYmOy7 FJkvd7sJRT6fV8oENNgcp4yAkZ4TD2cIxYdZ1aPrDTZQhJ7/iGryqncB39gS8wDAf5Me QztUv5uYcNfwPlaR0zjcggt8UqkkQJ/xdkagPqvwdXuAVDoQvBDBeQCwlRcGSFrFPpeH HVVx5IsYNtR5JvX/qH8idOEwgVpis0NBVO2bHZrMaWgtPsyapB33LBqBGPgQ6GrZEiiD +gGg== X-Gm-Message-State: AOJu0YyowfRCdPPkZ5ORQoGNTL8II24DBWuksbnuawezQKhlZlCeFgeu b1KyBlIejFK6EcHnRgPmY84pr4dl+bhY1tpnUVwK1srzx4gvvfbq8qXep6z4BHwnOzSvNRr8ox1 i2FXkJdv1dQM4rBGK79o2zBVCLTBoh3iZLXdgnHDnSZo7OjWSXWabxu0HbPeUaEdlL3ch3BQwTY Fo59cDCtbdM+QSBI6BgYuadoRAHSP1hpKxwu+CyE4mMxOAtkXLo/j4K2jmWGfTtknePFo= X-Received: from almasrymina.svl.corp.google.com ([2620:15c:2c4:200:e4bb:b13c:bc16:afe5]) (user=almasrymina job=sendgmr) by 2002:a05:6902:10c3:b0:dc6:ebd4:cca2 with SMTP id w3-20020a05690210c300b00dc6ebd4cca2mr97605ybu.11.1707950049630; Wed, 14 Feb 2024 14:34:09 -0800 (PST) Date: Wed, 14 Feb 2024 14:34:02 -0800 In-Reply-To: <20240214223405.1972973-1-almasrymina@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240214223405.1972973-1-almasrymina@google.com> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog Message-ID: <20240214223405.1972973-2-almasrymina@google.com> Subject: [PATCH net-next v8 1/2] net: introduce abstraction for network memory From: Mina Almasry To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Cc: Mina Almasry , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jason Gunthorpe , " =?utf-8?q?Christian_K=C3=B6nig?= " , Shakeel Butt , Yunsheng Lin , Willem de Bruijn X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790915639721160674 X-GMAIL-MSGID: 1790915639721160674 Add the netmem_ref type, an abstraction for network memory. To add support for new memory types to the net stack, we must first abstract the current memory type. Currently parts of the net stack use struct page directly: - page_pool - drivers - skb_frag_t Originally the plan was to reuse struct page* for the new memory types, and to set the LSB on the page* to indicate it's not really a page. However, for compiler type checking we need to introduce a new type. netmem_ref is introduced to abstract the underlying memory type. Currently it's a no-op abstraction that is always a struct page underneath. In parallel there is an undergoing effort to add support for devmem to the net stack: https://lore.kernel.org/netdev/20231208005250.2910004-1-almasrymina@google.com/ netmem_ref can be pointers to different underlying memory types, and the low bits are set to indicate the memory type. Helpers are provided to convert netmem pointers to the underlying memory type (currently only struct page). In the devmem series helpers are provided so that calling code can use netmem without worrying about the underlying memory type unless absolutely necessary. Reviewed-by: Shakeel Butt Signed-off-by: Mina Almasry --- v7: - Fix netmem_ref kdoc. v6: - Applied Reviewed-by from Shakeel. rfc v5: - RFC due to merge window. - Change to 'typedef unsigned long __bitwise netmem_ref;' - Fixed commit message (Shakeel). - Did not apply Shakeel's reviewed-by since the code changed significantly. v4: - use 'struct netmem;' instead of 'typedef void *__bitwise netmem_ref;' Using __bitwise with a non-integer type was wrong and triggered many patchwork bot errors/warnings. Using an integer type causes the compiler to warn when casting NULL to the integer type. Attempt to use an empty struct for our opaque network memory. v3: - Modify struct netmem from a union of struct page + new types to an opaque netmem_ref type. I went with: +typedef void *__bitwise netmem_ref; rather than this that Jakub recommended: +typedef unsigned long __bitwise netmem_ref; Because with the latter the compiler issues warnings to cast NULL to netmem_ref. I hope that's ok. - Add some function docs. v2: - Use container_of instead of a type cast (David). --- include/net/netmem.h | 41 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) create mode 100644 include/net/netmem.h diff --git a/include/net/netmem.h b/include/net/netmem.h new file mode 100644 index 000000000000..d8b810245c1d --- /dev/null +++ b/include/net/netmem.h @@ -0,0 +1,41 @@ +/* SPDX-License-Identifier: GPL-2.0 + * + * Network memory + * + * Author: Mina Almasry + */ + +#ifndef _NET_NETMEM_H +#define _NET_NETMEM_H + +/** + * typedef netmem_ref - a nonexistent type marking a reference to generic + * network memory. + * + * A netmem_ref currently is always a reference to a struct page. This + * abstraction is introduced so support for new memory types can be added. + * + * Use the supplied helpers to obtain the underlying memory pointer and fields. + */ +typedef unsigned long __bitwise netmem_ref; + +/* This conversion fails (returns NULL) if the netmem_ref is not struct page + * backed. + * + * Currently struct page is the only possible netmem, and this helper never + * fails. + */ +static inline struct page *netmem_to_page(netmem_ref netmem) +{ + return (__force struct page *)netmem; +} + +/* Converting from page to netmem is always safe, because a page can always be + * a netmem. + */ +static inline netmem_ref page_to_netmem(struct page *page) +{ + return (__force netmem_ref)page; +} + +#endif /* _NET_NETMEM_H */