From patchwork Wed Feb 14 15:54:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 200997 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:bc8a:b0:106:860b:bbdd with SMTP id dn10csp1309490dyb; Wed, 14 Feb 2024 07:57:12 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCV/AfVCZOaazlfF4p4tz6WhPcSa3u8mzMcbN0mkXVXPJMWfEtyns5vaMv6YW/sW6tRpMWEs5Nit4Q+AUQY1ltvl/pxFIQ== X-Google-Smtp-Source: AGHT+IEM3zodaIondsLbwE56hJD5jBRPfJN7Q9jmTF3CM2uo9I6Sg3wwAZTofn2z2HVXsEECIaPD X-Received: by 2002:a0c:f34d:0:b0:68c:e1f3:81c7 with SMTP id e13-20020a0cf34d000000b0068ce1f381c7mr3071782qvm.54.1707926231920; Wed, 14 Feb 2024 07:57:11 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707926231; cv=pass; d=google.com; s=arc-20160816; b=DBtj9Qp9p/lkVLgTEsCFUVr1K92bVddXCJWFbicPaoL8VCkl2uddHheGkhQLagTVYd 3pUNHnb1avQh+l8l8Uh+3ZQm/UokfJM5Wfsz5SMvSixRO+r5hYrlLjSBFhyv8LMcbFjg d7pMn5n+tBj3LRZUrU+5vJ2eYmJ4ByMw7sxQwUmHKLogfgtDe95R7Coktq5y2M3qwUuw WOxGI60W9LQLAVOTwpqICA/8DEFrq1vb9SwZqBvPRqgM1TABzURb77omK5YLuX6zduYw nA6utBomuX6JrIbZxH3iZD+NZLU5A9XR1w/cdAA8hVfYGLf1nzYsi8FebsKIZ3l6I0Ir 2zYw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=Wk5dUyoIZYlPyAoNfmCGCyI7BNGcUQlog2Oi1Xpz8xQ=; fh=s6/p4YJXFDyEueMbSoi3xKOhFAWocU3MSO54umUEbHA=; b=OSSYYlxiE15jdYr8h8f/QfucgUWtK/jWiYshRIGhwVaBJaNARMyZo3p7Vtj137CUeN rxVK3LbeHc92cujrSCAZ+k+MIYGtctti2bKmXm8zcvLfbT3K8X83WFBagB6idsJXOlh0 WKQCSO7M8A9FnI12Z9sKJsjcoTI1e22eai6r0odzEUw4/SH+nB0HJ+eAcsK+QQzEVNCm bsvsq3h4mufBljI3IvQ9aS1Ult7sNGhZ34ZTlX785qeOWauPClIUmpCbvfDhVqGeUXe/ 96uD1MZrlZ/Blok+J39lvcnUj7tYcEvH81SBvygqewG2IRXawltYAReaBrmrCIN8QND+ wGWw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=l1nGP7Mg; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-65464-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-65464-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org X-Forwarded-Encrypted: i=2; AJvYcCVhoElK3IuBWUcR2GtgEkqY2akovQBNImZQiZmFZR82J8y9edTsxNMFLJe1tfXZbkS6XZva6ETGzuKpGMwhzYJqPAgMWA== Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id ke26-20020a056214301a00b0068cb086b38esi5515314qvb.386.2024.02.14.07.57.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Feb 2024 07:57:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-65464-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=l1nGP7Mg; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-65464-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-65464-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id A3DBB1C2889B for ; Wed, 14 Feb 2024 15:55:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 758CA5FF13; Wed, 14 Feb 2024 15:54:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="l1nGP7Mg" Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A3C95D8EF for ; Wed, 14 Feb 2024 15:54:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707926095; cv=none; b=iPzpyucBiJVPTeH17hFJNaiL2ERLzUVsgLMkycqJQnFEiIrgbANiyDdZStRu3X9p6r7zMOf6kYlAlJAAY1iwlNe1BsRXoceFBYGwEMgnGRmIA519dfqBwyO3Kjo44PoUN7vMZlw2KF8Jgr4IkPvSk98SNGZqZDL4mvMJUW8yYKU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707926095; c=relaxed/simple; bh=wkCnLBusfJsb9wLGU9J3e10BMIuXAljCJnLm6Qx/zJM=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=O3q5GK8FWTubMmWWaTYeOjOo5nCj25gZ0K1WV51Y6Z48uwqgH6WB5nI3kV8V5Gdx/MMwfQonFjuJpIedXf9YVeD5nN0Wr+3H3z9V5pNN+sBA8cwKPWErosItQNDVmfkkJZQrsYvmtB/AyDxeEnwYNyjFlOSCUUxt/dtLD2eq9W8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=l1nGP7Mg; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-a26fa294e56so769407066b.0 for ; Wed, 14 Feb 2024 07:54:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707926092; x=1708530892; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Wk5dUyoIZYlPyAoNfmCGCyI7BNGcUQlog2Oi1Xpz8xQ=; b=l1nGP7Mg8oIEnW1C2S/1Jlx/PWBD9EpVTFINLWNqfyIJd/bF97+k51CHttg6Bd3ZKo DpBJL3P+Ri63XhjkR9p2s3EQKZQJ0KrwjEvmZdBTsgP5uPbIXGk71O5G9z/aUGDv8T9U su/YgNvSSa2xYIMFp4CNCSOQdJOzU5b7S5bLqQ2+njtUXk8337K8wTAPpUjTwlytB8/Q QUi1KtX4BUada/lhbTdOA7/KZjC0gBwTFQFKWkTiys4FaVKTlLvBTrEHEv4nTg61tt+T iQBiV5E1dYJSXAt/g7j5Nw6iK6kaac0GsLQGtjt0Lkp2D1kVnT8wOpmU9a8CosRjvai1 sdKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707926092; x=1708530892; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Wk5dUyoIZYlPyAoNfmCGCyI7BNGcUQlog2Oi1Xpz8xQ=; b=QTBD7Jx5xAkv9cNIduTtOkgCAEHXGh0aEKAx14Dp13wqiU68XBitnUtj8hbGPZbEcr Yv9PIzdfjDyhLKR4/4mTa+G0ZpoL9JmRsmSFwb0biDDwpqKo7TKuDcTOM05EcDJIeTKI /ro/aPFQiASwJhfxrQJZcCyMyQMbHEtDgJQ6j0SeM8d3iXG97u0beCjx4ZlxJQ7yCGYm oxUKuadwHORERKRZ66vDT0VvMJQH0LFzo1BHkTb5EdF+XDyJdlqdVm81yfpndFl+I96j xQob6PpMv4AEMELNEkICkQEPsH+iTzbeI7JcnF3V1D9uUzwv4GGiseu/0FRZ/8+5vhi2 0ijQ== X-Forwarded-Encrypted: i=1; AJvYcCVx+9iW2BsJeCi/Ls3hR1sOU7tepcNE3JwKGyrp+uegVDvKT+NIGDzbko/xxKwisC46bGh4CHHFKbV/i/vq5daN1uil4Gpi6BwTsIsg X-Gm-Message-State: AOJu0Yyjra9cktg32iM6Iu1Bw9tujDJ9cUbosXtkLRoXOEjrzYoLIbNO GdrPG2EpsRY+XSvI3FG0tMXg4roWxPUnvyKDi/Cns2998eRacDhaQCrs3k9RvmY= X-Received: by 2002:a17:906:4a8e:b0:a3d:4dec:2711 with SMTP id x14-20020a1709064a8e00b00a3d4dec2711mr1717774eju.14.1707926091699; Wed, 14 Feb 2024 07:54:51 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWQu9tQKsaS9PrK88jx7RYfwEJi0xXoDW5obHHfRjmj5MxVBVTLvL+XEUpWyl3BTuVlBzB/IZIgTPTNJqhUvAVy4cGhZZ1IGoSacoebuyu7/FBlLD6FgtMOdkWpMZ/37m44Do0YxCSfGer/1SGTwiCgF9YB5+zI94V2PLVmkICErdQE3WkURrUAa6iCp5YiSSh6GgW+68avnLXYywF/8iD22Z7/CJIlr0F7Mpy94T44YhiwPQ1PQ7PKxuU2cciYRR4fDX2pg2G8pMWMhecI1Pg3KXxuKCa5bzOYqMv4FIsfjuzqSVULeIu2++mjK4LcDih0HuTvtGRWLwu2bXflD7pWrXbs/nWYF6m8K5zNxZ/1ijUh7lNBPfKqAGfhNFsRC2hPgk56ViP4EUiqXuTi8sjMPAfe27SoFNFe Received: from krzk-bin.. ([78.10.207.130]) by smtp.gmail.com with ESMTPSA id tk6-20020a170907c28600b00a38936aa08dsm2431332ejc.32.2024.02.14.07.54.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Feb 2024 07:54:51 -0800 (PST) From: Krzysztof Kozlowski To: Linus Walleij , Miguel Ojeda , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robin van der Gracht , Paul Burton , Geert Uytterhoeven , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Ralf Schlatterbeck , Andy Shevchenko Subject: [PATCH v2 1/2] dt-bindings: auxdisplay: adjust example indentation and use generic node names Date: Wed, 14 Feb 2024 16:54:37 +0100 Message-Id: <20240214155438.155139-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790890456619119145 X-GMAIL-MSGID: 1790890456619119145 The example DTS should be indented with two or four (preferred) spaces, as mentioned in Writing Schema document. While re-indenting, change the node names to somehow generic names, as expected by Devicetree specification. Cc: Geert Uytterhoeven Cc: Ralf Schlatterbeck Cc: Andy Shevchenko Reviewed-by: Andy Shevchenko Signed-off-by: Krzysztof Kozlowski Reviewed-by: Geert Uytterhoeven Reviewed-by: Geert Uytterhoeven --- Changes in v2: 1. Previous, removing GPIO expander node is gone, update GPIO expander example as well: node name and indentation. --- .../auxdisplay/arm,versatile-lcd.yaml | 4 +- .../bindings/auxdisplay/hit,hd44780.yaml | 62 ++++++++++--------- .../bindings/auxdisplay/holtek,ht16k33.yaml | 50 +++++++-------- .../bindings/auxdisplay/img,ascii-lcd.yaml | 4 +- 4 files changed, 61 insertions(+), 59 deletions(-) diff --git a/Documentation/devicetree/bindings/auxdisplay/arm,versatile-lcd.yaml b/Documentation/devicetree/bindings/auxdisplay/arm,versatile-lcd.yaml index 5d02bd032a85..439f7b811a94 100644 --- a/Documentation/devicetree/bindings/auxdisplay/arm,versatile-lcd.yaml +++ b/Documentation/devicetree/bindings/auxdisplay/arm,versatile-lcd.yaml @@ -39,6 +39,6 @@ additionalProperties: false examples: - | lcd@10008000 { - compatible = "arm,versatile-lcd"; - reg = <0x10008000 0x1000>; + compatible = "arm,versatile-lcd"; + reg = <0x10008000 0x1000>; }; diff --git a/Documentation/devicetree/bindings/auxdisplay/hit,hd44780.yaml b/Documentation/devicetree/bindings/auxdisplay/hit,hd44780.yaml index 406a922a714e..e26d61af9011 100644 --- a/Documentation/devicetree/bindings/auxdisplay/hit,hd44780.yaml +++ b/Documentation/devicetree/bindings/auxdisplay/hit,hd44780.yaml @@ -84,42 +84,44 @@ additionalProperties: false examples: - | #include - auxdisplay { - compatible = "hit,hd44780"; + display-controller { + compatible = "hit,hd44780"; - data-gpios = <&hc595 0 GPIO_ACTIVE_HIGH>, - <&hc595 1 GPIO_ACTIVE_HIGH>, - <&hc595 2 GPIO_ACTIVE_HIGH>, - <&hc595 3 GPIO_ACTIVE_HIGH>; - enable-gpios = <&hc595 4 GPIO_ACTIVE_HIGH>; - rs-gpios = <&hc595 5 GPIO_ACTIVE_HIGH>; + data-gpios = <&hc595 0 GPIO_ACTIVE_HIGH>, + <&hc595 1 GPIO_ACTIVE_HIGH>, + <&hc595 2 GPIO_ACTIVE_HIGH>, + <&hc595 3 GPIO_ACTIVE_HIGH>; + enable-gpios = <&hc595 4 GPIO_ACTIVE_HIGH>; + rs-gpios = <&hc595 5 GPIO_ACTIVE_HIGH>; - display-height-chars = <2>; - display-width-chars = <16>; + display-height-chars = <2>; + display-width-chars = <16>; }; + - | #include i2c { - #address-cells = <1>; - #size-cells = <0>; + #address-cells = <1>; + #size-cells = <0>; - pcf8574: pcf8574@27 { - compatible = "nxp,pcf8574"; - reg = <0x27>; - gpio-controller; - #gpio-cells = <2>; - }; + pcf8574: gpio-expander@27 { + compatible = "nxp,pcf8574"; + reg = <0x27>; + gpio-controller; + #gpio-cells = <2>; + }; }; - hd44780 { - compatible = "hit,hd44780"; - display-height-chars = <2>; - display-width-chars = <16>; - data-gpios = <&pcf8574 4 0>, - <&pcf8574 5 0>, - <&pcf8574 6 0>, - <&pcf8574 7 0>; - enable-gpios = <&pcf8574 2 0>; - rs-gpios = <&pcf8574 0 0>; - rw-gpios = <&pcf8574 1 0>; - backlight-gpios = <&pcf8574 3 0>; + + display-controller { + compatible = "hit,hd44780"; + display-height-chars = <2>; + display-width-chars = <16>; + data-gpios = <&pcf8574 4 0>, + <&pcf8574 5 0>, + <&pcf8574 6 0>, + <&pcf8574 7 0>; + enable-gpios = <&pcf8574 2 0>; + rs-gpios = <&pcf8574 0 0>; + rw-gpios = <&pcf8574 1 0>; + backlight-gpios = <&pcf8574 3 0>; }; diff --git a/Documentation/devicetree/bindings/auxdisplay/holtek,ht16k33.yaml b/Documentation/devicetree/bindings/auxdisplay/holtek,ht16k33.yaml index be95f6b97b41..b90eec2077b4 100644 --- a/Documentation/devicetree/bindings/auxdisplay/holtek,ht16k33.yaml +++ b/Documentation/devicetree/bindings/auxdisplay/holtek,ht16k33.yaml @@ -74,31 +74,31 @@ examples: #include #include i2c { - #address-cells = <1>; - #size-cells = <0>; + #address-cells = <1>; + #size-cells = <0>; - ht16k33: ht16k33@70 { - compatible = "holtek,ht16k33"; - reg = <0x70>; - refresh-rate-hz = <20>; - interrupt-parent = <&gpio4>; - interrupts = <5 (IRQ_TYPE_LEVEL_HIGH | IRQ_TYPE_EDGE_RISING)>; - debounce-delay-ms = <50>; - linux,keymap = , - , - , - , - , - , - , - , - , - ; + display-controller@70 { + compatible = "holtek,ht16k33"; + reg = <0x70>; + refresh-rate-hz = <20>; + interrupt-parent = <&gpio4>; + interrupts = <5 (IRQ_TYPE_LEVEL_HIGH | IRQ_TYPE_EDGE_RISING)>; + debounce-delay-ms = <50>; + linux,keymap = , + , + , + , + , + , + , + , + , + ; - led { - color = ; - function = LED_FUNCTION_BACKLIGHT; - linux,default-trigger = "backlight"; - }; + led { + color = ; + function = LED_FUNCTION_BACKLIGHT; + linux,default-trigger = "backlight"; }; - }; + }; + }; diff --git a/Documentation/devicetree/bindings/auxdisplay/img,ascii-lcd.yaml b/Documentation/devicetree/bindings/auxdisplay/img,ascii-lcd.yaml index 1899b23de7d1..55e9831b3f67 100644 --- a/Documentation/devicetree/bindings/auxdisplay/img,ascii-lcd.yaml +++ b/Documentation/devicetree/bindings/auxdisplay/img,ascii-lcd.yaml @@ -50,6 +50,6 @@ additionalProperties: false examples: - | lcd: lcd@17fff000 { - compatible = "img,boston-lcd"; - reg = <0x17fff000 0x8>; + compatible = "img,boston-lcd"; + reg = <0x17fff000 0x8>; };