diff mbox series

scsi: jazz_esp: only build if SCSI core is builtin

Message ID 20240214055953.9612-1-rdunlap@infradead.org
State New
Headers
Series scsi: jazz_esp: only build if SCSI core is builtin |

Commit Message

Randy Dunlap Feb. 14, 2024, 5:59 a.m. UTC 
  JAZZ_ESP is a bool kconfig symbol that selects SCSI_SPI_ATTRS.
When CONFIG_SCSI=m, this results in SCSI_SPI_ATTRS=m while
JAZZ_ESP=y, which causes many undefined symbol linker errors.

Fix this by only offering to build this driver when CONFIG_SCSI=y.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202402112222.Gl0udKyU-lkp@intel.com/
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Masahiro Yamada <masahiroy@kernel.org>
Cc: Nicolas Schier <nicolas@fjasle.eu>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/scsi/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Martin K. Petersen Feb. 15, 2024, 8:39 p.m. UTC | #1 
On Tue, 13 Feb 2024 21:59:53 -0800, Randy Dunlap wrote:

> JAZZ_ESP is a bool kconfig symbol that selects SCSI_SPI_ATTRS.
> When CONFIG_SCSI=m, this results in SCSI_SPI_ATTRS=m while
> JAZZ_ESP=y, which causes many undefined symbol linker errors.
> 
> Fix this by only offering to build this driver when CONFIG_SCSI=y.
> 
> 
> [...]

Applied to 6.8/scsi-fixes, thanks!

[1/1] scsi: jazz_esp: only build if SCSI core is builtin
      https://git.kernel.org/mkp/scsi/c/9ddf190a7df7
diff mbox series

Patch

diff -- a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -1279,7 +1279,7 @@  source "drivers/scsi/arm/Kconfig"
 
 config JAZZ_ESP
 	bool "MIPS JAZZ FAS216 SCSI support"
-	depends on MACH_JAZZ && SCSI
+	depends on MACH_JAZZ && SCSI=y
 	select SCSI_SPI_ATTRS
 	help
 	  This is the driver for the onboard SCSI host adapter of MIPS Magnum