diff mbox series

nvmem: core: make nvmem_layout_bus_type const

Message ID 20240214-bus_cleanup-nvmem2-v1-1-97960007da18@marliere.net
State New
Headers
Series nvmem: core: make nvmem_layout_bus_type const |

Commit Message

Ricardo B. Marliere Feb. 14, 2024, 7:04 p.m. UTC 
  Since commit d492cc2573a0 ("driver core: device.h: make struct bus_type
a const *"), the driver core can properly handle constant struct
bus_type, move the nvmem_layout_bus_type variable to be a constant
structure as well, placing it into read-only memory which can not be
modified at runtime.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
---
 drivers/nvmem/layouts.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


---
base-commit: 2c8df24cc166478910c4e9e870adf44d157330fa
change-id: 20240214-bus_cleanup-nvmem2-b77804172a0b

Best regards,

Comments

Greg KH Feb. 15, 2024, 7:49 a.m. UTC | #1 
On Wed, Feb 14, 2024 at 04:04:57PM -0300, Ricardo B. Marliere wrote:
> Since commit d492cc2573a0 ("driver core: device.h: make struct bus_type
> a const *"), the driver core can properly handle constant struct
> bus_type, move the nvmem_layout_bus_type variable to be a constant
> structure as well, placing it into read-only memory which can not be
> modified at runtime.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
> ---
>  drivers/nvmem/layouts.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvmem/layouts.c b/drivers/nvmem/layouts.c
> index 6a6aa58369ff..8b5e2de138eb 100644
> --- a/drivers/nvmem/layouts.c
> +++ b/drivers/nvmem/layouts.c
> @@ -45,7 +45,7 @@ static void nvmem_layout_bus_remove(struct device *dev)
>  	return drv->remove(layout);
>  }
>  
> -static struct bus_type nvmem_layout_bus_type = {
> +static const struct bus_type nvmem_layout_bus_type = {
>  	.name		= "nvmem-layout",
>  	.match		= nvmem_layout_bus_match,
>  	.probe		= nvmem_layout_bus_probe,
> 
> ---
> base-commit: 2c8df24cc166478910c4e9e870adf44d157330fa
> change-id: 20240214-bus_cleanup-nvmem2-b77804172a0b
> 


Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Srinivas Kandagatla Feb. 21, 2024, 7:10 a.m. UTC | #2 
On Wed, 14 Feb 2024 16:04:57 -0300, Ricardo B. Marliere wrote:
> Since commit d492cc2573a0 ("driver core: device.h: make struct bus_type
> a const *"), the driver core can properly handle constant struct
> bus_type, move the nvmem_layout_bus_type variable to be a constant
> structure as well, placing it into read-only memory which can not be
> modified at runtime.
> 
> 
> [...]

Applied, thanks!

[1/1] nvmem: core: make nvmem_layout_bus_type const
      commit: 18e31aed2096896c76ce2867216180fce9cf7275

Best regards,
diff mbox series

Patch

diff --git a/drivers/nvmem/layouts.c b/drivers/nvmem/layouts.c
index 6a6aa58369ff..8b5e2de138eb 100644
--- a/drivers/nvmem/layouts.c
+++ b/drivers/nvmem/layouts.c
@@ -45,7 +45,7 @@  static void nvmem_layout_bus_remove(struct device *dev)
 	return drv->remove(layout);
 }
 
-static struct bus_type nvmem_layout_bus_type = {
+static const struct bus_type nvmem_layout_bus_type = {
 	.name		= "nvmem-layout",
 	.match		= nvmem_layout_bus_match,
 	.probe		= nvmem_layout_bus_probe,