| Message ID | 20240213111600.25269-1-jirislaby@kernel.org |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel+bounces-63412-ouuuleilei=gmail.com@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a05:7300:bc8a:b0:106:860b:bbdd with SMTP id
dn10csp466281dyb;
Tue, 13 Feb 2024 03:17:32 -0800 (PST)
X-Forwarded-Encrypted: i=3;
AJvYcCWMSwn2Eiir0LuKZPKvMtJYWKXKVYv1mNHoAe5B2KXjixmIdtXZW/iBb2HA6ziUpm0uzwLTEKK+J1I8KQgdT4bwZvpm9Q==
X-Google-Smtp-Source:
AGHT+IGgVJWcO+wK3+xh4WnZr7Y1OgbJ5oRyO0jGUoz2Mra9HlozgiVPR7Phx0t1wZQorTnUk8d4
X-Received: by 2002:a17:903:2284:b0:1d9:6940:601 with SMTP id
b4-20020a170903228400b001d969400601mr9776272plh.19.1707823052287;
Tue, 13 Feb 2024 03:17:32 -0800 (PST)
ARC-Seal: i=2; a=rsa-sha256; t=1707823052; cv=pass;
d=google.com; s=arc-20160816;
b=crAVS5XYVuWXtJs5HSXbIpjNUOMBG/QmTWd2Ly8CC1LdftVSRuu9iMQ5MJeU7xEmpr
/WX77+/NwrI0LYQbANjdWiILoBTzLWNGz06oWTBJ9QFzd1j7JGtDtmndWeloICZIX2FA
BXglKlECh8IAvsMjqZ6SB1P9OhkcRqZkGnWbOR2tslZFLisOdHxIfGYigE4l6Y4UMe5H
zV5NMqqdyP0fw7z4BC4wqyBDPpe3kLhH/kIANe4Bn7SPuax1RDDeRX0nCdT9ugMV1i1K
2vnrJ2EMN8uJnqmDWisScgi6VpqkPfGmbhCR0GC1OvmIbb330rsKcN8+THdQEee7ajeS
16Ow==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=content-transfer-encoding:mime-version:list-unsubscribe
:list-subscribe:list-id:precedence:message-id:date:subject:cc:to
:from:dkim-signature;
bh=hKzqqbpJbmvc6xzVzGJAokk9C+5xv6upn0xQahi4RNI=;
fh=Zfl2MnlOztyqk3oTZRZyAQTyWxxsBPa6L/UDYa517nE=;
b=y2XBDO5D6BOY5FpUFqP77UlzOFcJsWylFdXIecqrxbQ9f7veQBAZ4Y3/X0XEcrVyat
SLiM0ToN/NI2vCsagGuOYv6YIDWdM8WpdyWTVEFsn3Vk/jMCps+tgmy4fiQm74xJ7Dbk
b8R8epDiKrc4VdcU8ttfVbey8D/pAfY7DhXE9Okrtikyf9KKlPOgguElnVTX9y1nFmaC
niXXmxNJmM3lW6JTOa41UOtK9pP7XmgECQn0s5JdoEP0SxL4FpzShd5sTf6LxXS6JshM
JbouI+ICs6apUc3IvJoeNLOw2KEaE+c0J6We2MuUrraUHhwKxO7IVlU0pA85VmhLoKrz
kXUA==;
dara=google.com
ARC-Authentication-Results: i=2; mx.google.com;
dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lE5igxZ5;
arc=pass (i=1 dkim=pass dkdomain=kernel.org);
spf=pass (google.com: domain of
linux-kernel+bounces-63412-ouuuleilei=gmail.com@vger.kernel.org designates
139.178.88.99 as permitted sender)
smtp.mailfrom="linux-kernel+bounces-63412-ouuuleilei=gmail.com@vger.kernel.org";
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
X-Forwarded-Encrypted: i=2;
AJvYcCWhyYPxukmc9UF/EF814ZXkdPL9lCq3Ej+EjnT4/blp0r0ZBLHqLQqhRhih7fh7cI+fW/KOvQWXQtLt15UaOdTmeeOFKg==
Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99])
by mx.google.com with ESMTPS id
e1-20020a170902744100b001d9656a267dsi1856991plt.519.2024.02.13.03.17.32
for <ouuuleilei@gmail.com>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 13 Feb 2024 03:17:32 -0800 (PST)
Received-SPF: pass (google.com: domain of
linux-kernel+bounces-63412-ouuuleilei=gmail.com@vger.kernel.org designates
139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Authentication-Results: mx.google.com;
dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lE5igxZ5;
arc=pass (i=1 dkim=pass dkdomain=kernel.org);
spf=pass (google.com: domain of
linux-kernel+bounces-63412-ouuuleilei=gmail.com@vger.kernel.org designates
139.178.88.99 as permitted sender)
smtp.mailfrom="linux-kernel+bounces-63412-ouuuleilei=gmail.com@vger.kernel.org";
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org
[52.25.139.140])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by sv.mirrors.kernel.org (Postfix) with ESMTPS id 41824282FD7
for <ouuuleilei@gmail.com>; Tue, 13 Feb 2024 11:17:09 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
by smtp.subspace.kernel.org (Postfix) with ESMTP id F08D73B18C;
Tue, 13 Feb 2024 11:16:07 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org
header.b="lE5igxZ5"
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org
[10.30.226.201])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by smtp.subspace.kernel.org (Postfix) with ESMTPS id 433DF38DD8;
Tue, 13 Feb 2024 11:16:04 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
arc=none smtp.client-ip=10.30.226.201
ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
t=1707822965; cv=none;
b=GXw3FY7blRlqJI/+1IY6hvLh/eP5cjkhH606A+hFd4pSpiSMCqE4L8MJkDYHv2MaQMgCuvQpLdDeqmLG80JgmP3wiT5nDmuoNaSo2drYBftTU08ixnAKFtnbSsUZ0AWq86/8qJ7pl7kgz8mFshSBCu8SkAqdZypjJZc+t6X3CR8=
ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org;
s=arc-20240116; t=1707822965; c=relaxed/simple;
bh=8/YDPIwx8aNs6n3EAi1Qm6t3uluLFwT/JUQiL7Zhcn4=;
h=From:To:Cc:Subject:Date:Message-ID:MIME-Version;
b=XXPnegY6oX2RpQP5xVycgxG6gBTu6Z9vIT09e2PpJjfRb3slvoKnN4d5Lf91Lv9muGePyMUaaExEn43xGix9cVht2hQZFjFHcMfFUAbNimOs1SnS8Sri9JgH337hFRTZcG4X/86f13STlCJIzcN0/5heX1bil1hZyLLdeS4Jv0E=
ARC-Authentication-Results: i=1; smtp.subspace.kernel.org;
dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org
header.b=lE5igxZ5; arc=none smtp.client-ip=10.30.226.201
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 180F6C43390;
Tue, 13 Feb 2024 11:16:02 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
s=k20201202; t=1707822964;
bh=8/YDPIwx8aNs6n3EAi1Qm6t3uluLFwT/JUQiL7Zhcn4=;
h=From:To:Cc:Subject:Date:From;
b=lE5igxZ59PtoutKDEyWlM2gMtg0IbO8TtSD+cucf5PV5XJ/S2WnpVANxS4OpOFpOf
gBlRPsxQSV9pBuWcAG1w5gp7IutASbSRLaEHazqx89aDCM9aPRcIjTnKN2piqzANkd
7hZ4e1c54qr+Plr09iFAGQA95rLzA5NqYoUzwKpV48vtWTailkand42ozc4G8HIjlX
ULXiYB141GFnADSDbRYkRc2zaONy1kNbWL2vmGeT9NgvN475ft8JnY41Ah4LAWTpfR
uu15NfDAIk44zoi3O5P6190bPYPEI/myZxucdphMfViU5ke1ERONeqSs3R7bYJmSIW
ykWvwC9Lyz1WQ==
From: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
To: rafael@kernel.org
Cc: linux-kernel@vger.kernel.org,
"Jiri Slaby (SUSE)" <jirislaby@kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Len Brown <lenb@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
linux-pm@vger.kernel.org
Subject: [PATCH] cpufreq/intel_pstate: remove cpudata::prev_cummulative_iowait
Date: Tue, 13 Feb 2024 12:16:00 +0100
Message-ID: <20240213111600.25269-1-jirislaby@kernel.org>
X-Mailer: git-send-email 2.43.1
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1790782264808958020
X-GMAIL-MSGID: 1790782264808958020
|
| Series |
cpufreq/intel_pstate: remove cpudata::prev_cummulative_iowait
|
|
Commit Message
Jiri Slaby
Feb. 13, 2024, 11:16 a.m. UTC
Commit 09c448d3c61f (cpufreq: intel_pstate: Use IOWAIT flag in Atom
algorithm) removed the last user of cpudata::prev_cummulative_iowait. So
remove the member too.
Found by https://github.com/jirislaby/clang-struct.
Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Len Brown <lenb@kernel.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-pm@vger.kernel.org
---
drivers/cpufreq/intel_pstate.c | 3 ---
1 file changed, 3 deletions(-)
Comments
On Tue, Feb 13, 2024 at 12:16 PM Jiri Slaby (SUSE) <jirislaby@kernel.org> wrote: > > Commit 09c448d3c61f (cpufreq: intel_pstate: Use IOWAIT flag in Atom > algorithm) removed the last user of cpudata::prev_cummulative_iowait. So > remove the member too. > > Found by https://github.com/jirislaby/clang-struct. > > Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org> > Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> > Cc: Len Brown <lenb@kernel.org> > Cc: "Rafael J. Wysocki" <rafael@kernel.org> > Cc: Viresh Kumar <viresh.kumar@linaro.org> > Cc: linux-pm@vger.kernel.org > --- > drivers/cpufreq/intel_pstate.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c > index ca94e60e705a..5ad3542c0e1e 100644 > --- a/drivers/cpufreq/intel_pstate.c > +++ b/drivers/cpufreq/intel_pstate.c > @@ -201,8 +201,6 @@ struct global_params { > * @prev_aperf: Last APERF value read from APERF MSR > * @prev_mperf: Last MPERF value read from MPERF MSR > * @prev_tsc: Last timestamp counter (TSC) value > - * @prev_cummulative_iowait: IO Wait time difference from last and > - * current sample > * @sample: Storage for storing last Sample data > * @min_perf_ratio: Minimum capacity in terms of PERF or HWP ratios > * @max_perf_ratio: Maximum capacity in terms of PERF or HWP ratios > @@ -241,7 +239,6 @@ struct cpudata { > u64 prev_aperf; > u64 prev_mperf; > u64 prev_tsc; > - u64 prev_cummulative_iowait; > struct sample sample; > int32_t min_perf_ratio; > int32_t max_perf_ratio; > -- Applied as 6.9 material, thanks!
diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c index ca94e60e705a..5ad3542c0e1e 100644 --- a/drivers/cpufreq/intel_pstate.c +++ b/drivers/cpufreq/intel_pstate.c @@ -201,8 +201,6 @@ struct global_params { * @prev_aperf: Last APERF value read from APERF MSR * @prev_mperf: Last MPERF value read from MPERF MSR * @prev_tsc: Last timestamp counter (TSC) value - * @prev_cummulative_iowait: IO Wait time difference from last and - * current sample * @sample: Storage for storing last Sample data * @min_perf_ratio: Minimum capacity in terms of PERF or HWP ratios * @max_perf_ratio: Maximum capacity in terms of PERF or HWP ratios @@ -241,7 +239,6 @@ struct cpudata { u64 prev_aperf; u64 prev_mperf; u64 prev_tsc; - u64 prev_cummulative_iowait; struct sample sample; int32_t min_perf_ratio; int32_t max_perf_ratio;