Message ID | 20240213100238.456912-1-arnd@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-63299-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:bc8a:b0:106:860b:bbdd with SMTP id dn10csp435674dyb; Tue, 13 Feb 2024 02:04:25 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVbsWBXFlQ+JGp1KdQtq5r5bQB3HkIjWSXiam7prVjF8ubDr0lfVozDJNUMBVkIlDsQeTHdOEaKpQCjD9TPh01aQgq55w== X-Google-Smtp-Source: AGHT+IGgMyRjByqE8CTtXrCtMn0z7y3Zx3zzuBqkubikdltB4bdi2Wv4yf2MAuIYophT/+mn1K0n X-Received: by 2002:a25:c70c:0:b0:dcd:3663:b5e5 with SMTP id w12-20020a25c70c000000b00dcd3663b5e5mr41918ybe.25.1707818664786; Tue, 13 Feb 2024 02:04:24 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707818664; cv=pass; d=google.com; s=arc-20160816; b=t+sifzRvGaS0rjCQ5og2T7ohEOjtbBBUeYsmiUvYd3pczNzK6/3FmP36ffJUOIICJA gT2EKkK73lb+BYsFn8m+cO/GHcYiMG5+eoNy+Gk6tanKs96Fri6b9Ac1zIz3mnXM3yeg tSWgJnB2xBAWloWy4u5YkuAKT585d1oX9SoZnAQpE+etl0QTGE9grwHLhCbzogKYy+ap KotXX0CRn+A2hxOJMZto+fAI/ol03eBD6X7Hxz2LvmZHP0v2ZeIqZG5TVW5Z402kktNt dJS1j1SphtbQOFgHy5dvWZyE3qLalKjkzQMT8dGyHBMHQTGXcF9EYa4EJcQRdjOejPTv ZEog== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=cqRDeYC1j0yuZ1WB/1vqEBRZDrNDOrnVwjJxfP9Fwi0=; fh=VXazhKUc45/ERsSsMXXnTIcdHWQJB+PK7ufF9nf8yFM=; b=IdzG+ckb4iNcbBVGGIYI8YE4zOZxJZPICsEB1WWbhdeG3Ie5RtC8JA+Bqs6SYNgdBu eqaoMOzmBIUs2gSK2t2bdpfNlxgNNMgZ+J7PErS40HRq5psfgyseUMqlZXwum1WSSUfo GBvR3AWaT4Ntxzls5luJZ9pQH7FpMp5p5qC+/V25gryFaF+1X0kQ5/Ky7myd7GTnebjW vb/9Y7OY0nbBUNrbe0qJSkU2iFjZfdQQ64NydF7iEA3QtqM+/ZY4vP2ZvNQqDV1QzpPN Z+WUL+Ax9NgiRm3vLNCLuBKYaJjjzbIuZ8MR+vWOY4g5JdZU8Akj837w5y6vbYrta11A gypg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=S7OXrFkF; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-63299-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-63299-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCXlA9nzlKaXyI1uZjVc0YBTcP5ZSAs3agpoCK7i982e79+lFMZ0S092dm4vJb6RrY85fZEE3kp4kLTL1+j2a5HaqI4qLQ== Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id v7-20020a05620a090700b007836d3975b3si7544779qkv.273.2024.02.13.02.04.24 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 02:04:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-63299-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=S7OXrFkF; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-63299-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-63299-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 8F6CD1C2112B for <ouuuleilei@gmail.com>; Tue, 13 Feb 2024 10:04:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E30CF22636; Tue, 13 Feb 2024 10:02:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="S7OXrFkF" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F6D8225AD; Tue, 13 Feb 2024 10:02:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707818564; cv=none; b=NJTKzv7bbpBuPFOgrgkEsD9zwORTnSG6P5mfBc4umbHkabMGo7U97MOTMWpL1nVLaOgd1nd6OnaHFUAEHEsLOyQslS7gb5uJLD7COmygMUqruft86u+/ipvB+7gi3lS0sW4WRcju11nwOMSWFcKZcQCaoiyBBMzxlaxlfIgEZMM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707818564; c=relaxed/simple; bh=PoqpGDtl2PNN6stViwRE7OniT1lnZ+4h8gX5yvog+rE=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=GOaCmLFaoeeXTz0ROpv1S10LY06iadSt3BjM3yCM1tbkJepUpntSSG0kpG2qFuYgAmeLQ6rbvldXdVffBFsG12Uq17UlUD79uwcBcTwLaMWJEznucRXn2a/FEVae3ohSSCJ1sSM3alzmclgDgA6Ok6xHJ85wnTxs+qFUFxbW/tk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=S7OXrFkF; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3B67C433F1; Tue, 13 Feb 2024 10:02:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707818563; bh=PoqpGDtl2PNN6stViwRE7OniT1lnZ+4h8gX5yvog+rE=; h=From:To:Cc:Subject:Date:From; b=S7OXrFkFbOzm1aNy2U+MLDP9ayyBBmRGmQfSVM8f1Tif1Y8g9elXuZPfh2PUVEYwY BjYNxTJZe0dHRrM9RKHACdg6U6p+cds+ENiAkUyGzmgrlMv6DKThg4eC83XSXtC1Lh LK0IEdGdtyFc3PpyhG29mXS0z45PYM7eO6gi1x9QLgHvYDNc0WYtJIX4WG4XSb+t1s Iyzn8gQ+Tm8dk9GKE+yHB40cV50q2wFDw+oF0gxTJvvACP+ZYaymwxiObS6XYUV+0U YjfnWengG31dmMXad3PNOu1ituvRuWAOr8lwXFTItyePpDRSWHF7L0Rfru14aWT6kt 1SKHmmbDTdmeQ== From: Arnd Bergmann <arnd@kernel.org> To: Jean Delvare <jdelvare@suse.com> Cc: Arnd Bergmann <arnd@arndb.de>, Nathan Chancellor <nathan@kernel.org>, Nick Desaulniers <ndesaulniers@google.com>, Bill Wendling <morbo@google.com>, Justin Stitt <justinstitt@google.com>, Greg Kroah-Hartman <gregkh@suse.de>, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: [PATCH] firmware: dmi-id: add a release callback function Date: Tue, 13 Feb 2024 11:02:17 +0100 Message-Id: <20240213100238.456912-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790777664248589088 X-GMAIL-MSGID: 1790777664248589088 |
Series |
firmware: dmi-id: add a release callback function
|
|
Commit Message
Arnd Bergmann
Feb. 13, 2024, 10:02 a.m. UTC
From: Arnd Bergmann <arnd@arndb.de> dmi_class uses kfree() as the .release function, but that now causes a warning with clang-16 as it violates control flow integrity (KCFI) rules: drivers/firmware/dmi-id.c:174:17: error: cast from 'void (*)(const void *)' to 'void (*)(struct device *)' converts to incompatible function type [-Werror,-Wcast-function-type-strict] 174 | .dev_release = (void(*)(struct device *)) kfree, Add an explicit function to call kfree() instead. Fixes: 4f5c791a850e ("DMI-based module autoloading") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/firmware/dmi-id.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/firmware/dmi-id.c b/drivers/firmware/dmi-id.c index 5f3a3e913d28..d19c78a78ae3 100644 --- a/drivers/firmware/dmi-id.c +++ b/drivers/firmware/dmi-id.c @@ -169,9 +169,14 @@ static int dmi_dev_uevent(const struct device *dev, struct kobj_uevent_env *env) return 0; } +static void dmi_dev_release(struct device *dev) +{ + kfree(dev); +} + static struct class dmi_class = { .name = "dmi", - .dev_release = (void(*)(struct device *)) kfree, + .dev_release = dmi_dev_release, .dev_uevent = dmi_dev_uevent, };