Message ID | 20240213060028.9744-1-rdunlap@infradead.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-62989-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:bc8a:b0:106:860b:bbdd with SMTP id dn10csp427911dyb; Tue, 13 Feb 2024 01:46:06 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCU7mxNTmS4XtGWjvX7gYrWXgI6ezlwlnZwLjZYy7dA2LKIcsl7SB57WybEXO8ea9AeU/S0EZ0fJywntHsdMuCorasDE1g== X-Google-Smtp-Source: AGHT+IEj4pAuaOliQEoCAZmhbux8snQeWvo3/vjiQQqFoH0dBOzv/XrYeRJCy6SDbA6zAdCS8v5p X-Received: by 2002:a05:620a:4142:b0:787:2262:aa7f with SMTP id k2-20020a05620a414200b007872262aa7fmr519879qko.31.1707817566358; Tue, 13 Feb 2024 01:46:06 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707817566; cv=pass; d=google.com; s=arc-20160816; b=ZVZKQtXXNWYeJ6gFS5G2NwerDAxMoOJFX0CF9vmd6S9p3H4unvI8pmJF5INYSEZhnT CVrPxtVMiewUD3ih3Q40wPUdGWaCJlitUPhiun1kTBLW5Z608r3q4wDCpGIoI//r1CxY 9o2RQIyYHrkjD0/ABOyB/spGm57B8KN878fDVDIFERjFZM31fl5dnXP+mpiwraQgGsrE IhoQLWye5S/SDWMf/DthqRJ8WHtG6uJaYC/Q69g4tzEFWcw6BHHaZTeLHPfVp2alcYfF GUkaIQYnXHpU6haubpgQgAVxQ0zfsOiyx+atO+KswEbk3G5ov+HK7YEgizcEBCFgb3jR /q9w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=IKBLt5egnDc4D9pBQ3cAmoTpmQYqa60LxJWwLiHkbVs=; fh=IsEQJ3W/gpl1K8JL2eEIf/xd1DzXt5Yz7699JdB7E+M=; b=wkZeMHsNpuhhRrxtxEh1Uki3Z58903WtvAqio/lMDUfSe8UQb0fhkOcq8JRY/igB83 eLhflbFYbXoLBeAaQPdJC2QgMXEFtlkP3t8GdzNyficREUT5nb++VMvYaXg0akLbgzL9 Qps3oYrP4uBPI9Lqx9bgFSx94s41rS2fnysPKSZCTeFUFF563vnkDJfTzL16QIoNhoiU klxa9gJRV994cjGnm1TvOwMkZsbDZLPidXf3tEYUp3dgmZIiI6uBIlRhbkihZheJ4o7T D6A932rT8atD5d8WyV5yLm8jGzl+Ieo7EpSB6Zpy0h5z0uSvCuqNtmXRBcTWEQ5xNc+0 10OQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=pyvpYYSN; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-62989-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62989-ouuuleilei=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=2; AJvYcCX7y6JqHw/S+kruwtJy77ngEZzH+aAcuh/5T11ZeBr2f056GIbVyRGRFAJPnknosmH7WhUvnMaoA/ukIP/H+Q0gyzWZ5Q== Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id y9-20020a05620a09c900b00785d9bbb481si3316697qky.627.2024.02.13.01.46.06 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 01:46:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-62989-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=pyvpYYSN; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-62989-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62989-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id B50D91C23550 for <ouuuleilei@gmail.com>; Tue, 13 Feb 2024 06:06:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 881971799B; Tue, 13 Feb 2024 06:00:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="pyvpYYSN" Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7937914F86 for <linux-kernel@vger.kernel.org>; Tue, 13 Feb 2024 06:00:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707804031; cv=none; b=QWYS38ZLnfLQX7fi7ryH87ZAiFyEw7UyKZSla00f4PbLEjnYCDAsl5JINQm5UsDgkotRggR6XrZbGbVtUcK+NKFQUPHf7jZVqbzXIZxU0gcCx4fh1TYdZAlBr4iKih9l1mU7/RbYhAS2fxdQf9mfgLFXyymy7Qh3mUQlZCwobBc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707804031; c=relaxed/simple; bh=vy2BiWXYPK56LaanMkdunBiBshvbeV4PGbJwLHDWoeM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=BciKJDv2FEai6NAuDJl4IWppP8S6Gl49gbAdLJCLWQrmBy9rK+V7NFraBMZewWNO8fHuVMVWAUpbw0gMatuqYFn96Za8aytwwyxTEb/Ja+8QSoLdzXPD4G1hI8Ddo/nj6+s5dLbboZmPmINufcNEw+BpTwZ0ub5KM+k6cvf7Ylk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=pyvpYYSN; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=IKBLt5egnDc4D9pBQ3cAmoTpmQYqa60LxJWwLiHkbVs=; b=pyvpYYSNNYBvHziRNAzzDcwkl8 6s/Ksm7lwA5llVqidegyj7CDaY5PgNR/usUHzY50VCv1jh4gW1dMbKwAe4/o2SvrGFiIMVVhlxhOZ y44YiNC2cj7/OeG5if7yDRtbmpNnMqu7TesKSZctx/wI8QBe9v0S2qP83tO9hhqx9Mw/xHSy9wv3j Vrcb2Z5edQlC7jOFh804P9CD2/zpiAqUWui3HKK41co74Z2/bM5tj3hKRnpJxYiYym/gaUJiUtjbD DMVJS393k4I8Ob/+HVQiBHuXrfEdmHwK/Qxjke89agDeWlTWwgY9YcbGssmdj2MpjBTUgF58wgiMP bM8shJfA==; Received: from [50.53.50.0] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZlqH-000000083hY-0mD5; Tue, 13 Feb 2024 06:00:29 +0000 From: Randy Dunlap <rdunlap@infradead.org> To: linux-kernel@vger.kernel.org Cc: Randy Dunlap <rdunlap@infradead.org>, Arnd Bergmann <arnd@arndb.de>, MyungJoo Ham <myungjoo.ham@samsung.com>, Chanwoo Choi <cw00.choi@samsung.com>, Marc Zyngier <maz@kernel.org>, Philipp Zabel <p.zabel@pengutronix.de>, Peter Rosin <peda@axentia.se>, Greg Kroah-Hartman <gregkh@linuxfoundation.org> Subject: [PATCH v2] extcon: max8997: select IRQ_DOMAIN instead of depending on it Date: Mon, 12 Feb 2024 22:00:28 -0800 Message-ID: <20240213060028.9744-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790771577274991927 X-GMAIL-MSGID: 1790776512779650351 |
Series |
[v2] extcon: max8997: select IRQ_DOMAIN instead of depending on it
|
|
Commit Message
Randy Dunlap
Feb. 13, 2024, 6 a.m. UTC
IRQ_DOMAIN is a hidden (not user visible) symbol. Users cannot set
it directly thru "make *config", so drivers should select it instead
of depending on it if they need it.
Relying on it being set for a dependency is risky.
Consistently using "select" or "depends on" can also help reduce
Kconfig circular dependency issues.
Therefore, change EXTCON_MAX8997's use of "depends on" for
IRQ_DOMAIN to "select".
Fixes: dca1a71e4108 ("extcon: Add support irq domain for MAX8997 muic")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>
Cc: Marc Zyngier <maz@kernel.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Peter Rosin <peda@axentia.se>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
v2: drop Cc: Donggeun Kim <dg77.kim@samsung.com> (bounced)
drivers/extcon/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
> -----Original Message----- > From: Randy Dunlap <rdunlap@infradead.org> > Sent: Tuesday, February 13, 2024 3:00 PM > To: linux-kernel@vger.kernel.org > Cc: Randy Dunlap <rdunlap@infradead.org>; Arnd Bergmann <arnd@arndb.de>; > MyungJoo Ham <myungjoo.ham@samsung.com>; Chanwoo Choi <cw00.choi@samsung.com>; > Marc Zyngier <maz@kernel.org>; Philipp Zabel <p.zabel@pengutronix.de>; Peter > Rosin <peda@axentia.se>; Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Subject: [PATCH v2] extcon: max8997: select IRQ_DOMAIN instead of depending > on it > > IRQ_DOMAIN is a hidden (not user visible) symbol. Users cannot set it > directly thru "make *config", so drivers should select it instead of > depending on it if they need it. > Relying on it being set for a dependency is risky. > > Consistently using "select" or "depends on" can also help reduce Kconfig > circular dependency issues. > > Therefore, change EXTCON_MAX8997's use of "depends on" for IRQ_DOMAIN to > "select". > > Fixes: dca1a71e4108 ("extcon: Add support irq domain for MAX8997 muic") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: MyungJoo Ham <myungjoo.ham@samsung.com> > Cc: Chanwoo Choi <cw00.choi@samsung.com> > Cc: Marc Zyngier <maz@kernel.org> > Cc: Philipp Zabel <p.zabel@pengutronix.de> > Cc: Peter Rosin <peda@axentia.se> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > v2: drop Cc: Donggeun Kim <dg77.kim@samsung.com> (bounced) > > drivers/extcon/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff -- a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig > --- a/drivers/extcon/Kconfig > +++ b/drivers/extcon/Kconfig > @@ -116,7 +116,8 @@ config EXTCON_MAX77843 > > config EXTCON_MAX8997 > tristate "Maxim MAX8997 EXTCON Support" > - depends on MFD_MAX8997 && IRQ_DOMAIN > + depends on MFD_MAX8997 > + select IRQ_DOMAIN > help > If you say yes here you get support for the MUIC device of > Maxim MAX8997 PMIC. The MAX8997 MUIC is a USB port accessory Applied it. Thanks. Best Regards, Chanwoo Choi
diff -- a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig --- a/drivers/extcon/Kconfig +++ b/drivers/extcon/Kconfig @@ -116,7 +116,8 @@ config EXTCON_MAX77843 config EXTCON_MAX8997 tristate "Maxim MAX8997 EXTCON Support" - depends on MFD_MAX8997 && IRQ_DOMAIN + depends on MFD_MAX8997 + select IRQ_DOMAIN help If you say yes here you get support for the MUIC device of Maxim MAX8997 PMIC. The MAX8997 MUIC is a USB port accessory