diff mbox series

parisc: make parisc_bus_type const

Message ID 20240213-bus_cleanup-parisc-v1-1-2e61c77e66c6@marliere.net
State New
Headers
Series parisc: make parisc_bus_type const |

Commit Message

Ricardo B. Marliere Feb. 13, 2024, 2:38 p.m. UTC 
  Since commit d492cc2573a0 ("driver core: device.h: make struct
bus_type a const *"), the driver core can properly handle constant
struct bus_type, move the parisc_bus_type variable to be a constant
structure as well, placing it into read-only memory which can not be
modified at runtime.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
---
 arch/parisc/include/asm/parisc-device.h | 2 +-
 arch/parisc/kernel/drivers.c            | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)


---
base-commit: 82b143aeb169b8b55798d7d2063032e1a6ceeeb0
change-id: 20240213-bus_cleanup-parisc-93098359acbe

Best regards,

Comments

Greg KH Feb. 13, 2024, 5:29 p.m. UTC | #1 
On Tue, Feb 13, 2024 at 11:38:02AM -0300, Ricardo B. Marliere wrote:
> Since commit d492cc2573a0 ("driver core: device.h: make struct
> bus_type a const *"), the driver core can properly handle constant
> struct bus_type, move the parisc_bus_type variable to be a constant
> structure as well, placing it into read-only memory which can not be
> modified at runtime.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Helge Deller Feb. 16, 2024, 1:58 p.m. UTC | #2 
On 2/13/24 18:29, Greg Kroah-Hartman wrote:
> On Tue, Feb 13, 2024 at 11:38:02AM -0300, Ricardo B. Marliere wrote:
>> Since commit d492cc2573a0 ("driver core: device.h: make struct
>> bus_type a const *"), the driver core can properly handle constant
>> struct bus_type, move the parisc_bus_type variable to be a constant
>> structure as well, placing it into read-only memory which can not be
>> modified at runtime.
>>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

applied to parisc git tree.

Thanks!
Helge
diff mbox series

Patch

diff --git a/arch/parisc/include/asm/parisc-device.h b/arch/parisc/include/asm/parisc-device.h
index 4de3b391d812..7ddd7f433367 100644
--- a/arch/parisc/include/asm/parisc-device.h
+++ b/arch/parisc/include/asm/parisc-device.h
@@ -61,7 +61,7 @@  parisc_get_drvdata(struct parisc_device *d)
 	return dev_get_drvdata(&d->dev);
 }
 
-extern struct bus_type parisc_bus_type;
+extern const struct bus_type parisc_bus_type;
 
 int iosapic_serial_irq(struct parisc_device *dev);
 
diff --git a/arch/parisc/kernel/drivers.c b/arch/parisc/kernel/drivers.c
index c7ff339732ba..ac19d685e4a5 100644
--- a/arch/parisc/kernel/drivers.c
+++ b/arch/parisc/kernel/drivers.c
@@ -618,7 +618,7 @@  static struct attribute *parisc_device_attrs[] = {
 };
 ATTRIBUTE_GROUPS(parisc_device);
 
-struct bus_type parisc_bus_type = {
+const struct bus_type parisc_bus_type = {
 	.name = "parisc",
 	.match = parisc_generic_match,
 	.uevent = parisc_uevent,