From patchwork Mon Feb 12 18:58:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Rogers X-Patchwork-Id: 200001 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:bc8a:b0:106:860b:bbdd with SMTP id dn10csp109420dyb; Mon, 12 Feb 2024 11:00:39 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUAbSXlrGo9UEuHU5OC1KuE21RaMSm9D0mlIms7Qn3wkCs/EGzaDwQ6quKwgY12LyMvtFMaSr+K0ydxy8FcUOr3w6umLA== X-Google-Smtp-Source: AGHT+IHZlarsR8xB0NhkWg2yOd/vCZZ8Ng4Q/VnVuP2nZBzI5TgHUYd0vYhk8FN5rr14eFN2zg/R X-Received: by 2002:a05:620a:148e:b0:785:dac4:351 with SMTP id w14-20020a05620a148e00b00785dac40351mr2383756qkj.31.1707764438929; Mon, 12 Feb 2024 11:00:38 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707764438; cv=pass; d=google.com; s=arc-20160816; b=V4ck2XfAxwHCwCMbrS/5BeYGgaPH/FGQ/5o1h1RQVZq85bU/Pvf0lj33y33OMP524t ZuxFxGV7ZRZ8+XckavKmsDcFtR75dN0iVROcydxF3QJSdv6qWriTyvNLBHgimgkoRNap YcnrsxtRxNps3x6cBSm/+G+M9mHDW2S/LLyfznuwjlzTM3OHpkr+93kCZwpV3MiqIyiq iIaNjLbqx+pOnu6N5e2r4tGsbfOW2WjZF6aWFwMWX5lkJx7vlau6aKk+VlA4kogFsVpV sgWYvzSSq4r6Q1OPQ6OEPimk1KYnKFgQPouVVK39RKJSNZ4Fqfc8pzQqXG8TN4+4kt15 89wQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=to:from:subject:references:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:in-reply-to:date :dkim-signature; bh=FAs57lgcOMUxLgf079L8itwe0kfFXp2CsT7fDYu4PDI=; fh=muGISZHUdySuoEtHqUYRsORZo+/L6SBKDaOk1cksSlM=; b=JlN5dn4cLJdcGuKCdDT7UWwCHnuCTlGqP2PaToVtfPlC0xk9g9lItHkirlSvirQ/A4 MXVHoXOFPaVrui7EIlyBsbLO3PG7Mm5zuWLdXBRG4fvYMOjUXQyZPN2ZDb7IT6OItynU edBk164Jl0Hlz2UdthRsBrZhKdQSGsuKF0f4x3hI80QsB2mKj0vZjVYZj8cqImUi1X7X S2zeIeSqNkyFVvKxzrydfS49K0Nlbva0jv7kGcxGkURyHhznvS4VrDdEoZcmDBNHwsIt B8P+A3lu85YRlt5O5zlvGJBZJC6mNnaTnfsbiB86m9BBMoP/yYifxC3auz5H2AprKS3M raxA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=HGs80CWM; arc=pass (i=1 spf=pass spfdomain=flex--irogers.bounces.google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-62243-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62243-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com X-Forwarded-Encrypted: i=2; AJvYcCXz3G54PFVun2mMiKbVqvQ/doFXyo6PcS2sEwnTIeT9MKv7x1khwexT3IyBmSw4s59Xl+Sra5R0URenmYg6mIhkAUcsxg== Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id wg21-20020a05620a569500b00785ca61c6casi5478008qkn.309.2024.02.12.11.00.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 11:00:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-62243-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=HGs80CWM; arc=pass (i=1 spf=pass spfdomain=flex--irogers.bounces.google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-62243-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62243-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 356421C22511 for ; Mon, 12 Feb 2024 19:00:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 673D94B5A6; Mon, 12 Feb 2024 18:59:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="HGs80CWM" Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2379D47F6C for ; Mon, 12 Feb 2024 18:59:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707764359; cv=none; b=drwzasdiLwS6DcHCzlQMP8FU6N9XIHT9OldJqYiS0o8TchfmMveGVV4NSRYxPeXfhkfTPS0xQpXqs9bvEtb8YYpYUcgsKv8rdcbIEiw4froMI9RbNcc+8XvjupwIsGzE0nqguPBaQW+HQ6jx8UkoDULyS+sj14S9N7vuV23vlZc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707764359; c=relaxed/simple; bh=LBou+XLQ8QDVF7i9zNrb0c+TC2HDLKGD9kRdzvqDd8M=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Content-Type; b=D7ggRGq35O5TkQPn/MYXibxMAKB21+uofn8+FVOs223XUC/uyR/DqlKbovZoXqUW5lLzHuhKJlFgR4JoNss0ed4VFAivclmu19Qavo6jKe1N2XwT7cOkUapaQUT+l3/L/kw2qBJ3b6majYKte1dOrpGU7471Cm7bqEdtLmtAxYI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=HGs80CWM; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-dcbc447ddfeso725685276.1 for ; Mon, 12 Feb 2024 10:59:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707764356; x=1708369156; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=FAs57lgcOMUxLgf079L8itwe0kfFXp2CsT7fDYu4PDI=; b=HGs80CWMzD8pcAUY1jRbxc/aYbownwLRYBYA83vBUAtJYVtFpKvup9XaGpO0muRX6S dtKmOKiTT2Mon+xo0DqCzxqKnyBx0luCM/Xuig3+tVnlA2laEzAfIJNyOar7iTrQ/vcV Bdc06BggdZddTwXW6xjZSVlXdU1VRLoSb8jOY541/2W8c3GV0SdOthe3si8zT1IvkxLw k4u5C8CcsVG/3oS62NCzBMXW1pizYRfKPV6nTk4PmjyOauAthQ7oaUfiCDrZPKR9Y0tk FAXHVuUaOz8ik1VrvH5YENVMP5MHwLqoBMz7HhbN/uk1YF+qLZ5fExsY6bEs0ERXPK8k FWpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707764356; x=1708369156; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FAs57lgcOMUxLgf079L8itwe0kfFXp2CsT7fDYu4PDI=; b=IZn0wMEfiimvtrZhW1oPQvcLpLKIbSjLd5rcviMeCcCQhCfw20a52srx0NoA8uv/Jp IGxptU9BymOgzOCiBMg7sd64FOoTf4K9bzxCeXoQaaW4fIHxtBj4VCldidll021MbL2x daQ9tv45ZlSnzA6G/I+hwZVBQrp4EeJdz5NCtpN529D+UBf5Rox0defhMfIUmACIxS4P DouXOwXDlyRtzhCZbit6JrvbE5pGQnBsVXv1cPDNgxcbtCui2DiANQcI5UWk87y6i4RW UUN9rb+IZX9Z0AieWoV9STatdqqPKd0Rtl8VFz3EQtjdubLqGiLC7svn1ml4AsliOuEE vBvQ== X-Forwarded-Encrypted: i=1; AJvYcCWp4Zp4qMMR6HS9Oy012d6TZCxZpZhAHwOe4f+bh2dGIRiziIHcquq2Nrq82/cTsYrZTiiQKc8iNnq9rxiKJQX73O+e7rjqDXs1Fxw0 X-Gm-Message-State: AOJu0YwH+ep+VRjoWrAD0l/oC9j666BSjsPQodXAuGbI+Q00MaDM3mnT 7ZBEAoKalNSDxXASRwKDOKB7C7X7D0/gvOcmfw5rDhIuCUr7RRc/6NPMzBlkjNeAaDBW5gkNs8v J4fYi9g== X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:125c:bcda:4fe2:b6e6]) (user=irogers job=sendgmr) by 2002:a05:6902:1007:b0:dc6:e20f:80cb with SMTP id w7-20020a056902100700b00dc6e20f80cbmr348338ybt.3.1707764356106; Mon, 12 Feb 2024 10:59:16 -0800 (PST) Date: Mon, 12 Feb 2024 10:58:54 -0800 In-Reply-To: <20240212185858.68189-1-irogers@google.com> Message-Id: <20240212185858.68189-5-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240212185858.68189-1-irogers@google.com> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog Subject: [PATCH v3 4/8] tools subcmd: Add a no exec function call option From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , James Clark , Athira Jajeev , Kan Liang , Yang Jihong , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, llvm@lists.linux.dev X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790720803959662892 X-GMAIL-MSGID: 1790720803959662892 Tools like perf fork tests in case they crash, but they don't want to exec a full binary. Add an option to call a function rather than do an exec. The child process exits with the result of the function call and is passed the struct of the run_command, things like container_of can then allow the child process function to determine additional arguments. Signed-off-by: Ian Rogers --- tools/lib/subcmd/run-command.c | 2 ++ tools/lib/subcmd/run-command.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/tools/lib/subcmd/run-command.c b/tools/lib/subcmd/run-command.c index 5cdac2162532..d435eb42354b 100644 --- a/tools/lib/subcmd/run-command.c +++ b/tools/lib/subcmd/run-command.c @@ -122,6 +122,8 @@ int start_command(struct child_process *cmd) } if (cmd->preexec_cb) cmd->preexec_cb(); + if (cmd->no_exec_cmd) + exit(cmd->no_exec_cmd(cmd)); if (cmd->exec_cmd) { execv_cmd(cmd->argv); } else { diff --git a/tools/lib/subcmd/run-command.h b/tools/lib/subcmd/run-command.h index 17d969c6add3..d794138a797f 100644 --- a/tools/lib/subcmd/run-command.h +++ b/tools/lib/subcmd/run-command.h @@ -47,6 +47,8 @@ struct child_process { unsigned exec_cmd:1; /* if this is to be external sub-command */ unsigned stdout_to_stderr:1; void (*preexec_cb)(void); + /* If set, call function in child rather than doing an exec. */ + int (*no_exec_cmd)(struct child_process *process); }; int start_command(struct child_process *);