From patchwork Mon Feb 12 17:01:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 200031 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:bc8a:b0:106:860b:bbdd with SMTP id dn10csp167500dyb; Mon, 12 Feb 2024 13:05:44 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXFpFOEFUxZii9XCqJReL3fxPevValNfDxWu5/erzyHG+XRKE3IJhM1xDYU9qULLS3D0egbmNb58BcGVCA3yxgXYGlPJA== X-Google-Smtp-Source: AGHT+IHkey+qK2mCCVn49FX/QONY7Y42nWJB/SdOYxXLn7ae3jF68LT1DTwxTjFTqXqVuFo73N/9 X-Received: by 2002:a17:903:120d:b0:1d9:adc9:2962 with SMTP id l13-20020a170903120d00b001d9adc92962mr737536plh.20.1707771944108; Mon, 12 Feb 2024 13:05:44 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707771944; cv=pass; d=google.com; s=arc-20160816; b=Kb4ORpoy+/WbytP2Ui7vVaLM3lL4/4DgVImt+ql0tDcbcfrZJU4pLib+8LBPy/P7jq WoJg3sO53k9Fu05RjbodSAqPAQ3d2uRNxChJI8zssL+gF5sQHkuZ4RrxxAles2QePsD3 unOGnhioX2PkwJwSEB/zZRmU6B7kVxu4ZtXBIK7rdWlKM0vjzCplGVPwGaKO4C0THmYr XCw28ZcguYBVTr9VyX9WC163qZ6Vu6LwM91N23mkImMFrYpMs5DkxxXXCsutqsXTZYbF D37CDbhis+JriirPF7l5ifZ/T45j8XvOG3ggtb8WIfp/8wzSIjxtx6RQfybuqzxRHd0g fXaw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=AOqpC7l/E/vfwk/M1hwkJOZablnU70sx8ddiG/mlhW8=; fh=cmC+gPTvjTnNDVqEIEBcgbWa587i8gsnevvODFLKqeU=; b=sVOiYNcAsizoomMzAFmFtWhJTv7UkuDuvgBet4c0ZRPizcko+zuU96NNbAMxE1qDs8 t8PT5HxkTOnaFU6wOJ9EJq1Xbf5etBohqc1HOrETaAs2klaVwtt5kBcM0ARy2Zaqclwi Oze+CjINcovTbCKzK8fBoQBzibw6yMHy+bMRfxXRPRBEcuYbg7k2zAPJQTg30SE2KwLA qfC0z3L8nJ2/nKiz0WEkkGdC2BXDaZaHCt1c6gdGgUfVJM0CHsgzafMb1e/U30gEvOn5 wsWQnlPKSMSzttKPLe0UrN/btQX3j52fExmZDf1lphY26kvhWiCvtZODDzZDqSRS1gBj NtIg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="OMdePW/9"; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-62055-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62055-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com X-Forwarded-Encrypted: i=2; AJvYcCVP6I1N5gCoTaUqtbkI/tDn4O81B2ZzDbdE3jJ6J3B9CThDDy8W6JqX+7T5/m6BZJ8P69hx5H+6nkWhGfMIjJszb4NMAg== Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id iy6-20020a170903130600b001d9fcd34721si782413plb.119.2024.02.12.13.05.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 13:05:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-62055-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="OMdePW/9"; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-62055-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62055-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id B5856B255CD for ; Mon, 12 Feb 2024 17:10:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 746814EB42; Mon, 12 Feb 2024 17:05:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="OMdePW/9" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 086A43DB91; Mon, 12 Feb 2024 17:04:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707757497; cv=none; b=emhMFCdm18isDK02kWGD17nqNPez9GSf0HknpMlNr9WWWJEdu265Dyq5q75xteM7vzP8CkLvIIEV35p4efpa21/hPgZzaoVceim1K98/zhs4GsrUky3sNwGwUMp7Mr3CTuyi010mpgzPmv6gWPAzxv3yPtkFEI0JtAcROjYHToE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707757497; c=relaxed/simple; bh=5fFTptxgaNSrb8/J39Uzrc6cETbfYvICnOp+m4GRuCg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UCiUmE69CGr+BvVMdbEM1inc+R4bjYGmcawCJy8p9h+W96F5G4Q/6+drba/xaBIcjAozaxsDMHfPDsyKtI1xOiPKEgpse73RRsvd5JgvN0Oxl4BHUXrk7YZFbSY7b9Ee4QFvAApL2+qUiNpx/ib6JdPYME49QJBmlthIvRVb8sI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=OMdePW/9; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707757496; x=1739293496; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=5fFTptxgaNSrb8/J39Uzrc6cETbfYvICnOp+m4GRuCg=; b=OMdePW/9xIUPxFEXT6IiC9GrQziBbcASWrlTI9YCtfoX3rlmZTNJe9px VzaEw9M2VITtJQREcA/wXVG2km9xXeXhUHJmaq5wqmf2Nm6F20ZV1Yz6c 9oqaPtcziIE6nCrU3cslbWhx+eXloZvftAOA7LHwroTZ70Qg2cly7paoK xPsJueaZP65fBzGXY8kwaY/rbGCXk1jLAlC/i2m4OGl6y5fZR5JJwXtrw +UbrZuG+Q30i7KOgzWu1a5/7Gt4EP5YC4je4BhE71dYKc9iALaB6scbXi o42UeBzo9Q8AG9OFKuA6eE7NnNHDKciiB1+6S8At5mwFvJ0ALY5h0/Rlx A==; X-IronPort-AV: E=McAfee;i="6600,9927,10982"; a="19153235" X-IronPort-AV: E=Sophos;i="6.06,264,1705392000"; d="scan'208";a="19153235" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2024 09:04:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10982"; a="935116828" X-IronPort-AV: E=Sophos;i="6.06,264,1705392000"; d="scan'208";a="935116828" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 12 Feb 2024 09:04:47 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 1402933F; Mon, 12 Feb 2024 19:04:43 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andy Shevchenko , Geert Uytterhoeven , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robin van der Gracht , Paul Burton Subject: [PATCH v2 11/15] auxdisplay: ht16k33: Move ht16k33_linedisp_ops down Date: Mon, 12 Feb 2024 19:01:44 +0200 Message-ID: <20240212170423.2860895-12-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240212170423.2860895-1-andriy.shevchenko@linux.intel.com> References: <20240212170423.2860895-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790728673998869931 X-GMAIL-MSGID: 1790728673998869931 We will need the update functions to be defined before ht16k33_linedisp_ops. Move the latter down in the code. No functional change intended. Signed-off-by: Andy Shevchenko Acked-by: Robin van der Gracht Reviewed-by: Geert Uytterhoeven --- drivers/auxdisplay/ht16k33.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c index 0cdf3fbdf81e..75c4a8d31642 100644 --- a/drivers/auxdisplay/ht16k33.c +++ b/drivers/auxdisplay/ht16k33.c @@ -440,18 +440,6 @@ static void ht16k33_keypad_stop(struct input_dev *dev) disable_irq(keypad->client->irq); } -static void ht16k33_linedisp_update(struct linedisp *linedisp) -{ - struct ht16k33_priv *priv = container_of(linedisp, struct ht16k33_priv, - seg.linedisp); - - schedule_delayed_work(&priv->work, 0); -} - -static const struct linedisp_ops ht16k33_linedisp_ops = { - .update = ht16k33_linedisp_update, -}; - static void ht16k33_seg7_update(struct work_struct *work) { struct ht16k33_priv *priv = container_of(work, struct ht16k33_priv, @@ -489,6 +477,18 @@ static void ht16k33_seg14_update(struct work_struct *work) i2c_smbus_write_i2c_block_data(priv->client, 0, ARRAY_SIZE(buf), buf); } +static void ht16k33_linedisp_update(struct linedisp *linedisp) +{ + struct ht16k33_priv *priv = container_of(linedisp, struct ht16k33_priv, + seg.linedisp); + + schedule_delayed_work(&priv->work, 0); +} + +static const struct linedisp_ops ht16k33_linedisp_ops = { + .update = ht16k33_linedisp_update, +}; + static int ht16k33_led_probe(struct device *dev, struct led_classdev *led, unsigned int brightness) {