From patchwork Sun Feb 11 06:24:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 199371 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:50ea:b0:106:860b:bbdd with SMTP id r10csp1804621dyd; Sat, 10 Feb 2024 23:00:25 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXEMU96GC0FIbv+F0Vivr29Qqr4Qt9rqD+n86qpo29JAd5z5OMhsUGt2NjqSdMMSjl+RM7WUXf06Q+RbgVEKqZ7xDxC8g== X-Google-Smtp-Source: AGHT+IEdD51sNSo5wKzvEvy2Mj2y9bNZOtSm3fHVUS4nBze9I6XedpdcK1SiwvetdeJ8LdOt5oK+ X-Received: by 2002:a05:620a:12e4:b0:785:b3b7:513e with SMTP id f4-20020a05620a12e400b00785b3b7513emr6371037qkl.9.1707634825016; Sat, 10 Feb 2024 23:00:25 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707634825; cv=pass; d=google.com; s=arc-20160816; b=qIaQv2El5KnSrnZqCD2ynXXUdgUPxYLKSiOiuD0I6n/D4SmgI27Ur17/oOdO0cO7Ha 9bZg5e0Mj9L9p7uu2CYKQ/9IjnFyhMY9jnBK+LhDkw2XtIrOR0anqfeed6S9eVkSNaWg LsygfI5gVzMhkpEbuYvOyYDwP8LqboXgOueQ6uuZggCUty1yJKw5YKQkjTFKPVy0slC9 M2yEM0F0vo4Rnly7BX1nlk5/PfxvY1pVJznqdgMWb3ZyvGFbZxI+efgxc2t09mb8HC9F qfI5cDy2c8nS3l5uOdJxvNCSxXd/gsn9X6NAwUlGinG2Bum+ku7CCAAaOfudZSG9a/LR lnrA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=duXlDOFIqmRCHP4x6D44mmwH+nyj5pj32pQL3O49Fd8=; fh=y8R08t6L/m/bSWNd43AkJcHWonRkhSt/q8vK1JUp0hE=; b=f/ri33Wp/KqN5R91WMUpbcYOdJX6eAHzSFRD7zcF+V87JXS47YYK1LjeoYdDz+7je/ GjCilbwja+iniD5YQDvKhs6s2tOkUF3suGP9TZo3oQS1vqyGNftpwMLVDOgwpn5JRGSb BX3hxVMhyX8ZlEZrF7CmM/3CtQAer14xYyItJXawax7OWZ/Pb2ykcV41wcjNpBwlHh7I NPfsNKvsb6rO9UE4G2NtC/CKULX14zlbIVjbn+maqbOfWT8XmDxr5AdEroLcKYv74zW0 gZD1EAX5JSDjKfNzYR8hhOK1dfCtDqnVpXMycWRN8zA6P7Pi12qx82XCtU1ES91NjCfU hpMA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=OeHMihjG; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-60642-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-60642-ouuuleilei=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=2; AJvYcCWMQpLS8ds8cpda1MI6vKHE15tY7O+VYHsys5ckMnxGg4+Kesg7CbNE0PTTnxYLU054+FPwFit1g53QL38UZzkqQpeGCQ== Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id dv25-20020a05620a1b9900b00785d3c8c7a0si143487qkb.340.2024.02.10.23.00.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Feb 2024 23:00:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-60642-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=OeHMihjG; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-60642-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-60642-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 2B0ED1C2091D for ; Sun, 11 Feb 2024 06:25:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 79C5317545; Sun, 11 Feb 2024 06:24:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="OeHMihjG" Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F2DA17546 for ; Sun, 11 Feb 2024 06:24:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707632695; cv=none; b=akPeYIzKTpuEoJdCEiAEeywXI/feXdTlOFwP9CruG/LvQrQciq7x72YPaUcsrxqiZRMAijKFNDBFn8jhIS1zT0GikVUfY71yuJigCOzpYqei6OObOskUD8511+hj0NYHkf+VmwWQjyyV4cRRVtC9P95vJKnh5/HA7YIWZZviTPs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707632695; c=relaxed/simple; bh=TWnmXLjFtf+KqVyj6IgcwqUp+Pq7eD50KiSfsrNZSmg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=XcNoCER4wpZpYG7elHo9WrzCuSVVLJF9urj62Q/MrNvia/IAlgZunkChozRjR0ySbubSV399FndUkFr3NkALYmCEm/qIMRMV6oxFefwBXGji6iRxGZt0f1XWVyvMzdQxrSsKVyhiMocpWmH+Z8WK3ZDNEeWfjbCGYkToolg0qac= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=OeHMihjG; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=duXlDOFIqmRCHP4x6D44mmwH+nyj5pj32pQL3O49Fd8=; b=OeHMihjGzj7kBEE3fMvKtvr5iQ juNNMkHkIKIRSYC307VJqpP/G0RkUWalUUF9uy/dB4mvA1TAAc7tWy/x1L/oK41lXKXY33U0F1PgG ycptED8uD/OeuFQroV7dj3TpASLTb+y2eeW4j94QJ4E3sErGsY+qvqde7rIxUB+ZPGwJQtI0xnEAk o340f0/S5SJBs85sCmZ8Wjpthvt5OuWJCQaH0C713z2KhfQ/OnH4GigxvdHxNYtQ/9eD9IGfrsYlA iW+BbAORJqLMFrdHU4N9AjRhIvS3BwJNEh26gRCfRmKTCnQkxP/FN31CQ36rXvrdanh3VkHavfsZ4 e2jIXMGw==; Received: from [50.53.50.0] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZ3Gm-00000002PCT-2Occ; Sun, 11 Feb 2024 06:24:52 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org Subject: [PATCH v2] x86/insn-eval: fix function param name in get_eff_addr_sib() Date: Sat, 10 Feb 2024 22:24:52 -0800 Message-ID: <20240211062452.16411-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790584892934886248 X-GMAIL-MSGID: 1790584892934886248 Change "regoff" to "base_offset" in 2 places in the kernel-doc comments to prevent warnings: insn-eval.c:1152: warning: Function parameter or member 'base_offset' not described in 'get_eff_addr_sib' insn-eval.c:1152: warning: Excess function parameter 'regoff' description in 'get_eff_addr_sib' Signed-off-by: Randy Dunlap Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Dave Hansen Cc: x86@kernel.org --- v2: rebase & resend arch/x86/lib/insn-eval.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff -- a/arch/x86/lib/insn-eval.c b/arch/x86/lib/insn-eval.c --- a/arch/x86/lib/insn-eval.c +++ b/arch/x86/lib/insn-eval.c @@ -1129,15 +1129,15 @@ static int get_eff_addr_modrm_16(struct * get_eff_addr_sib() - Obtain referenced effective address via SIB * @insn: Instruction. Must be valid. * @regs: Register values as seen when entering kernel mode - * @regoff: Obtained operand offset, in pt_regs, associated with segment + * @base_offset: Obtained operand offset, in pt_regs, associated with segment * @eff_addr: Obtained effective address * * Obtain the effective address referenced by the SIB byte of @insn. After * identifying the registers involved in the indexed, register-indirect memory * reference, its value is obtained from the operands in @regs. The computed * address is stored @eff_addr. Also, the register operand that indicates the - * associated segment is stored in @regoff, this parameter can later be used to - * determine such segment. + * associated segment is stored in @base_offset; this parameter can later be + * used to determine such segment. * * Returns: *