From patchwork Sat Feb 10 23:49:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?=C5=81ukasz_Bartosik?= X-Patchwork-Id: 199327 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:50ea:b0:106:860b:bbdd with SMTP id r10csp1700497dyd; Sat, 10 Feb 2024 15:51:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IGJnU7+mi8l7qUM8kXwL9fTkj/e4Jdv2c8wU4FJbu95RCp+TES+yd+lGieU0Ch8srtjZ+d4 X-Received: by 2002:ac8:4e8e:0:b0:42c:63a8:5c9f with SMTP id 14-20020ac84e8e000000b0042c63a85c9fmr2845105qtp.33.1707609105355; Sat, 10 Feb 2024 15:51:45 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707609105; cv=pass; d=google.com; s=arc-20160816; b=rftWlC2JxXEgfFkZiImk4itmcDTta2eyWfB65Um/+n6PXnKli7JOwMmL1kgPMvs3ku Xe+kr+TCaU46zOJe68/4mm0trYV3b7Hf6JlnKHKVhqC7HzAZgjAqMZbJxro4r86o/Wer 5nuoKfLpnkenFxkYn3G57UksQwCfrJlc+g2L2tUBRKA6/bfqxseRo77HCWohzObEUOTQ iCfsYfKBD/gDJgRf84kTezJ0nkexmB9S1frHVjVyzFol7VcUPA4nZA52+UZ/ct3gz6gr TAz8BpWx+lCbfJcOshKkynnKBno3c3+T8Ob0QvaemM8KHSVn3bGiiz7oZGOumzXO+of4 dpKw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=ly40RGk0505qZZwJrMXVp+0btu3kjXk0eZbz7jDJEP8=; fh=lBBZMKEe8qj1g4sq83oOs03+UN3MpksOOZ1SbsxMawk=; b=PLryxK2UE03q/9/hMVtSuaE6BZ0OxNo9LheXqWHMBVUj/xvwSwbppSjQUC9+//rVsP X64AZ1cBaux0iP7w55UPuRCCu3cShINAvh3sNKDw0+0dL65HpOaiBEaX1wsVQ9FIVeN5 k89/pEGxrG2p1sC8IsApdo3ERyUuYNP5s6/lIYM6Sv6etrgMctti+AciXQuchGQpjGG2 xeaPrNZAaPSD7X0Cf223F5yogats2Ll8RgSZDYkBq6l21n8X0fT7cIKU3NsignI4v4bk EkrjMA/exnzS7gYzMTXyORThbhEGZhSmEw27sZvdmK364A8R7q2Iv3lm8/JWUVrs/5jT my/w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=PB8zS2jS; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-60586-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-60586-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org X-Forwarded-Encrypted: i=2; AJvYcCVBReAOns9q9YZvglivVXAn/BXJ7mGVrzTniGrWFrm63CSukcLTAmNUK2UuRWdluXFi/QvX7DrJpzQQS+9SebJ4wZJRDA== Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id b23-20020a05620a119700b00785ba2b09f4si2816499qkk.214.2024.02.10.15.51.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Feb 2024 15:51:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-60586-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=PB8zS2jS; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-60586-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-60586-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 1315B1C2122A for ; Sat, 10 Feb 2024 23:51:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DFB19605AA; Sat, 10 Feb 2024 23:50:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="PB8zS2jS" Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81A3160246 for ; Sat, 10 Feb 2024 23:50:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707609038; cv=none; b=URedz/+kf5eHZq4k1P30WRexfSWF2LnQ9S/IcHjEG1zoNqS9Fm0nPQod3agcMi9ivigU9/TbZjoWxkvK6Z2+i81oct1EKUmjuv0+opxRQExk9J6AXctz+9v6Z0/uwBZsuhqH+lO+zfgbfbKAz7R6Nd0R3ZAKnUNO+uPd82zJG1I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707609038; c=relaxed/simple; bh=242XzWlkrmIbWKryguVx0gbpFFR2SSZonxu1VaG0yK8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Mk46e8NhN56bQGWERHIYDYplJagTUUt0nTPBAJudv/uvTGVId+0Ofq7mnp+/YQuvCGZNq8zyZaOMLr3oZZqAkUpoahghI+rmHgdcVWAMEDeHYwCe+GIvcQLbJ8faUxtrwm6lUalS6zlrQGEzVgvnm1nQbbDHUSnfsaua9TyxRc4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=PB8zS2jS; arc=none smtp.client-ip=209.85.208.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-2d073b54359so29828201fa.0 for ; Sat, 10 Feb 2024 15:50:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1707609034; x=1708213834; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ly40RGk0505qZZwJrMXVp+0btu3kjXk0eZbz7jDJEP8=; b=PB8zS2jSs1y++yx9b7ngXmi7ZiZZFcRlNrwrSkne5yYdxwmCHnaZUBsQoq1b+cVCLV RU1961sLdyLpEsTszWZpwaE719yJhYPM4W0qXR6oKBnU3pJuc5srNhA+zeujdnj9Bgc4 q1wV5HcWxowhzhJPf6o4GHkXbJVN5E0NwCbpQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707609034; x=1708213834; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ly40RGk0505qZZwJrMXVp+0btu3kjXk0eZbz7jDJEP8=; b=BJUT40ax2NBIay5qRYNuIn+bQIMoYsM0ez8H2Fwzr54vJaFuApcKj/0uS4qSy9oYiF anAvaFo+nBsVGgzgVXNUQ7RZY9UfPcKEGnEcJTpnTQg5aB7g1bnISjhrMaLRVrnJ5CyT Rxsq8i5QEqkWjyIYY7R3gVBudmHvVVlm+BF1Rpn2NVIf2QP3puLBfUCn3yAlB2IowfFM gl4CcgUWfXnlS4Rf6lG0SceDDTWT6H++U5YTF1pfQ+xex3j28B8EOPoEbGnXQxVbDHt1 c40USg0QbHxkk1H2NQPCw2228rtv1CurhXUspFJK46feaGAVvlQeSdlMWOJF2BK/18hH /GTQ== X-Gm-Message-State: AOJu0Yx0uNI+WiYdJSjHM3ZgKPhxXs5zfyDRRhV1c1oX4UloVAoM235G Fk6mVIUDGOk53dJcjWlIkJYQxJxVL+qqj+1Q1m7iXSnKWYjO9ty3pUG+akS0G8vwEaoxiHc/ag= = X-Received: by 2002:a05:6512:238d:b0:511:81ed:1a53 with SMTP id c13-20020a056512238d00b0051181ed1a53mr1860445lfv.42.1707609034272; Sat, 10 Feb 2024 15:50:34 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVBg465FgvzkgKJbJecrQpVIvaSXaGMrZD1YX9kJKKqsnesrwM9NAcdeckeKPzTEJwYAY6MLfbXseetLZXpYG15LWw+X8FSTw37Vwn8NKjNCcadSBu7C8q5SfYpa0sSg1Wj686rA7yNclSsHYnFBugs1hoGIjgOPz6MD5XjBLn/w2V87A4A3ltukN09Fqae4YqqWundx/ECz8ja2yZ+fuUtKfR5ZuyD77MR7DGJaj3WuF8XGZXZ+zDot3tiZU/eQhv9ckSxFL9+gSc9Q2t8KL2yec+rMnyYZsLdjP3o4CJ7X7fYUr9t3sC5b36UtbuH4g+80ooCOwCoNTaWPPdAgEyQvlXOdOOMwU87sxu8wxk94pCCm9vmP3JTRPsGJ6t127GuqsHE/mz9xFJuZ2rmZr8kn7gg5b9HtQvQEtYImVUKcM5X+Y08CXuqxUWWkzUCH82/lUhVE1xo/+d17CtQyQS1vZZVmlkYHPrC7+ssRKI4s5VGvuIaB0fQ4QdyZGJyO6JEIJY5aKUe1f2GfU58KZm/EH1OkQSK3bRcotWpCIOi2Wq4KDHwxGjn3QdwtQl1wJkOvKu7CzbhA6SZ+UNRHq8Nr8ShKIr+uQgE8qYSWeGO3+Re7g== Received: from ukaszb-l.roam.corp.google.com (alfa56.extreme-net.one.pl. [213.77.89.56]) by smtp.gmail.com with ESMTPSA id o27-20020a056512051b00b0051179ae1846sm365561lfb.280.2024.02.10.15.50.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Feb 2024 15:50:33 -0800 (PST) From: =?utf-8?q?=C5=81ukasz_Bartosik?= To: Jason Baron , Jim Cromie , Greg Kroah-Hartman , Andrew Morton , Kees Cook , Douglas Anderson Cc: Guenter Roeck , Yaniv Tzoreff , Benson Leung , Steven Rostedt , Vincent Whitchurch , Pekka Paalanen , Sean Paul , Daniel Vetter , Simon Ser , John Ogness , Petr Mladek , Sergey Senozhatsky , linux-kernel@vger.kernel.org, upstream@semihalf.com Subject: [PATCH v4 03/39] dyndbg: add write events to tracefs code Date: Sun, 11 Feb 2024 00:49:33 +0100 Message-ID: <20240210235009.2405808-4-ukaszb@chromium.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240210235009.2405808-1-ukaszb@chromium.org> References: <20240210235009.2405808-1-ukaszb@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790557925093248131 X-GMAIL-MSGID: 1790557925093248131 From: Jim Cromie adds: ddebug_trace() uses trace_console() temporarily to issue printk:console event uses internal-ish __ftrace_trace_stack code: 4-context buffer stack, barriers per Steve Rostedt call it from new funcs: ddebug_printk() - print to both syslog/tracefs ddebug_dev_printk() - dev-print to both syslog/tracefs These handle both _DPRINTK_FLAGS_PRINTK and _DPRINTK_FLAGS_TRACE cases, allowing to vsnprintf the message once and use it for both, skipping past the KERN_DEBUG character for tracing. Finally, adjust the callers: __ddebug_{pr_debug,{,net,ib}dev_dbg}, replacing printk and dev_printk with the new funcs above. The _DPRINTK_FLAGS_TRACE flag character is 'T', so the following finds all callsites enabled for tracing: grep -P =p?T /proc/dynamic_debug/control This patch,~1,~2 are basically copies of [1] with a few differences: - s/dynamic_/ddebug_/ on Vincent's additions - __printf attrs on the _printk funcs - reuses trace_console() event, not adding a new "printk:dyndbg" event. next patch replaces this with 2 new events [1] https://lore.kernel.org/lkml/20200825153338.17061-1-vincent.whitchurch@axis.com CC: vincent.whitchurch@axis.com Signed-off-by: Jim Cromie --- .../admin-guide/dynamic-debug-howto.rst | 5 +- lib/dynamic_debug.c | 156 +++++++++++++++--- 2 files changed, 133 insertions(+), 28 deletions(-) diff --git a/Documentation/admin-guide/dynamic-debug-howto.rst b/Documentation/admin-guide/dynamic-debug-howto.rst index 0e9b48daf690..90449a04946e 100644 --- a/Documentation/admin-guide/dynamic-debug-howto.rst +++ b/Documentation/admin-guide/dynamic-debug-howto.rst @@ -209,8 +209,9 @@ of the characters:: The flags are:: - p enables the pr_debug() callsite. - _ enables no flags. + p callsite prints to syslog + T callsite issues a dyndbg:* trace-event + _ enables no flags Decorator flags add to the message-prefix, in order: t Include thread ID, or diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index ee0cb37153ef..016f33c20251 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -36,6 +36,7 @@ #include #include #include +#include #include @@ -90,6 +91,7 @@ static inline const char *trim_prefix(const char *path) static const struct { unsigned flag:8; char opt_char; } opt_array[] = { { _DPRINTK_FLAGS_PRINTK, 'p' }, + { _DPRINTK_FLAGS_TRACE, 'T' }, { _DPRINTK_FLAGS_INCL_MODNAME, 'm' }, { _DPRINTK_FLAGS_INCL_FUNCNAME, 'f' }, { _DPRINTK_FLAGS_INCL_SOURCENAME, 's' }, @@ -858,6 +860,98 @@ static inline char *dynamic_emit_prefix(struct _ddebug *desc, char *buf) return buf; } +/* + * This code is heavily based on __ftrace_trace_stack(). + * + * Allow 4 levels of nesting: normal, softirq, irq, NMI. + */ +#define DYNAMIC_TRACE_NESTING 4 + +struct ddebug_trace_buf { + char buf[256]; +}; + +struct ddebug_trace_bufs { + struct ddebug_trace_buf bufs[DYNAMIC_TRACE_NESTING]; +}; + +static DEFINE_PER_CPU(struct ddebug_trace_bufs, ddebug_trace_bufs); +static DEFINE_PER_CPU(int, ddebug_trace_reserve); + +static void ddebug_trace(const char *fmt, va_list args) +{ + struct ddebug_trace_buf *buf; + int bufidx; + int len; + + preempt_disable_notrace(); + + bufidx = __this_cpu_inc_return(ddebug_trace_reserve) - 1; + + if (WARN_ON_ONCE(bufidx > DYNAMIC_TRACE_NESTING)) + goto out; + + /* For the same reasons as in __ftrace_trace_stack(). */ + barrier(); + + buf = this_cpu_ptr(ddebug_trace_bufs.bufs) + bufidx; + + len = vscnprintf(buf->buf, sizeof(buf->buf), fmt, args); + trace_console(buf->buf, len); + +out: + /* As above. */ + barrier(); + __this_cpu_dec(ddebug_trace_reserve); + preempt_enable_notrace(); +} + +__printf(2, 3) +static void ddebug_printk(unsigned int flags, const char *fmt, ...) +{ + if (flags & _DPRINTK_FLAGS_TRACE) { + va_list args; + + va_start(args, fmt); + /* + * All callers include the KERN_DEBUG prefix to keep the + * vprintk case simple; strip it out for tracing. + */ + ddebug_trace(fmt + strlen(KERN_DEBUG), args); + va_end(args); + } + + if (flags & _DPRINTK_FLAGS_PRINTK) { + va_list args; + + va_start(args, fmt); + vprintk(fmt, args); + va_end(args); + } +} + +__printf(3, 4) +static void ddebug_dev_printk(unsigned int flags, const struct device *dev, + const char *fmt, ...) +{ + + if (flags & _DPRINTK_FLAGS_TRACE) { + va_list args; + + va_start(args, fmt); + ddebug_trace(fmt, args); + va_end(args); + } + + if (flags & _DPRINTK_FLAGS_PRINTK) { + va_list args; + + va_start(args, fmt); + dev_vprintk_emit(LOGLEVEL_DEBUG, dev, fmt, args); + va_end(args); + } +} + void __dynamic_pr_debug(struct _ddebug *descriptor, const char *fmt, ...) { va_list args; @@ -872,16 +966,18 @@ void __dynamic_pr_debug(struct _ddebug *descriptor, const char *fmt, ...) vaf.fmt = fmt; vaf.va = &args; - printk(KERN_DEBUG "%s%pV", dynamic_emit_prefix(descriptor, buf), &vaf); + ddebug_printk(descriptor->flags, KERN_DEBUG "%s%pV", + dynamic_emit_prefix(descriptor, buf), &vaf); va_end(args); } EXPORT_SYMBOL(__dynamic_pr_debug); void __dynamic_dev_dbg(struct _ddebug *descriptor, - const struct device *dev, const char *fmt, ...) + const struct device *dev, const char *fmt, ...) { struct va_format vaf; + unsigned int flags; va_list args; BUG_ON(!descriptor); @@ -891,16 +987,18 @@ void __dynamic_dev_dbg(struct _ddebug *descriptor, vaf.fmt = fmt; vaf.va = &args; + flags = descriptor->flags; if (!dev) { - printk(KERN_DEBUG "(NULL device *): %pV", &vaf); + ddebug_printk(flags, KERN_DEBUG "(NULL device *): %pV", + &vaf); } else { char buf[PREFIX_SIZE] = ""; - dev_printk_emit(LOGLEVEL_DEBUG, dev, "%s%s %s: %pV", - dynamic_emit_prefix(descriptor, buf), - dev_driver_string(dev), dev_name(dev), - &vaf); + ddebug_dev_printk(flags, dev, "%s%s %s: %pV", + dynamic_emit_prefix(descriptor, buf), + dev_driver_string(dev), dev_name(dev), + &vaf); } va_end(args); @@ -913,6 +1011,7 @@ void __dynamic_netdev_dbg(struct _ddebug *descriptor, const struct net_device *dev, const char *fmt, ...) { struct va_format vaf; + unsigned int flags; va_list args; BUG_ON(!descriptor); @@ -922,22 +1021,24 @@ void __dynamic_netdev_dbg(struct _ddebug *descriptor, vaf.fmt = fmt; vaf.va = &args; + flags = descriptor->flags; if (dev && dev->dev.parent) { char buf[PREFIX_SIZE] = ""; - dev_printk_emit(LOGLEVEL_DEBUG, dev->dev.parent, - "%s%s %s %s%s: %pV", - dynamic_emit_prefix(descriptor, buf), - dev_driver_string(dev->dev.parent), - dev_name(dev->dev.parent), - netdev_name(dev), netdev_reg_state(dev), - &vaf); + ddebug_dev_printk(flags, dev->dev.parent, + "%s%s %s %s%s: %pV", + dynamic_emit_prefix(descriptor, buf), + dev_driver_string(dev->dev.parent), + dev_name(dev->dev.parent), + netdev_name(dev), netdev_reg_state(dev), + &vaf); } else if (dev) { - printk(KERN_DEBUG "%s%s: %pV", netdev_name(dev), - netdev_reg_state(dev), &vaf); + ddebug_printk(flags, KERN_DEBUG "%s%s: %pV", + netdev_name(dev), netdev_reg_state(dev), &vaf); } else { - printk(KERN_DEBUG "(NULL net_device): %pV", &vaf); + ddebug_printk(flags, KERN_DEBUG "(NULL net_device): %pV", + &vaf); } va_end(args); @@ -953,26 +1054,29 @@ void __dynamic_ibdev_dbg(struct _ddebug *descriptor, { struct va_format vaf; va_list args; + unsigned int flags; va_start(args, fmt); vaf.fmt = fmt; vaf.va = &args; + flags = descriptor->flags; if (ibdev && ibdev->dev.parent) { char buf[PREFIX_SIZE] = ""; - dev_printk_emit(LOGLEVEL_DEBUG, ibdev->dev.parent, - "%s%s %s %s: %pV", - dynamic_emit_prefix(descriptor, buf), - dev_driver_string(ibdev->dev.parent), - dev_name(ibdev->dev.parent), - dev_name(&ibdev->dev), - &vaf); + ddebug_dev_printk(flags, ibdev->dev.parent, + "%s%s %s %s: %pV", + dynamic_emit_prefix(descriptor, buf), + dev_driver_string(ibdev->dev.parent), + dev_name(ibdev->dev.parent), + dev_name(&ibdev->dev), + &vaf); } else if (ibdev) { - printk(KERN_DEBUG "%s: %pV", dev_name(&ibdev->dev), &vaf); + ddebug_printk(flags, KERN_DEBUG "%s: %pV", + dev_name(&ibdev->dev), &vaf); } else { - printk(KERN_DEBUG "(NULL ib_device): %pV", &vaf); + ddebug_printk(flags, KERN_DEBUG "(NULL ip_device): %pV", &vaf); } va_end(args);