diff mbox series

[v4,24/39] dyndbg: report err in ddebug_parse_flags when read_args fails

Message ID 20240210235009.2405808-25-ukaszb@chromium.org
State New
Headers
Series dyndbg: add support for writing debug logs to trace |

Commit Message

Łukasz Bartosik Feb. 10, 2024, 11:49 p.m. UTC 
  From: Jim Cromie <jim.cromie@gmail.com>

read_args() fails on '_' (the last opt-char), and returns null.
report this against the opt-char.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
 lib/dynamic_debug.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 089765afc972..3d0c6b5faa31 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -903,8 +903,11 @@  static int ddebug_parse_flags(const char *str, struct flag_settings *modifiers)
 				read_args = opt_array[i].read_args;
 				if (read_args) {
 					str = read_args(str, modifiers);
-					if (!str)
+					if (!str) {
+						pr_err("err on '%c'\n",
+						       opt_array[i].opt_char);
 						return -EINVAL;
+					}
 				}
 				break;
 			}