From patchwork Sat Feb 10 23:49:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?=C5=81ukasz_Bartosik?= X-Patchwork-Id: 199359 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:50ea:b0:106:860b:bbdd with SMTP id r10csp1704996dyd; Sat, 10 Feb 2024 16:06:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IGsL7ONp1t2O5LjqhhQsFolEW5wdOGZsVcH1J++VHaXlzlhT5UGcunQCfx6yhiaVen1UL+v X-Received: by 2002:a05:6358:8a8:b0:176:55c4:ad94 with SMTP id m40-20020a05635808a800b0017655c4ad94mr3998717rwj.8.1707610003523; Sat, 10 Feb 2024 16:06:43 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707610003; cv=pass; d=google.com; s=arc-20160816; b=xA4BlzkYqPc1/0nN3f39oRgDKVzcjrZ/+3QOHOSG64XwR4KPmihVZbziqTO9jTQy/A XA+G2VSSfs3l1NPuueyflVsqFxHY0T6pidEA/XCGaV2icjSXRv8gJhAVvyP65Vf0umdw QJxA2y0rzvzwuGVq1dyfT3XM7bNK0f/gqB6IzhxB++Tq5qYWFsXfoK4SKSys1dI/SAVO LUq/SAR7H+mQwrx4amSLN+U89qG3CTx/vUnHZsWbhjw/m5efgNbLdRqh5Gnq1ybFAe8L nA8DzqLRjMb9tRKMm8BTfVDK2Q89ilV0it7ANqOkZ6cip1U6/SoeWqyf+MY4z/+MoMuA rBGg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=eFBKfV90tnVCKuDzo1hfvS3bOF2HEydpBXLRzyT1NsA=; fh=IE9baq3ULDx21swCSFXXzatP2VnugTTWwenTl0gB9hw=; b=SqVvcQMj2QRzdLmEkGP7Jfqpq63DZ1fNHK7SG6IFbDXrwfsC7bb8gJcsGSg96/NoI9 INtvOIDR33kutXMYd7fXYofnHXUplnFEUvjFC7mwlbMWasY8/6Ti7b2bWDGpAu7mbEoe ah2X9JR5GILaWKESfRiMmC5wuxBsnxPuxI7lekd/IAtOSCMCmpMHbjwAO2qv6n+cjw5I U7FxuZt0Pbj5Gokwn9I0/3o/9kXLekIQG16DkDb1K5ERRUaYVBwEhxBqmuetOGGpyyjE Qduy9/sctiGz+NZBcEsW7EcG5nDmHY0MQYj4Dkkwe8M7SraL8fv9Ssz5TM7PI+r7Yyvp aIfA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=TKZ+M8l3; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-60606-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-60606-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org X-Forwarded-Encrypted: i=2; AJvYcCVTqKNnIEhZcOzoGNkDjlzonVjotXBmUMFSJCU0V802yPAGHCu+o0mTVQ/uTl434U/lhE1OZBhwDFaAOIiwdQEQ1CDaAA== Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id o17-20020a639211000000b005dbec0a0adfsi4027952pgd.320.2024.02.10.16.06.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Feb 2024 16:06:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-60606-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=TKZ+M8l3; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-60606-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-60606-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id CFD9928824B for ; Sat, 10 Feb 2024 23:56:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 885DF63100; Sat, 10 Feb 2024 23:51:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="TKZ+M8l3" Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1163162802 for ; Sat, 10 Feb 2024 23:51:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707609071; cv=none; b=F7AZS3H3+mL4yjU0MEVf7aBG/AIVFcx9TOkVVeDRuPkUEMttIHfM1D3Q+6H/XPyDIWGQZAMGl/RZlSQ21NDklLwImiyeioN3R918T/ln3iReWqjyiEFKaKU98QOeCKXXTkBu0CLqAlX9yywVhy9DLM+uZm26h8F9kwggSUWF3Zk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707609071; c=relaxed/simple; bh=jg05zPtAl9j/yTZ1g89+XrwMdlHjTcXit8rTUQ5mFfE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JtFC7tGl9NPqNd3fQyK+4LvdEW/xdmlzP5L+jE754942Ky+QONa9csTqaK8KecoTJE9mxZuHc/jD3+tFDWwHi2OUMwL57ENMLc7DZOxfXKrX9hf2l4oYzkV4IMHjNEtlusuXLqzQty/taPxZ6tQmvdg2BMNS28Ey1CRpg6oCPMM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=TKZ+M8l3; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-5116b2dbd16so1948428e87.1 for ; Sat, 10 Feb 2024 15:51:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1707609068; x=1708213868; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eFBKfV90tnVCKuDzo1hfvS3bOF2HEydpBXLRzyT1NsA=; b=TKZ+M8l3jqCFmiJdbMxuoHcGsdAiwIB7s2LTSrhZIrU4tconuaVdwuGI/wpDquyq3P zBFpEJdpbWs/41vhTSIkj5TBN5sjjhrzfruSQnJqxfD+YiARueN9cHjkq1xFL4UfpCAj pzQ+qK9cZd7vPu1ETaYHLjgizlSOYYtzjw6ls= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707609068; x=1708213868; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eFBKfV90tnVCKuDzo1hfvS3bOF2HEydpBXLRzyT1NsA=; b=ltSVcnUo3gaffu2LxsBqOY2sWk/zQ7TX83/mbKpB/LcQBLl0k8cWVSsCupvkx8pfY2 K/p1FxNbnGH0HNXzorKxovOz3NDnoYJrNP7wFqjOlI4qV7pRoxf8Up5BwCeMPywJZ6O0 U/E+x9q0+/skOeJquwxxg5chaNjm5mAN05r3SBAK5MPRZ5/uHZ5WEXpHMEpFCSxVWLJ1 zq3T+oKZxQ0Pq8jxU5/2Dxb+e0OZcoH/pbQpJJojNGSjw1+RxrcI/dCft0GZQtAY4KF6 IDNQfl7uoJercBJfLiJGAw1/3N9aWULNlkKUeHv2KDx0JfcFq3IGrKb53xlhDHSithSs ZQNA== X-Gm-Message-State: AOJu0YytFRi69k8Oj7egFI3yQah43S77T1W7wLWnwNqh+9OJh5hp14Hz QYIgt7Dr5YkPKUbCpZNUCJs95+vCaf2geS1u3JlMnxgbb4tJWhDw31eptHqT X-Received: by 2002:a05:6512:282a:b0:511:7b35:9ba2 with SMTP id cf42-20020a056512282a00b005117b359ba2mr1214823lfb.0.1707609068114; Sat, 10 Feb 2024 15:51:08 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCU4rfk+26klrsWpzhO0rtSX88PTmmTRwQgnnwezWXQ1kVKVHZL4WhA9+WoWu8qabtVcLE7eaa9eti/qXsWKJV300T6z8WTYnEB4CQH0ic2kl/DbndJ5RAuLDn+3QhlQx6Vix2J6LMWqRljM7ZHI3vLvQzi+bzKg6MwwP4Lc9ANt2t13jEUkwq2doCRCM0NdBckpeK2MC7sc7S9lgRFdY0a2pyxBWVSE0YOr3KJzaFNj8kWeWRNPAElz3q/FaQAYVbOmwN/PmnUExx56gLMaySxBD8pduS61FWQ4oSZimX6hnlNSEn9e9L73RxyHTOM8b1mQ8ZWgy1AcGlJxYJql8PrL2eqEdepClkTRblys83EW4zKmDFL6YiCzrFQdPwMKpuwOuqhl6cvwEGhSN9Lna1P1PGUURvne/pFzCGNTsyKKAnXMyHUVppdJedMChac5jbMepkc2lggiRs1oaxBLpMJEdMg4UqatV9vM4xMJuzo3O/rtVeWaqu5QINhBq0HDUlfVKN2mq8OFFxCD78J717o/8EzhsHZGJTvsdZEQzgPlg1OfWZGwnbNLw9msgz4YpU5GhtDQGi2TLM+pv2rVBjZ8/zBtgHsyxDaSDF5c70AvxKjXIw== Received: from ukaszb-l.roam.corp.google.com (alfa56.extreme-net.one.pl. [213.77.89.56]) by smtp.gmail.com with ESMTPSA id o27-20020a056512051b00b0051179ae1846sm365561lfb.280.2024.02.10.15.51.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Feb 2024 15:51:07 -0800 (PST) From: =?utf-8?q?=C5=81ukasz_Bartosik?= To: Jason Baron , Jim Cromie , Greg Kroah-Hartman , Andrew Morton , Kees Cook , Douglas Anderson Cc: Guenter Roeck , Yaniv Tzoreff , Benson Leung , Steven Rostedt , Vincent Whitchurch , Pekka Paalanen , Sean Paul , Daniel Vetter , Simon Ser , John Ogness , Petr Mladek , Sergey Senozhatsky , linux-kernel@vger.kernel.org, upstream@semihalf.com Subject: [PATCH v4 23/39] dyndbg: display the bad flag-val in parse-flags err msg Date: Sun, 11 Feb 2024 00:49:53 +0100 Message-ID: <20240210235009.2405808-24-ukaszb@chromium.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240210235009.2405808-1-ukaszb@chromium.org> References: <20240210235009.2405808-1-ukaszb@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790558867465667510 X-GMAIL-MSGID: 1790558867465667510 From: Jim Cromie If ddebug_parse_flags() rejects user input, identify that input value in the error message. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 4954d3e5be5b..089765afc972 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -973,7 +973,7 @@ static int ddebug_exec_query(char *query_string, const char *modname) /* check flags 1st (last arg) so query is pairs of spec,val */ if (ddebug_parse_flags(words[nwords-1], &modifiers)) { - pr_err("flags parse failed\n"); + pr_err("flags parse failed on word-%d: %s\n", nwords-1, words[nwords-1]); goto err; }