[v1] mtd: rawnand: meson: fix scrambling mode value in command macro

Message ID 20240210214551.441610-1-avkrasnov@salutedevices.com
State New
Headers
Series [v1] mtd: rawnand: meson: fix scrambling mode value in command macro |

Commit Message

Arseniy Krasnov Feb. 10, 2024, 9:45 p.m. UTC
  Scrambling mode is enabled by value (1 << 19). NFC_CMD_SCRAMBLER_ENABLE
is already (1 << 19), so there is no need to shift it again in CMDRWGEN
macro.

Signed-off-by: Arseniy Krasnov <avkrasnov@salutedevices.com>
Cc: <Stable@vger.kernel.org>
Fixes: 8fae856c5350 ("mtd: rawnand: meson: add support for Amlogic NAND flash controller")
---
 drivers/mtd/nand/raw/meson_nand.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Miquel Raynal Feb. 26, 2024, 10:45 a.m. UTC | #1
On Sat, 2024-02-10 at 21:45:51 UTC, Arseniy Krasnov wrote:
> Scrambling mode is enabled by value (1 << 19). NFC_CMD_SCRAMBLER_ENABLE
> is already (1 << 19), so there is no need to shift it again in CMDRWGEN
> macro.
> 
> Signed-off-by: Arseniy Krasnov <avkrasnov@salutedevices.com>
> Cc: <Stable@vger.kernel.org>
> Fixes: 8fae856c5350 ("mtd: rawnand: meson: add support for Amlogic NAND flash controller")

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel
  

Patch

diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
index cdb58aca59c0..2a96a87cf79c 100644
--- a/drivers/mtd/nand/raw/meson_nand.c
+++ b/drivers/mtd/nand/raw/meson_nand.c
@@ -63,7 +63,7 @@ 
 #define CMDRWGEN(cmd_dir, ran, bch, short_mode, page_size, pages)	\
 	(								\
 		(cmd_dir)			|			\
-		((ran) << 19)			|			\
+		(ran)				|			\
 		((bch) << 14)			|			\
 		((short_mode) << 13)		|			\
 		(((page_size) & 0x7f) << 6)	|			\