From patchwork Sat Feb 10 16:40:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 199275 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:50ea:b0:106:860b:bbdd with SMTP id r10csp1554962dyd; Sat, 10 Feb 2024 08:42:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IEFR7KrRr5/2UcTqCdVQptu4w85V2hg3sowANq7FuUQ9D6EL6gdASd4IRi3ySwsUt6+c3bC X-Received: by 2002:a17:903:24c:b0:1da:1559:cdc6 with SMTP id j12-20020a170903024c00b001da1559cdc6mr2674576plh.44.1707583365021; Sat, 10 Feb 2024 08:42:45 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707583365; cv=pass; d=google.com; s=arc-20160816; b=QpijdXaF376GFEsCDpSEReEkaYEc67xchz+a52JSZWUOq4IbzdO+tJcnC5G2kfwxZV HvutW2/6HJ4AxoWzsUwcId7ZIKzzJSL+Sr5af+OXyjqij7SKVA2D3n++PzyrngD8ro8X 08zkPUFkNQpnZhoidXLsfGX2799nBB67KC+Zfk5mBNYPdVTGzYI0g5Ry4WMvwtTkEv8S Ja5HgprtuDd/E/xFvVYZMd9Ms1vEBrAp5kVBImfIa9ZuIOrqSvQi7OcZUdzm3YTMwugp /XbNpgOfdHBgwIt0C+1r4xKiEyKHx7MIM5c8WKqPH7pEbYqYxK86/S4lCiWYS9DpzVTb d80g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=VP0QH7fID5VJz0qTjB5dfkpcbtptVyKbn0KyIphmKmM=; fh=bpCME6XVkO9G8vTZ1cxKR8e64WpWSQS+CKP08CDEMAg=; b=uvjJM7GVIr2Sm+5sufC4NbuMgwspOU/eHxH6ttQ0ZW5OoKvxY4Q/7zF8vHRIkiKWOG 1IfrhrIbq+zTOKRjjnbVC62849Pz7eOxZAc+pk8VCSnDcA92V2+Z5hTsOmr5f4t1EOIl WAzwhxWRc30bMUQAsssGOw/ulb+0ACq6xCbstHNOhfxry5nFsqlfp1EnKPu4CqrODeee PFaiCmMGqsZJLO1D95JxfoxYnRE2PhrGtr0DF5e3DVSNWDeiS14Hpr9C6sm23Hy2oj9U McrAXZMYcfZEa7u/VdQQQMOj0BFZxpwHuTss84CyGYarksLSa59OHJiLFAYy4rY+CocI vuAg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=pengutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-60468-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-60468-ouuuleilei=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=2; AJvYcCVsWRJSMKGe7ZEVcM9k8d3Mr9Y7Cf7flQ73WegrKTZ4/qHmS+8qJfLpJfm+p0B43raKoougo1fJ7jqr+lvulxa7crXMLg== Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id g1-20020a170902c38100b001d7204a84ddsi3505927plg.499.2024.02.10.08.42.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Feb 2024 08:42:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-60468-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=pengutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-60468-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-60468-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 216A5286027 for ; Sat, 10 Feb 2024 16:41:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A4D385D46A; Sat, 10 Feb 2024 16:40:54 +0000 (UTC) Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91B525C8E8 for ; Sat, 10 Feb 2024 16:40:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707583253; cv=none; b=g/ZuRdVzAcOtc3N8eBGQCJhzI4VL5MFKbkmn/cWysUxen+Mt24KYQIlDpE4iSrC2ST45EGeFClhhtnawGR9MJr1CbkdmaIusjiNgynkUz9hrx3SilE+MU4xNAyrpjDVb0YieLsgzIjh0o9JSpXM+NJRYhiimi/VAdot5vYwW+9A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707583253; c=relaxed/simple; bh=10BznG4/Q7I4p/NCADVIk4BSO8uNoZg982rmmdanDP0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=BG28HT9/CD+lIEj0RIbMEJxczytkGdSl02IflvoGRZ1X8NwsgJZigkhRu6mDn5BKIATLU1vLeruGFL5CYg/5wpIxCLRkVYvCZYb/fEtPdzN5whk9l54jD1LCYMsSrzoHyaA88fuc2HgBZI4rUfuOIi5mn1iR41brEreljbVE6+c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rYqOs-0001IB-Pk; Sat, 10 Feb 2024 17:40:22 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rYqOr-005i4D-24; Sat, 10 Feb 2024 17:40:21 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rYqOq-002ERK-39; Sat, 10 Feb 2024 17:40:20 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Mark Brown Cc: kernel@pengutronix.de, Rob Herring , H Hartley Sweeten , Jonathan Cameron , Stephen Warren , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] spi: ppc4xx: Drop write-only variable Date: Sat, 10 Feb 2024 17:40:08 +0100 Message-ID: <20240210164006.208149-8-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240210164006.208149-5-u.kleine-koenig@pengutronix.de> References: <20240210164006.208149-5-u.kleine-koenig@pengutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1352; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=10BznG4/Q7I4p/NCADVIk4BSO8uNoZg982rmmdanDP0=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlx6bqu4OIok6KAOl5u5CmjU5gQ1LXdKCj/lzYj wmW21P1rXyJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZcem6gAKCRCPgPtYfRL+ TiX/B/0cEuFK96ul4c/xZ283WZaBg1+kQ8qA0NWUk4lAxw8d7kjNPCAPuFc2sjFLD9zCleMGM/n /hhyCohFXxk4PAXOjzGKr+6x1odZwO3MbpAOrbFeKgx8F/WrVqyYiNMOwvtSmdkpZm96prEfnKi fhymfBMG1uicbzKhb6HVDfopsENqmDPsyotwUZoAulJAc9KyrQUGL/eYyxzWymRSC+pqhnZvzU0 b1eP0z8Kj+yw6t2kY5Tp5HkNnN0iOpKD0Xf1usiJyWnzr6Qw0meRbf82NNoxrOXm7hc0aj9VGI6 qVJ72xnijJQTyl8c5n0MJcUDDla22i2eXV3LjVcdoQApBZ9L X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790530934299759256 X-GMAIL-MSGID: 1790530934299759256 Since commit 24778be20f87 ("spi: convert drivers to use bits_per_word_mask") the bits_per_word variable is only written to. The check that was there before isn't needed any more as the spi core ensures that only 8 bit transfers are used, so the variable can go away together with all assignments to it. Fixes: 24778be20f87 ("spi: convert drivers to use bits_per_word_mask") Signed-off-by: Uwe Kleine-König --- drivers/spi/spi-ppc4xx.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/spi/spi-ppc4xx.c b/drivers/spi/spi-ppc4xx.c index 2d5536efa9f8..942c3117ab3a 100644 --- a/drivers/spi/spi-ppc4xx.c +++ b/drivers/spi/spi-ppc4xx.c @@ -168,10 +168,8 @@ static int spi_ppc4xx_setupxfer(struct spi_device *spi, struct spi_transfer *t) int scr; u8 cdm = 0; u32 speed; - u8 bits_per_word; /* Start with the generic configuration for this device. */ - bits_per_word = spi->bits_per_word; speed = spi->max_speed_hz; /* @@ -179,9 +177,6 @@ static int spi_ppc4xx_setupxfer(struct spi_device *spi, struct spi_transfer *t) * the transfer to overwrite the generic configuration with zeros. */ if (t) { - if (t->bits_per_word) - bits_per_word = t->bits_per_word; - if (t->speed_hz) speed = min(t->speed_hz, spi->max_speed_hz); }