From patchwork Sat Feb 10 11:39:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: alexs@kernel.org X-Patchwork-Id: 199247 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:50ea:b0:106:860b:bbdd with SMTP id r10csp1419469dyd; Sat, 10 Feb 2024 03:36:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IFUUjALCu//P18qYm58BhT374IjPzWVZAHeK5nvf8FiMN2yW6cXJZWWCDpsn6U7h21DaGrR X-Received: by 2002:a17:902:d4c7:b0:1da:1fe7:cacf with SMTP id o7-20020a170902d4c700b001da1fe7cacfmr1487968plg.25.1707565014839; Sat, 10 Feb 2024 03:36:54 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707565014; cv=pass; d=google.com; s=arc-20160816; b=V59edxv65RxKDrVNT3rTHVKfyaJ4Q5/zRpFLqGfAIJ94r7mZV7f3wNwvfx6GPJ97XF Zh3tXKGnOIjuMlGEJR7gI/1F0FzPdlBHgHguQP5e1ADU03ecUd6iQljHAnerNfVCtNDv b9HE2sEzPljsuc74AwbdAmdh7E15CzFoyM00/1BBEKA35X4RdiDoM4vUeR5GlAmWjE+7 yD14IbKgKANP1AAAxFgMiUpoHBnulZNKDizATOFtCpUWaK12mLe+rIXi6VKQXQbYcY0n LjwaJpbI4ie6S2KoaYC7wTLCIotDKwxj+zt8LxExZlnTCymRguOW0iu5Iim8sjXrlbvU 2Fwg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=2zXrBne7L3hc/8fZipQuiagtiGBJgCDJh+CpJH/d15s=; fh=U32FKqTQNnryy9py00ad1EyMsaAmWRdamDYapiKWa8Q=; b=HhS2Fnwz/JIRZ9YCAcKAso6X1r9MZ37bijz6Kh467LUTihnjmJAr2XE7tLXfvTVz4O LmWKM/tDoMZqmuBbwzrGnoBfWuQP7I9LVGUeIHEOHMGYHPooxUAOf5LSUJQt+TzDzMfq bzN8wIYD+NfLljf9efmUOjCN5PWiD0sCK4TdUqXAl25Z90vj/eIGRykMBnue45JXrDee 1X6Uq+Juqotxh5DCf8M/GMMcjIkcKc7wjJz4tZBTyKYUaxSSpejmttT6MojXymMaL3lF y458NmAYANRxGT4F2COyk3d18QwPj8Mxep83zbz2By805VRsznKcmeO0RCT6shZ7ok4v ldrA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ox5pYG88; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-60379-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-60379-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCWSbCPNJU4mBrMok7m+IKypeHUfQBZk9+k/+giwWBaEGZzCrBvP30L4QhtvYlTBrPIz6NIPMNNMe0d5bp/8rIAo1CCqCA== Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id e5-20020a17090301c500b001d78f9081a9si3345602plh.313.2024.02.10.03.36.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Feb 2024 03:36:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-60379-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ox5pYG88; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-60379-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-60379-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id AA1A5B23420 for ; Sat, 10 Feb 2024 11:36:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 013413D577; Sat, 10 Feb 2024 11:36:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ox5pYG88" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FFC33D55A for ; Sat, 10 Feb 2024 11:36:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707564986; cv=none; b=eKtS/Lclhm/odPbZgpgM9CY9M3T4dSshpm029E9pLOFOMz8VjihzipiaSgQGAD3d6V/kdO4YKjhoFW6hQz0fx6wuu9+R4kYJDqmFbNL+jFWbDK3SRBFgApWL7wgJtgsrLqA9gAttvhS/a/GWPNqWGnDAjJjubUflL7D/4P0LmHY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707564986; c=relaxed/simple; bh=GN38axMpDXwM+LiQWv9rCHV4je3GH/IUMqqcPRYdILM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tbvyYeIytnmikZLRFMQutzW/D1N2haLc/bfAYs/f8p2dJ4h81MwgF+OwTNyFm53hytUVpCTrQrCM1rtH6rP3JjiwBv3ifkLNxLoM4rtXCS/eCvNO6ynoy/unmU3a/dQvL8XQnyEKeDm/U/+S8dTF1Nn8Ld7VF8ZsEUrDMb3CHU8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Ox5pYG88; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 00256C43390; Sat, 10 Feb 2024 11:36:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707564985; bh=GN38axMpDXwM+LiQWv9rCHV4je3GH/IUMqqcPRYdILM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ox5pYG88JOmXeQa3kRbicKLfW7BrjOnejepA6G+79dw76I8L4Zb9sPD1+wnHMYSgV le+MqIeltleerizblAE4U/xg/PtbQ9wKTzCrpfaBtBV7gvBlbB4nnGMG5pOsJbhfUC R0njwsf+sv4BhUCJXGSMCwvgjcLRyiuBoU1TKrbTrtRpJqaBoQI0n9z+D9nqkH3o2N mBnkpu4xB0WwOkTNl7GqySpAgao/asJeUH2visJksyhpzHdgeN/sx/Sb0D+yhsDavW o8wnX6SkAhmn+PX6GKYL+eRt6smqAn2OKm1va9lOx63m2m83gfdW/KkcSjYds+JDJM GDqEePBQ4EKZQ== From: alexs@kernel.org To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , linux-kernel@vger.kernel.org (open list:SCHEDULER), Ricardo Neri Cc: Alex Shi Subject: [PATCH v5 2/5] sched/fair: Remove unused parameters Date: Sat, 10 Feb 2024 19:39:20 +0800 Message-ID: <20240210113924.1130448-2-alexs@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240210113924.1130448-1-alexs@kernel.org> References: <20240210113924.1130448-1-alexs@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790511692873565231 X-GMAIL-MSGID: 1790511692873565231 From: Alex Shi The argument sds is not used in function sched_asym(). Remove it. Fixes: c9ca07886aaa ("sched/fair: Do not even the number of busy CPUs via asym_packing") Signed-off-by: Alex Shi Cc: Valentin Schneider Cc: Vincent Guittot Cc: Juri Lelli Cc: Peter Zijlstra Cc: Ingo Molnar Reviewed-by: Ricardo Neri Reviewed-by: Valentin Schneider Reviewed-by: Vincent Guittot --- kernel/sched/fair.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 533547e3c90a..607dc310b355 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -9749,7 +9749,6 @@ static bool sched_use_asym_prio(struct sched_domain *sd, int cpu) /** * sched_asym - Check if the destination CPU can do asym_packing load balance * @env: The load balancing environment - * @sds: Load-balancing data with statistics of the local group * @sgs: Load-balancing statistics of the candidate busiest group * @group: The candidate busiest group * @@ -9768,8 +9767,7 @@ static bool sched_use_asym_prio(struct sched_domain *sd, int cpu) * otherwise. */ static inline bool -sched_asym(struct lb_env *env, struct sd_lb_stats *sds, struct sg_lb_stats *sgs, - struct sched_group *group) +sched_asym(struct lb_env *env, struct sg_lb_stats *sgs, struct sched_group *group) { /* Ensure that the whole local core is idle, if applicable. */ if (!sched_use_asym_prio(env->sd, env->dst_cpu)) @@ -9940,7 +9938,7 @@ static inline void update_sg_lb_stats(struct lb_env *env, /* Check if dst CPU is idle and preferred to this group */ if (!local_group && env->sd->flags & SD_ASYM_PACKING && env->idle != CPU_NOT_IDLE && sgs->sum_h_nr_running && - sched_asym(env, sds, sgs, group)) { + sched_asym(env, sgs, group)) { sgs->group_asym_packing = 1; }