From patchwork Sat Feb 10 11:39:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: alexs@kernel.org X-Patchwork-Id: 199246 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:50ea:b0:106:860b:bbdd with SMTP id r10csp1419362dyd; Sat, 10 Feb 2024 03:36:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IGGF+xFZXPPJJzIoZuAr+AiZp/NUQS292XGEZeWPPcdJxMAHtk4wTqZH96BMn2k26lpugtc X-Received: by 2002:a17:906:28cf:b0:a3c:1d36:62c9 with SMTP id p15-20020a17090628cf00b00a3c1d3662c9mr1234407ejd.73.1707564998560; Sat, 10 Feb 2024 03:36:38 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707564998; cv=pass; d=google.com; s=arc-20160816; b=eGsNuuDaQfCxxo57lBZOeM53dKmAER7bg1kt5/k3g6Mubm2p9zDi6YXMiksUcf+ZEd +loNBJSf4Ve6v188BxGULluUNJA0eYPeVvVcUbuA8Xr+uzP4IrY5g49ChaBZAIeoelBS I44PpB2mlZQKN/ppv9v4Ib9QI4itoUiANqWcBSkdI9/AlOKhz1u4KMkGq+0Cp1X3tZ6q oIDtbVdmgwOuLUQy/SWEdeU8V2o+J3THPr4R4T1rwcMDTO42g9l1St+r7lneTew1dNSC AQAGyBHtLYJYzaPbz+YcXYHAGvtfPxevXtl+PkgKhV/b8AOVSiDY8uWutWAY1RVW3Ey3 5wpw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=KG+DWqhiwRrnGrZXzj1dt+rgsxkalfsLYkjdeJZKuZ8=; fh=qi1ASFWNcUTwFoJj8tfhZWd0PinvUrG6KvhabGl2yv8=; b=EGa8QSwRL9Oegr0DbFUlRVVjfELKDTs5RJzRNwgQa9y7ZS6h7OyE3WdzmGTLOa+kEl sYaM0adV60+sNH/zoXyHOakE+HnytcFidWSXoOGOJtRW7BIe1utWWGLHJWya6jcRSdll TQwqe1BkzV+N/xwqHVt/9+pSmSg9pNBpcOQxN6y8qUi/HiTaCrvvWhUYFaCg1JBAdYSR NDknzvTt5SLCysdnArULJzrlxHYzYU6t4JagiHJxyydlxbQorKFebbBGKbKNuaauXhsQ XiJsuHKWw5lovQbr7fzsYRICSovcDzBB6KaN2kldszCplTEhLyio7SyvlGXiolrMvrQO bDwg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=eLaly24H; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-60378-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-60378-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCUF55odh/3owQn4JTCzsxVCbwOP8SC1CMgjRe+GY44yaz9Eqqf0ry3GMp/UIs9CJbm6eS5OMaOSH094mI53FOUlCNPX3w== Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id v9-20020a170906338900b00a381b930bdcsi1855931eja.846.2024.02.10.03.36.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Feb 2024 03:36:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-60378-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=eLaly24H; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-60378-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-60378-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 30E9B1F22DFC for ; Sat, 10 Feb 2024 11:36:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 700163D54E; Sat, 10 Feb 2024 11:36:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eLaly24H" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF7543AC01 for ; Sat, 10 Feb 2024 11:36:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707564982; cv=none; b=NO4HmhsB8Yajiu74n+TGDjD25v3eqeoCQbILyJjD8Y/UQA4Xtg8Fh1NV8hhYBL7D7pUe09fVqrHhZeeYihZj8vETJ0AxfMj6KiY9ZNHAs53JpqHUl6Z3KypYwnkZhlAXM9KtEvBNPnPGgDeBvK1fhf5k3L6Wp9mzAqyitpERzBA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707564982; c=relaxed/simple; bh=mofvx/4Gu5lY6rezEW+q6OTCAd/T7sEH3BGxSJ30Meg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=aG9q3HvZxpDMf6GAwi7aw3Ntf5HZtzxyplIcALYFfBsD0dMXMZ89Em7hSJsdQK7J7j5APwNe+a5KYcTaTE/eiNqIP/gnsX1RuGsDEkedQf+awtjiC1zkFE0UQg5hVpCWrVdghnGONJzEH9qjBjc59wkgYY9BFuiuijvxjiknYU8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eLaly24H; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 641BDC433C7; Sat, 10 Feb 2024 11:36:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707564982; bh=mofvx/4Gu5lY6rezEW+q6OTCAd/T7sEH3BGxSJ30Meg=; h=From:To:Cc:Subject:Date:From; b=eLaly24HIsgzoTZ/SX6JRFlF4EusLbDp9ivgIHzCcbK8b02h03T/I7yvYhGw+UZg9 vjM3VGwFKd/yGWA9vBmdDdaH7lFBWHrBRicIi4DgZoPuGtvTRhJOFmhVS9LRfJcTNI KWqmn0844+4aenw8yz3xh3Ir0/57DQLURgX4CfE9Bdc+06jKcnJL2QVujb2WfuRV9N l5QByd3tMoFnOcYwOQgtwhWOtffyxg/IMKFdunAo1GbrADy2rqdlBkQxncAlt2rvpT nm9ZHBTjROq9sFO0NudnSJkOUZQ1jnrIxRgfNeXe5MsrY7kyMUy4L8tjaVoLBHq5xO lq5DHK65LxNXQ== From: alexs@kernel.org To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , linux-kernel@vger.kernel.org (open list:SCHEDULER) Cc: Alex Shi , Ricardo Neri Subject: [PATCH v5 1/5] sched/topology: Remove duplicate descriptions from TOPOLOGY_SD_FLAGS Date: Sat, 10 Feb 2024 19:39:19 +0800 Message-ID: <20240210113924.1130448-1-alexs@kernel.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790511675828965157 X-GMAIL-MSGID: 1790511675828965157 From: Alex Shi These flags are already documented in include/linux/sched/sd_flags.h. Also, add missing SD_CLUSTER and keep the comment on SD_ASYM_PACKING as it is a special case. Suggested-by: Ricardo Neri Signed-off-by: Alex Shi Cc: Valentin Schneider Cc: Vincent Guittot Cc: Juri Lelli Cc: Peter Zijlstra Cc: Ingo Molnar Reviewed-by: Ricardo Neri Reviewed-by: Valentin Schneider Reviewed-by: Vincent Guittot --- kernel/sched/topology.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index 10d1391e7416..0b33f7b05d21 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -1551,11 +1551,12 @@ static struct cpumask ***sched_domains_numa_masks; * * These flags are purely descriptive of the topology and do not prescribe * behaviour. Behaviour is artificial and mapped in the below sd_init() - * function: + * function. For details, see include/linux/sched/sd_flags.h. * - * SD_SHARE_CPUCAPACITY - describes SMT topologies - * SD_SHARE_PKG_RESOURCES - describes shared caches - * SD_NUMA - describes NUMA topologies + * SD_SHARE_CPUCAPACITY + * SD_SHARE_PKG_RESOURCES + * SD_CLUSTER + * SD_NUMA * * Odd one out, which beside describing the topology has a quirk also * prescribes the desired behaviour that goes along with it: