From patchwork Fri Feb 9 10:09:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Karthik Sundaravel X-Patchwork-Id: 198802 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:50ea:b0:106:860b:bbdd with SMTP id r10csp747012dyd; Fri, 9 Feb 2024 02:10:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IFhl/cJUnTfqSy36cGWpauW3n3qwxaAWNXpfSfBIBMLmsa+1/6cfau71SQxUcRZOB7m9MuT X-Received: by 2002:a05:6a20:c91c:b0:19e:99ce:28cf with SMTP id gx28-20020a056a20c91c00b0019e99ce28cfmr1259072pzb.42.1707473400780; Fri, 09 Feb 2024 02:10:00 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707473400; cv=pass; d=google.com; s=arc-20160816; b=nQay5tdQn+CUmswsOvDzSc3xgm61hnaEnKebLe6lppsI+FwYTlMg8geopLGSBMdRKU GqPB7hIwJ9yfz5rIIuH+5TAZNud8+7m9+QndsFnafIrf0fRZ62iTMkvQVB8J9hEBcL7P nE5InKV3alxKc7ubpCjP/k+LVpgeTSe/ehL9kzkjg4KZ5+ppYuPP9zevNmuUzAHQCOvW mLjBhr/YT0OvLvF2gblJxLUHrIJuomCe8dnWVYKShY7IN3LuC0d9uFDbbheO937vpiSb Zo5T4K2e6qTPb31m8cz2zQjZbkg8qb4bpzCYMaMquwg4yElt2FRnj2Mj3nW93m2s6ZyS K3Ug== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=3/PA/qAm80LBIpCSUidwpWKHTU/hcwXN20sP5Blmh3g=; fh=3XOi22Aapaf7XGl0PmqWnbZyYcpWfiiWzhe1NAJZEoI=; b=QTA6p3YHH+NBVxSBh/BpYgmCYvYTd2b1fkqBDWVy88YwQa4R0zFXdoVQ+x32JCvLvr wZa1hwn//2mCFF/+yTB/H9fKiuSrA9OwsgzCEtMCw5jE8Tu9NpnwzJIeoKIX+sQrSgTS Lh+dBGdNbGWpetPG6aR6/D/LO6cw1fY067vHqenjLtgvrUWiU8QxShCfHHNkesFN3dum wQDc8cB+i6eQMdQYEoSgo1cz8M1a1RxcduuzFJpa/J6jv6pxuw7Xz0VYJiTwWedNzJE2 mFkvBaAm6Q4qNlJQA5i7jvrzv4qNC0ekgCkM+H2yiGSdswRi0AlNb8qt29U4YSZXlXEG 23vA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CkoDxMF3; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-59192-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-59192-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com X-Forwarded-Encrypted: i=2; AJvYcCWhmA9v6G6wzdidNc3s7fOFwUuIg2TbcIAK1kozvGDFOkALfHW1+VZjHXWcN0vbs0rbFHzqZY7j4Z9JnkQaHqPZtt+C7A== Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id nl17-20020a17090b385100b002970a5ccbedsi890490pjb.10.2024.02.09.02.10.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Feb 2024 02:10:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-59192-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CkoDxMF3; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-59192-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-59192-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 168172877EC for ; Fri, 9 Feb 2024 10:09:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E4E7C6994D; Fri, 9 Feb 2024 10:09:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CkoDxMF3" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05D6467C4D for ; Fri, 9 Feb 2024 10:09:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707473379; cv=none; b=gXCtKRjlAATzRZf3VlnZpVf7mARXqLOI85i/HykiFXfQBv5MriEWF7BWO7qaI7hDi1yqEM3nK1fWF/NFVF90hRupkxTdkuyCs9ThJVHVaVkjXS5buFzrTmVucRRWGgY3068JLasuE/ztTe48yU0e2MhTjaYCncNfGur6kWJXM14= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707473379; c=relaxed/simple; bh=uEq14SmNfh9e6AvTpkK1VirafM0cDpxRZMf85VWBefw=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=b7OZ5bor323JWiPUkf/xZse8KO3kZIzcv7ZsfW0J8G2wtawPuQfJwUlPORPn1LLvlUZvH9nfWkLrEG30ppaalI5FKFeBEn5HdT+AkjUNP6L3bV6O1+sC3cS7P/yZ+ZO3n3jrY757cE2EPNWiLHkvQlaVygtxMM+VSK8BpkHGnDM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CkoDxMF3; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707473375; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=3/PA/qAm80LBIpCSUidwpWKHTU/hcwXN20sP5Blmh3g=; b=CkoDxMF3WMCkMx2KWGzmMQbpHtB1c0kDC9CEgVeOMZxdqKNL0N+LBtlA8nttx3YT7zj5mS NX8fcL8PeWZdMvjQYUrzj976knBFnfCM6DCP00VZcGSqd+AG/MPHU94ke9jvHDzy7BcwRR ORblgv+SJJo4BZ1dh+hJ50qoyb1twls= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-475-x_rBRvy0Pdm3W43COY-s4w-1; Fri, 09 Feb 2024 05:09:30 -0500 X-MC-Unique: x_rBRvy0Pdm3W43COY-s4w-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 85E00831070; Fri, 9 Feb 2024 10:09:29 +0000 (UTC) Received: from ksundara-mac.redhat.com (unknown [10.74.16.209]) by smtp.corp.redhat.com (Postfix) with ESMTP id BCD1B492BE3; Fri, 9 Feb 2024 10:09:23 +0000 (UTC) From: Karthik Sundaravel To: jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: pmenzel@molgen.mpg.de, jiri@resnulli.us, michal.swiatkowski@linux.intel.com, rjarry@redhat.com, aharivel@redhat.com, vchundur@redhat.com, ksundara@redhat.com, cfontain@redhat.com Subject: [PATCH v3] ice: Add get/set hw address for VFs using devlink commands Date: Fri, 9 Feb 2024 15:39:12 +0530 Message-Id: <20240209100912.82473-1-ksundara@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790415628694244144 X-GMAIL-MSGID: 1790415628694244144 Changing the MAC address of the VFs are not available via devlink. Add the function handlers to set and get the HW address for the VFs. Signed-off-by: Karthik Sundaravel --- drivers/net/ethernet/intel/ice/ice_devlink.c | 86 +++++++++++++++++++- 1 file changed, 85 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ice/ice_devlink.c b/drivers/net/ethernet/intel/ice/ice_devlink.c index 80dc5445b50d..7ed61b10312c 100644 --- a/drivers/net/ethernet/intel/ice/ice_devlink.c +++ b/drivers/net/ethernet/intel/ice/ice_devlink.c @@ -1576,6 +1576,89 @@ void ice_devlink_destroy_pf_port(struct ice_pf *pf) devlink_port_unregister(&pf->devlink_port); } +/** + * ice_devlink_port_get_vf_mac_address - .port_fn_hw_addr_get devlink handler + * @port: devlink port structure + * @hw_addr: MAC address of the port + * @hw_addr_len: length of MAC address + * @extack: extended netdev ack structure + * + * Callback for the devlink .port_fn_hw_addr_get operation + * Return: zero on success or an error code on failure. + */ + +static int ice_devlink_port_get_vf_mac_address(struct devlink_port *port, + u8 *hw_addr, int *hw_addr_len, + struct netlink_ext_ack *extack) +{ + struct devlink_port_attrs *attrs = &port->attrs; + struct devlink_port_pci_vf_attrs *pci_vf; + struct devlink *devlink = port->devlink; + struct ice_pf *pf; + struct ice_vf *vf; + int vf_id; + + pf = devlink_priv(devlink); + if (attrs->flavour == DEVLINK_PORT_FLAVOUR_PCI_VF) { + pci_vf = &attrs->pci_vf; + vf_id = pci_vf->vf; + } else { + NL_SET_ERR_MSG_MOD(extack, "Unable to get the vf id"); + return -EADDRNOTAVAIL; + } + vf = ice_get_vf_by_id(pf, vf_id); + if (!vf) { + NL_SET_ERR_MSG_MOD(extack, "Unable to get the vf"); + return -EINVAL; + } + ether_addr_copy(hw_addr, vf->dev_lan_addr); + *hw_addr_len = ETH_ALEN; + return 0; +} + +/** + * ice_devlink_port_set_vf_mac_address - .port_fn_hw_addr_set devlink handler + * @port: devlink port structure + * @hw_addr: MAC address of the port + * @hw_addr_len: length of MAC address + * @extack: extended netdev ack structure + * + * Callback for the devlink .port_fn_hw_addr_set operation + * Return: zero on success or an error code on failure. + */ +static int ice_devlink_port_set_vf_mac_address(struct devlink_port *port, + const u8 *hw_addr, + int hw_addr_len, + struct netlink_ext_ack *extack) +{ + struct net_device *netdev = port->type_eth.netdev; + struct devlink_port_attrs *attrs = &port->attrs; + struct devlink_port_pci_vf_attrs *pci_vf; + u8 mac[ETH_ALEN]; + int vf_id; + + if (attrs->flavour == DEVLINK_PORT_FLAVOUR_PCI_VF) { + pci_vf = &attrs->pci_vf; + vf_id = pci_vf->vf; + } else { + NL_SET_ERR_MSG_MOD(extack, "Unable to get the vf id"); + return -EADDRNOTAVAIL; + } + + if (!netdev) { + NL_SET_ERR_MSG_MOD(extack, "Unable to get the netdev"); + return -EADDRNOTAVAIL; + } + ether_addr_copy(mac, hw_addr); + + return ice_set_vf_mac(netdev, vf_id, mac); +} + +static const struct devlink_port_ops ice_devlink_vf_port_ops = { + .port_fn_hw_addr_get = ice_devlink_port_get_vf_mac_address, + .port_fn_hw_addr_set = ice_devlink_port_set_vf_mac_address, +}; + /** * ice_devlink_create_vf_port - Create a devlink port for this VF * @vf: the VF to create a port for @@ -1611,7 +1694,8 @@ int ice_devlink_create_vf_port(struct ice_vf *vf) devlink_port_attrs_set(devlink_port, &attrs); devlink = priv_to_devlink(pf); - err = devlink_port_register(devlink, devlink_port, vsi->idx); + err = devlink_port_register_with_ops(devlink, devlink_port, + vsi->idx, &ice_devlink_vf_port_ops); if (err) { dev_err(dev, "Failed to create devlink port for VF %d, error %d\n", vf->vf_id, err);