| Message ID | 20240208202742.631307-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel+bounces-58666-ouuuleilei=gmail.com@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a05:7300:50ea:b0:106:860b:bbdd with SMTP id r10csp438264dyd;
Thu, 8 Feb 2024 12:37:35 -0800 (PST)
X-Google-Smtp-Source:
AGHT+IE/XI8eN4yYG0jiJKLCHJIRjprmEu1rpU0ajmJpNWQSDkKOmxY6fHTeAAKRHinQoceLeqrs
X-Received: by 2002:aa7:c3d9:0:b0:55e:fead:d6e2 with SMTP id
l25-20020aa7c3d9000000b0055efeadd6e2mr261793edr.20.1707424655531;
Thu, 08 Feb 2024 12:37:35 -0800 (PST)
ARC-Seal: i=2; a=rsa-sha256; t=1707424655; cv=pass;
d=google.com; s=arc-20160816;
b=vYrGyIQmqEnasy/td0q7U56aV6H6/gVQTh2tBFkMPhM1CD6b6vy1K69Mj52X5o4G5b
e3MEzOsblpim3HcwQ7sfAwmh64B7gpweSjgKAIeMNzR4F6LO4rn1UGDK/EIILGmMPCHG
+OK413qJv7TAoPiFOKwW8O7Lm72NNaRfiBE/IBZ4LqPVczfMx1ypwbf7O0gCxDmy7Kd3
v9oz5p+p7aYtq7jmGuTtRATPUzNZywNnrFA+hdqIQFGwKvN2q5uVvVMEa3Cx3Co8PHm7
bSRkBJERX3dMxiAt2BsZ4GLwvEkmUlaCY6juUdGdYFY5YXZFiHbWLr2NZ2JAE2Tex840
p1gg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=content-transfer-encoding:mime-version:list-unsubscribe
:list-subscribe:list-id:precedence:message-id:date:subject:cc:to
:from:dkim-signature;
bh=NIl3nKoqWKpsBAq33qAsQr6tTJHAtXKfr8vYfHmeqPU=;
fh=bY6XZqbxp6BUI674aCqo/MBhxiC3sy0AGVu3JdJu1Aw=;
b=FvgZwHT3rk6uty5+RymxR36VZote+ux0RUWaZa7m4rBJWkAQ2U+kRYDDhWPH0xmejz
dz0Z2NiKqGqD9AQD0g5Jym4EgPv2Kyz8CAWQIpbhkQa5tBjcLSxAEwEP0cilzcJj6fu9
/gjoJAO3TlYHJjJIVtx49X8bQKqcPvzaGB3jZgBOdlNECXuRFXmrmkbqd3HLy9A97DM9
eBsho4UyBnw0wQARhkvz+CpcM4o/dQuv+h0daIYitYAV/mJaOCbcnyPixEXQjbJVkUXL
cQuShRovTIEM1ulkdYjwupN4weAMq1CVC/sYR9Joqiu3NSbIuuB1RpE1PGVUONbYaH5j
QN8w==;
dara=google.com
ARC-Authentication-Results: i=2; mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=M1LVfB1q;
arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass
dkdomain=linaro.org dmarc=pass fromdomain=linaro.org);
spf=pass (google.com: domain of
linux-kernel+bounces-58666-ouuuleilei=gmail.com@vger.kernel.org designates
2604:1380:4601:e00::3 as permitted sender)
smtp.mailfrom="linux-kernel+bounces-58666-ouuuleilei=gmail.com@vger.kernel.org";
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
X-Forwarded-Encrypted: i=2;
AJvYcCWtTjeUmU4S5/KwVyF6ZfEPFFC+SymWiHRoUEJ/ihfANYg1BXQbYls0+ESihiyycYHLP2T55hskQIOW7wr1I07XZfEMfg==
Received: from am.mirrors.kernel.org (am.mirrors.kernel.org.
[2604:1380:4601:e00::3])
by mx.google.com with ESMTPS id
co12-20020a0564020c0c00b00560bb856c52si89187edb.74.2024.02.08.12.37.35
for <ouuuleilei@gmail.com>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 08 Feb 2024 12:37:35 -0800 (PST)
Received-SPF: pass (google.com: domain of
linux-kernel+bounces-58666-ouuuleilei=gmail.com@vger.kernel.org designates
2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Authentication-Results: mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=M1LVfB1q;
arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass
dkdomain=linaro.org dmarc=pass fromdomain=linaro.org);
spf=pass (google.com: domain of
linux-kernel+bounces-58666-ouuuleilei=gmail.com@vger.kernel.org designates
2604:1380:4601:e00::3 as permitted sender)
smtp.mailfrom="linux-kernel+bounces-58666-ouuuleilei=gmail.com@vger.kernel.org";
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org
[52.25.139.140])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by am.mirrors.kernel.org (Postfix) with ESMTPS id 019881F2ED0F
for <ouuuleilei@gmail.com>; Thu, 8 Feb 2024 20:28:08 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
by smtp.subspace.kernel.org (Postfix) with ESMTP id A6FD83C099;
Thu, 8 Feb 2024 20:27:53 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org
header.b="M1LVfB1q"
Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com
[209.85.128.42])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0981937711
for <linux-kernel@vger.kernel.org>; Thu, 8 Feb 2024 20:27:48 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
arc=none smtp.client-ip=209.85.128.42
ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
t=1707424070; cv=none;
b=AtmMevTjRkHBfRpssBNedXiok58mmsE/g8xmU5R7sZFt+3op3Heg8DhCBpQRWLrmSSQN9Tkfw0PM6OM0EuJSVipY4MSOIs1sRAqpmiSM4qrJdqgoV8hGLxZQAwt3jbvIOckSYwGENhPvLYSAlJC9LUNCJUpMyEBLbhCzxUrJ2JA=
ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org;
s=arc-20240116; t=1707424070; c=relaxed/simple;
bh=gpdmiFJjJucd1Zl9QhqyKAFaEgPM4+P1pUU2iwmfaAg=;
h=From:To:Cc:Subject:Date:Message-Id:MIME-Version;
b=gP7zfY/FA2MwydcHF18VTsWQUdVP+ccTcRrndeXWU9Q7vTJbP3qSItKXwgxCGwFvAPFAuVUoBD9Vn+CKk2WTsMWlNY8OWZNaOENusrcHkZUeugu0NxcBSNXiml9VWAvf1Pdsf98yATq7YzEAVsbhjzddwo8jz6yjdWkqTMXvHnE=
ARC-Authentication-Results: i=1; smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=linaro.org;
spf=pass smtp.mailfrom=linaro.org;
dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org
header.b=M1LVfB1q; arc=none smtp.client-ip=209.85.128.42
Authentication-Results: smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=linaro.org
Authentication-Results: smtp.subspace.kernel.org;
spf=pass smtp.mailfrom=linaro.org
Received: by mail-wm1-f42.google.com with SMTP id
5b1f17b1804b1-41008ab427fso2292375e9.0
for <linux-kernel@vger.kernel.org>;
Thu, 08 Feb 2024 12:27:48 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=linaro.org; s=google; t=1707424067; x=1708028867;
darn=vger.kernel.org;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=NIl3nKoqWKpsBAq33qAsQr6tTJHAtXKfr8vYfHmeqPU=;
b=M1LVfB1qw6VDUQWfzOeWtNkxTDOBjJc5nexd8cTg4vzFlCsetjtOrdpXerWVT3oIYF
X07CWoTa/Zh4fwyRz/mFNgC7X8kuBgBCaqtFKNzTXhZWZ8eMCs5Aj4bW7EFFGHA2+O7d
TqsAsn/IIXD7gPcGkPwkpXyLFaEMzIl8KDWVyluXjqCDWABI3JxfB18RP1nJCOYDOI5G
2CtUhuMiWjCK+f9AZmiV47QaF21HZuIsyoqVo5hSV2fw7esSgirG5aDAg/WlIGjLUbfs
QxPxeCj62iiZQ9QXwjG/HcM8ChdVqvWogP2DKm6SzeBBT/JmjiW5zhO7Kw1igY3GCBcj
T7LQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1707424067; x=1708028867;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=NIl3nKoqWKpsBAq33qAsQr6tTJHAtXKfr8vYfHmeqPU=;
b=YsdJf/g3nLqLNgHO10JE7Rc0jGa21ewp8O6crFxDbGhnF95f68EGCmiRsBW3pgk8xl
fpiVjsngTDf/ECdN6vLwXR3Y1V/En8Bh/YIVSMY8ryIb94hhne6RR/giq5XUWRyrnlL1
txK8wJ7Ocz3Ey9cnzge7Mbwhyoy8ZfdoJRaF8qyitZJipmFBM+IWfweD1NF16RFZ4sCu
GgNmhnZiPWbnOL9OUH7N5Xbpf4bJZuArlod+izFnj2RSDV7Ln2gJpFuJyHVUcAnxZqSn
1ZCtZ86AZ3mdQW0hDE356RU3pxIwyfEkU1EBGLlMznfYJ7y5k2OMpgWk5LUsUNu9YZij
3LzA==
X-Gm-Message-State: AOJu0YxCqkQfkH5IqzKYz+jG4Xq+E6iZKP5vWY5dk4gDTL9nPZjygZup
AxJhuWc5MLrrRrlQpyAX8X59qy+uylGIOCsWRctrEX6i29wEzO6a9acjg0Iy2XdKEHfbFVNmq3R
Y
X-Received: by 2002:a05:600c:3595:b0:40f:df2d:870f with SMTP id
p21-20020a05600c359500b0040fdf2d870fmr299007wmq.41.1707424067333;
Thu, 08 Feb 2024 12:27:47 -0800 (PST)
X-Forwarded-Encrypted: i=1;
AJvYcCXKOn7hUxxacPQonDj1sCI1q2P7LYutfLlDrjtemlI58fVapiIBWbUo6U/jxDBTKWpqnF5Z0hXAvytErcEB/L0izRsYp7DjWKZtHWvMQRN/9tJrr24vx5ngkgreIs01drwRCsdzxNXv
Received: from krzk-bin.. ([178.197.222.62])
by smtp.gmail.com with ESMTPSA id
a18-20020a05600c349200b0040fa661ee82sm368027wmq.44.2024.02.08.12.27.46
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 08 Feb 2024 12:27:46 -0800 (PST)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Vinod Koul <vkoul@kernel.org>,
dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH 1/2] dmaengine: pl08x: constify pointer to char in filter
function
Date: Thu, 8 Feb 2024 21:27:41 +0100
Message-Id: <20240208202742.631307-1-krzysztof.kozlowski@linaro.org>
X-Mailer: git-send-email 2.34.1
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1790364515703940375
X-GMAIL-MSGID: 1790364515703940375
|
| Series |
[1/2] dmaengine: pl08x: constify pointer to char in filter function
|
|
Commit Message
Krzysztof Kozlowski
Feb. 8, 2024, 8:27 p.m. UTC
The opaque argument chan_id passed to filter function is actually
pointer to const memory, so make that obvious in the filter for code
readability and safety.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/dma/amba-pl08x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Thu, 08 Feb 2024 21:27:41 +0100, Krzysztof Kozlowski wrote: > The opaque argument chan_id passed to filter function is actually > pointer to const memory, so make that obvious in the filter for code > readability and safety. > > Applied, thanks! [1/2] dmaengine: pl08x: constify pointer to char in filter function commit: 16374aba824971d73916f005e79207370c9c31dd [2/2] dmaengine: of: constify of_phandle_args in of_dma_find_controller() commit: 716141d366f45d62ffe4dd53a045867b26e29d19 Best regards,
diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c index eea8bd33b4b7..fbf048f432bf 100644 --- a/drivers/dma/amba-pl08x.c +++ b/drivers/dma/amba-pl08x.c @@ -2239,7 +2239,7 @@ static int pl08x_resume(struct dma_chan *chan) bool pl08x_filter_id(struct dma_chan *chan, void *chan_id) { struct pl08x_dma_chan *plchan; - char *name = chan_id; + const char *name = chan_id; /* Reject channels for devices not bound to this driver */ if (chan->device->dev->driver != &pl08x_amba_driver.drv)