From patchwork Thu Feb 8 18:48:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 198560 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:50ea:b0:106:860b:bbdd with SMTP id r10csp437408dyd; Thu, 8 Feb 2024 12:35:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IFHf7M8vZGcEsUYzSd2z82POk49bcNswih2MMx4vhmdUw32MIJZ7QdTm/pR3ajdrlMXHQOk X-Received: by 2002:a05:620a:c16:b0:785:a7fe:c14f with SMTP id l22-20020a05620a0c1600b00785a7fec14fmr685095qki.21.1707424547189; Thu, 08 Feb 2024 12:35:47 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707424547; cv=pass; d=google.com; s=arc-20160816; b=hYvlHIwShcAP/E2pzWW+TKdxKX3w/W4td8D0gcIG9NXh6bVMY7yBo0EkKkrwQBr3pf P4m64E2xbrc3CBjBEqUFv2eSCPDd7dtqHrHFHtrJIo/DNyDWWJTjKFucf494i5gJWamt QYsEfkDsuiuVzKgjZkP3RaDbY6mRmTtg9eB2Vri0Ub5+4SR0Acgg7M10nUXKmM77ni7m Tc8Ih4gQcLG4cwL35ficX5a0UqcYP/tQwwdg24JeA/7LT+adlOKIhZtHNFvJk6EZj8iO BN9oG2tGx1PdKQSoHp07c+IuPEP8GYSSqnW47Y3epy9JgCBKJ9O5PUxbfN13EsCouqAl IRLA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=AOqpC7l/E/vfwk/M1hwkJOZablnU70sx8ddiG/mlhW8=; fh=T9Yuu3M6DBhS8mil8Z/yr+vGmz5MX00Ou49laCPBPxw=; b=rZl31bzmV3PP5AUPvtEb8RrkFmukeG2Lm5PFFrpsSSavI7qufJltHkX9VJzI7jg07a qaWwaFg8sCdh0HZUV9b9nhFHV4tn0R9x6qaaCOV369PyRVM1sVkckWViZ9uR+Sbgvb0V O56aAHXYiGXr02UI1C6b7OEmKQVz/du7CtygBXl++OEaFGMHgcLFiIRkxyGQF1PmlFk6 807USSHznNwiDVZx4TxP4LpFaGnRDInbhVCyyxC66SLWFfvl0//lxSgXY2FYuNho/GC+ GpjPG46JAyhaQ7ijJirSI9eFOOGBSEewLEiZSG/pis7YQOkPqi3JhZ2R8Y742QjE73kw wM/g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=bjm5WjVe; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-58583-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-58583-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com X-Forwarded-Encrypted: i=2; AJvYcCXivJ0MtXEE2Xmr1ZZ9dZgmogOkoco/v4pkjmkKUTcRnLebt+cEF9LZeLz+zUlo5zzIGJvYmsTELZPCL3Ae4YTkLRdQVg== Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id b10-20020a05620a088a00b0078593e7df6fsi406271qka.590.2024.02.08.12.35.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 12:35:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-58583-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=bjm5WjVe; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-58583-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-58583-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id DA6801C2A3F3 for ; Thu, 8 Feb 2024 18:57:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E7B1650256; Thu, 8 Feb 2024 18:49:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="bjm5WjVe" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC9E5381B1; Thu, 8 Feb 2024 18:49:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.19 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707418180; cv=none; b=Z9TmrAf0h0tVt41SoNiWEA+cKsi1yhZs+Jw6tZ4pnqZ/nuYiKFV9S80SkWHKTf9VmpLUS4YeqQHAr/cvBOGNUWbwE26SGeZj1RVSxfe+z76eocOdXs+fmUwvwAFDb/PbPnOvB9OHe7u5UwasB5DFXwdrqOWISdjMu0DL1mruA2U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707418180; c=relaxed/simple; bh=5fFTptxgaNSrb8/J39Uzrc6cETbfYvICnOp+m4GRuCg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=I6x0ra63uzz6g/QZPWIwmyA9JwK52BkxdNGpQM/9JW32ijPWn1oxKXTNPB0S7f/nfvsz+CDOQybjySU74N1mhxqtF3Eip2egk/2RRwsU+mDaDHuClkmA1niyqUG9xdCHD6Cit1XVUbEpVS29M57oIxcOhjpplwMgwChULPqy9eg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=bjm5WjVe; arc=none smtp.client-ip=192.198.163.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707418178; x=1738954178; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=5fFTptxgaNSrb8/J39Uzrc6cETbfYvICnOp+m4GRuCg=; b=bjm5WjVesqNwJwuCMUWtLhfJ7HWddeJ7PTrzZApt1GjCW3drJASlUYX6 3S+Yni2MQcLVpDer7WTqCdJ11B/DmeiFSwtvAXaC2W01Q+q0oKc6ZWIJm F9SCooJTKAM4RZRvOaC5eCWl4nB0eEWLCMNyxYyeeScMw/IlYFoSYDa1z +9xOARo4DQ5lI1w4kC7RwA4QHUO+IF0hBA8dCsrCA5lq9S8yTC7h52JgI PJuU1pqqkhbhV85EdbUczUVo+0J45f9e0N1JwjLmrUBClxyrFxtZISBsM gDChrU/kgU64LbH6yUXkSHdg9f0iJG9Nc3oW6TkVlDUYCfNf9lVBR2QXi g==; X-IronPort-AV: E=McAfee;i="6600,9927,10978"; a="1186157" X-IronPort-AV: E=Sophos;i="6.05,254,1701158400"; d="scan'208";a="1186157" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2024 10:49:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10978"; a="934215537" X-IronPort-AV: E=Sophos;i="6.05,254,1701158400"; d="scan'208";a="934215537" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 08 Feb 2024 10:49:26 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 9306DE1; Thu, 8 Feb 2024 20:49:21 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Miguel Ojeda , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robin van der Gracht , Paul Burton , Geert Uytterhoeven Subject: [PATCH v1 11/15] auxdisplay: ht16k33: Move ht16k33_linedisp_ops down Date: Thu, 8 Feb 2024 20:48:09 +0200 Message-ID: <20240208184919.2224986-12-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240208184919.2224986-1-andriy.shevchenko@linux.intel.com> References: <20240208184919.2224986-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790364401985724707 X-GMAIL-MSGID: 1790364401985724707 We will need the update functions to be defined before ht16k33_linedisp_ops. Move the latter down in the code. No functional change intended. Signed-off-by: Andy Shevchenko --- drivers/auxdisplay/ht16k33.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c index 0cdf3fbdf81e..75c4a8d31642 100644 --- a/drivers/auxdisplay/ht16k33.c +++ b/drivers/auxdisplay/ht16k33.c @@ -440,18 +440,6 @@ static void ht16k33_keypad_stop(struct input_dev *dev) disable_irq(keypad->client->irq); } -static void ht16k33_linedisp_update(struct linedisp *linedisp) -{ - struct ht16k33_priv *priv = container_of(linedisp, struct ht16k33_priv, - seg.linedisp); - - schedule_delayed_work(&priv->work, 0); -} - -static const struct linedisp_ops ht16k33_linedisp_ops = { - .update = ht16k33_linedisp_update, -}; - static void ht16k33_seg7_update(struct work_struct *work) { struct ht16k33_priv *priv = container_of(work, struct ht16k33_priv, @@ -489,6 +477,18 @@ static void ht16k33_seg14_update(struct work_struct *work) i2c_smbus_write_i2c_block_data(priv->client, 0, ARRAY_SIZE(buf), buf); } +static void ht16k33_linedisp_update(struct linedisp *linedisp) +{ + struct ht16k33_priv *priv = container_of(linedisp, struct ht16k33_priv, + seg.linedisp); + + schedule_delayed_work(&priv->work, 0); +} + +static const struct linedisp_ops ht16k33_linedisp_ops = { + .update = ht16k33_linedisp_update, +}; + static int ht16k33_led_probe(struct device *dev, struct led_classdev *led, unsigned int brightness) {