From patchwork Thu Feb 8 18:42:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 198628 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:50ea:b0:106:860b:bbdd with SMTP id r10csp498785dyd; Thu, 8 Feb 2024 14:50:56 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUTFePupbABgSpciE/L3mAYTVWgBxN3qxgtU42TirpQxNz+1VOBgsQ0zYwjnHn7Aj4pReewiFoQmgreLGyuvhrJSofs8g== X-Google-Smtp-Source: AGHT+IHqKvIMZSrbwzi7wmDbwPs09Wo7oMe8DTzkT/iidWD3ypHI7A9qwcHvdM6jYLEFramOYzS5 X-Received: by 2002:a05:6a20:760f:b0:199:7d51:a942 with SMTP id m15-20020a056a20760f00b001997d51a942mr876861pze.50.1707432656091; Thu, 08 Feb 2024 14:50:56 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707432656; cv=pass; d=google.com; s=arc-20160816; b=YGBG9nfO6cX8dN+QPhrYmuIYSUl+yYA2Xg+W7smHyt8EogCPQwOntu4tuQM2H9rTMF vJBLBxInDCUJ3OZaqTA4ue2rCVMP4bQrAzw3UVohzuccC3tNE0mGuOlTf9Qm23SLLA3B EBNzu0OAyiFQ/gS8qemHFy+6GVhN5C+HzVZ81GnP+vwpBjwRaoE1TgmoRz5JQW2w+ato NEqvQsgitYEkhtcH4DfRGhSkmLOCnNScUtfjNtEIHhU001YIWuLPcKoCPoe8j3lyACSy gXyKDFYsWiWRkQY51PauVuPnSsnbLzcJnBCZWrb8zEIBgFeYarlOHIURao9zVz3tDgD8 MZ6A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=OSOjzIsjnQh8q/JtF8MKjmRAAY5j5GuSqarjX0zVc5g=; fh=EMCV5hlfQaMtvwoe2RNt5ntsqSxRfWfgZIuJSiPfIIE=; b=pniJ9jaaOhL7URx5k3SedAL2hxE3Qgacu7KA7zgaT8EMMOeSEwXUmXiuLNMYUe3aeo egkNnM26oVYQLhe4xeS7ArgmR4FQFNEb5x6fy038wCKyzUP06lhZ9YLKGXAnoQ9K/FS1 rZuNocsvd512iHf9J1L82sL4eETU2fkQWwHjX9Axvz0FJapI4HILvD2vohjUvEcTUUMD OorI2VSK+EWt77Wu1/h2Bg3kNFWdxdVQNL53bTSCvd9maVuM5/8y6hBZ9ZI81H4LK0dq Mqo57awDbND9pjKiYblgRSgtNP69s0oSMctivgejjMS0zKWex6OWWDiT5xw1L6Q75Ifr Pz9Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="g/EzkqIr"; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-58547-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-58547-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com X-Forwarded-Encrypted: i=2; AJvYcCXlox7vHhhyArUM7+DYK1atnjArWivtzC0mZeUmu9/S7aI3mK1xBYSFavSe9YyZyE2qw60/RZGeZRXd84ejEh8p44qGvA== Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id mq4-20020a17090b380400b002962a155f24si519413pjb.29.2024.02.08.14.50.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 14:50:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-58547-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="g/EzkqIr"; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-58547-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-58547-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 47DA729301E for ; Thu, 8 Feb 2024 18:44:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4DAEC2555F; Thu, 8 Feb 2024 18:43:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="g/EzkqIr" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6613520332; Thu, 8 Feb 2024 18:43:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.19 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707417805; cv=none; b=g9IiI0IacAY2sL1qzEQqS9a00aGiasbvjIEg9ouMisKnIHNUEB2RcnXNUnLVW/Z6AMoQuUPMdgqLyMI8CJzO38oOoeL6pJ7GKiABJRRVpZz3ZXu9KQiXCjBA3vrciTTxQm49YcCHj6jyn0wDkX9jFc/BXgSzV5FEhPzHDOquY+I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707417805; c=relaxed/simple; bh=ksPh+SGOZxTsk3yoazHWC1sh6u7Hvs7YFo8izy4mpuk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QczULrkBKNqn15PPopK5Y2Xkc5To+ruPfxK6ogd5ZCmCg6zTY7sREapjyR59Swn82G+AQCyT81yV9KyHjeW5DaM2XqDEw8m9AjmrsQln3PsoC86x1BBEDHGNz51B4+F1yQrSjGDcOQPm9Z/hNKzEEPU4up0XsT278wPnV7PrhFw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=g/EzkqIr; arc=none smtp.client-ip=192.198.163.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707417803; x=1738953803; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ksPh+SGOZxTsk3yoazHWC1sh6u7Hvs7YFo8izy4mpuk=; b=g/EzkqIru9HiymGReqJsyHEr7xmrvtAEtjoZvQiCXOKiLBnN45+9Bosr O1W0ucfF99Uk8OSE6LjPArfsyoQX3Cjy+B/QnL0MC950Y14Mf1yFPQzt2 jJEJKHmZP0RxMAta50bZ9PkGyiFyZZbbIXQ2eepWg9StWPDZBgcnUAUMQ Pam4Dc10fHMqOB75XPt+BbUswrNgSVSTkGMBTFP2pofYBS957jfeyyG/Q AP+vGe8eb0+TQ1O1O5gp4bzgujUU/YR4lVmzgVA7LuzcIPMxUqjqouXU8 qPR/jL314EJsD7iM58/o2SOh7H3eHzfLJZ17CQ7KVnn58Rbn9ekWQPkoZ g==; X-IronPort-AV: E=McAfee;i="6600,9927,10978"; a="1184689" X-IronPort-AV: E=Sophos;i="6.05,254,1701158400"; d="scan'208";a="1184689" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2024 10:43:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10978"; a="934213722" X-IronPort-AV: E=Sophos;i="6.05,254,1701158400"; d="scan'208";a="934213722" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 08 Feb 2024 10:43:17 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 46BB213C; Thu, 8 Feb 2024 20:43:16 +0200 (EET) From: Andy Shevchenko To: Daniel Thompson , Flavio Suligoi , Andy Shevchenko , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Lee Jones , Jingoo Han , Helge Deller Subject: [PATCH v3 3/3] backlight: mp3309c: Utilise temporary variable for struct device Date: Thu, 8 Feb 2024 20:42:28 +0200 Message-ID: <20240208184313.2224579-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240208184313.2224579-1-andriy.shevchenko@linux.intel.com> References: <20240208184313.2224579-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790372904841655244 X-GMAIL-MSGID: 1790372904841655244 We have a temporary variable to keep pointer to struct device. Utilise it where it makes sense. Reviewed-by: Daniel Thompson Tested-by: Flavio Suligoi Signed-off-by: Andy Shevchenko --- drivers/video/backlight/mp3309c.c | 30 ++++++++++++------------------ 1 file changed, 12 insertions(+), 18 deletions(-) diff --git a/drivers/video/backlight/mp3309c.c b/drivers/video/backlight/mp3309c.c index 426e9f2356ad..708c053d492c 100644 --- a/drivers/video/backlight/mp3309c.c +++ b/drivers/video/backlight/mp3309c.c @@ -222,10 +222,9 @@ static int mp3309c_parse_fwnode(struct mp3309c_chip *chip, */ pdata->dimming_mode = DIMMING_ANALOG_I2C; if (device_property_present(dev, "pwms")) { - chip->pwmd = devm_pwm_get(chip->dev, NULL); + chip->pwmd = devm_pwm_get(dev, NULL); if (IS_ERR(chip->pwmd)) - return dev_err_probe(chip->dev, PTR_ERR(chip->pwmd), - "error getting pwm data\n"); + return dev_err_probe(dev, PTR_ERR(chip->pwmd), "error getting pwm data\n"); pdata->dimming_mode = DIMMING_PWM; pwm_apply_args(chip->pwmd); } @@ -243,11 +242,9 @@ static int mp3309c_parse_fwnode(struct mp3309c_chip *chip, num_levels = ANALOG_I2C_NUM_LEVELS; /* Enable GPIO used in I2C dimming mode only */ - chip->enable_gpio = devm_gpiod_get(chip->dev, "enable", - GPIOD_OUT_HIGH); + chip->enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_HIGH); if (IS_ERR(chip->enable_gpio)) - return dev_err_probe(chip->dev, - PTR_ERR(chip->enable_gpio), + return dev_err_probe(dev, PTR_ERR(chip->enable_gpio), "error getting enable gpio\n"); } else { /* @@ -265,8 +262,7 @@ static int mp3309c_parse_fwnode(struct mp3309c_chip *chip, } /* Fill brightness levels array */ - pdata->levels = devm_kcalloc(chip->dev, num_levels, - sizeof(*pdata->levels), GFP_KERNEL); + pdata->levels = devm_kcalloc(dev, num_levels, sizeof(*pdata->levels), GFP_KERNEL); if (!pdata->levels) return -ENOMEM; if (device_property_present(dev, "brightness-levels")) { @@ -336,21 +332,21 @@ static int mp3309c_probe(struct i2c_client *client) if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) return dev_err_probe(dev, -EOPNOTSUPP, "failed to check i2c functionality\n"); - chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL); + chip = devm_kzalloc(dev, sizeof(*chip), GFP_KERNEL); if (!chip) return -ENOMEM; - chip->dev = &client->dev; + chip->dev = dev; chip->regmap = devm_regmap_init_i2c(client, &mp3309c_regmap); if (IS_ERR(chip->regmap)) - return dev_err_probe(&client->dev, PTR_ERR(chip->regmap), + return dev_err_probe(dev, PTR_ERR(chip->regmap), "failed to allocate register map\n"); i2c_set_clientdata(client, chip); if (!pdata) { - pdata = devm_kzalloc(chip->dev, sizeof(*pdata), GFP_KERNEL); + pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL); if (!pdata) return -ENOMEM; @@ -367,11 +363,10 @@ static int mp3309c_probe(struct i2c_client *client) props.type = BACKLIGHT_RAW; props.power = FB_BLANK_UNBLANK; props.fb_blank = FB_BLANK_UNBLANK; - chip->bl = devm_backlight_device_register(chip->dev, "mp3309c", - chip->dev, chip, + chip->bl = devm_backlight_device_register(dev, "mp3309c", dev, chip, &mp3309c_bl_ops, &props); if (IS_ERR(chip->bl)) - return dev_err_probe(chip->dev, PTR_ERR(chip->bl), + return dev_err_probe(dev, PTR_ERR(chip->bl), "error registering backlight device\n"); /* In PWM dimming mode, enable pwm device */ @@ -383,8 +378,7 @@ static int mp3309c_probe(struct i2c_client *client) pwmstate.enabled = true; ret = pwm_apply_might_sleep(chip->pwmd, &pwmstate); if (ret) - return dev_err_probe(chip->dev, ret, - "error setting pwm device\n"); + return dev_err_probe(dev, ret, "error setting pwm device\n"); } chip->pdata->status = FIRST_POWER_ON;