From patchwork Thu Feb 8 18:24:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 198526 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:50ea:b0:106:860b:bbdd with SMTP id r10csp370406dyd; Thu, 8 Feb 2024 10:32:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IGhc6nxtGLdpZo3JkHohY90/c4R9vZ6lF4lVd3NLxbbCqBdxOH160+H92qX3s94o730opQn X-Received: by 2002:a05:620a:164e:b0:785:ac82:8bf4 with SMTP id c14-20020a05620a164e00b00785ac828bf4mr323626qko.70.1707417178082; Thu, 08 Feb 2024 10:32:58 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707417178; cv=pass; d=google.com; s=arc-20160816; b=NB1WsHP5OIJ1/EYMSFsh++pcgiTVl/vjiHzSobmGEKzZzsBSiEg0b4HndoHBdDsxl3 deD8hMz0aSmP+G5b3w2Ti9/tQjNPV5mUaI3rzfjXt21I9wTr5kLMnxCWokxFZ+4XtQwi mOevD/j8U8hRbZ0QxE6ucrTupzoBVE4zWNmNrU92p4k3MqG9xIRn7lTsu/5w5ZjDAaF2 IYyN13BvsIQxUsgtX/esamwwmzm9cOuFJRWfhWzqcUkjS8wbLLqIFYK8+MsmKeyCqaEC 70MMwNR05PyYjb7nltW+pTFsCkcuxpHx75vkSpzb+T7IooHnuvuP5uPPUxfTg5Mkki1F Hwbw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=OSOjzIsjnQh8q/JtF8MKjmRAAY5j5GuSqarjX0zVc5g=; fh=tPNXInYZizu7vKdytLgaJ5WHcS5gD2qj/sDHw1Nlm+4=; b=OKv/ruQYfUntdK9/Dgj7VTJqKDuPcdskjdNg7ZfHj7rWNMet8/vZuy8HjdgxpqL366 XKBpHtD2WKAxPT9pBdrxYXqLF8+fpg0X3MTQlFpD4Xstzt5hrmuI1cXzk7bY2y5l28JM VdaCSOilkJvKqD6SnsVzjcXRidycHYRWft+o8+y+hS+8K9v8EO2u96eJruJoLVVue4h5 sXkgyPF1+Ap5gk5ucFOrbroDsqNWFIIxqb/Oyqw6PkrpxAgzf0wqakNZCoDfYglkvvrL Hg6dOHclcl80GGD68gouEavo1+k7nm6XEqqJiYKscCNKal2knlNj3CyUQyH8CMgZI332 CAPw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=g+Y1w4Qj; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-58532-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-58532-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com X-Forwarded-Encrypted: i=2; AJvYcCXQecYq/5/E3koUdrCTwuY19ylP5wu1Gqncs741Td6Kau7WB5CS21HMhhSh/pywFVBKWFpVdjnMIfacB3GftDrU/yvbjw== Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id b17-20020a05620a0cd100b00783571b7509si132519qkj.483.2024.02.08.10.32.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 10:32:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-58532-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=g+Y1w4Qj; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-58532-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-58532-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 502AD1C23286 for ; Thu, 8 Feb 2024 18:32:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7CCA51E897; Thu, 8 Feb 2024 18:32:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="g+Y1w4Qj" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EC418C1A; Thu, 8 Feb 2024 18:32:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707417153; cv=none; b=cd7KTtWbEdtnIyJIP9rcd1kzKISbQqfAGuXWm6Sz9OPjyoxrmwy8I4UEjTGRtMmA55KyxqQzCbPeT+CGNeoiZ/HM1UJv5nblbw8wYUNuJAsmQ0bNQUTnRIsTOLTThG4SJRRSUq63Btq4uaYKt9qJvosZcZDaSBXnx2bt2vmv4qw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707417153; c=relaxed/simple; bh=ksPh+SGOZxTsk3yoazHWC1sh6u7Hvs7YFo8izy4mpuk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=onOeST6KyPRGq/jYY5BhMSbe52NRzjm4yOThHcdljClgwNSG+Ovb4CnppNgAu1Mk4oekMJgBAn3aPabqu2AlHuadzvfC6Ac6Upyar1PJoppFSVHEU7dWC98CSptAVqCfP9PB85pP7tOU+Jgf/j/XuM1ALIZkIgP2Z+MjXOyjWfA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=g+Y1w4Qj; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707417152; x=1738953152; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ksPh+SGOZxTsk3yoazHWC1sh6u7Hvs7YFo8izy4mpuk=; b=g+Y1w4Qjm/E4O+fA2DRY27iS+Mqk2iZimtdejN45e+XLENJwGxxBZXEv xa4KUxnEbm3VRVg+oH+dD8TH+Ig2rtA7iepUGpt6VVNGgT2fjPYnkrt+6 S2JLnpAHLJYjeqxkTByseA4sJ5gm6vaA/t05nBRJsGYV8Zz/Wxc8bdOaW wcUgyTui0KbKjQ2z4TpTDKIlt9bivpHb1jFnwkfNKUslD840AySIuXDpN kA2XSe2LHGkLIjJ06Ggw0wGaMvPNoJfqliR+n9bDDJOmWJg6rrnCQmEqm le1zKoz0R45Aqr++dbYCLA5kNu7u/ZXubAtjG12zlY5IgZoxo3l+aqpmj g==; X-IronPort-AV: E=McAfee;i="6600,9927,10978"; a="4268798" X-IronPort-AV: E=Sophos;i="6.05,254,1701158400"; d="scan'208";a="4268798" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2024 10:32:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10978"; a="824917165" X-IronPort-AV: E=Sophos;i="6.05,254,1701158400"; d="scan'208";a="824917165" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga001.jf.intel.com with ESMTP; 08 Feb 2024 10:32:27 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id DE1991584; Thu, 8 Feb 2024 20:26:09 +0200 (EET) From: Andy Shevchenko To: Daniel Thompson , Flavio Suligoi , Andy Shevchenko , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Lee Jones , Jingoo Han , Helge Deller Subject: [PATCH v3 3/3] backlight: mp3309c: Utilise temporary variable for struct device Date: Thu, 8 Feb 2024 20:24:48 +0200 Message-ID: <20240208182608.2224191-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240208182608.2224191-1-andriy.shevchenko@linux.intel.com> References: <20240208182608.2224191-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790356674539141052 X-GMAIL-MSGID: 1790356674539141052 We have a temporary variable to keep pointer to struct device. Utilise it where it makes sense. Reviewed-by: Daniel Thompson Tested-by: Flavio Suligoi Signed-off-by: Andy Shevchenko --- drivers/video/backlight/mp3309c.c | 30 ++++++++++++------------------ 1 file changed, 12 insertions(+), 18 deletions(-) diff --git a/drivers/video/backlight/mp3309c.c b/drivers/video/backlight/mp3309c.c index 426e9f2356ad..708c053d492c 100644 --- a/drivers/video/backlight/mp3309c.c +++ b/drivers/video/backlight/mp3309c.c @@ -222,10 +222,9 @@ static int mp3309c_parse_fwnode(struct mp3309c_chip *chip, */ pdata->dimming_mode = DIMMING_ANALOG_I2C; if (device_property_present(dev, "pwms")) { - chip->pwmd = devm_pwm_get(chip->dev, NULL); + chip->pwmd = devm_pwm_get(dev, NULL); if (IS_ERR(chip->pwmd)) - return dev_err_probe(chip->dev, PTR_ERR(chip->pwmd), - "error getting pwm data\n"); + return dev_err_probe(dev, PTR_ERR(chip->pwmd), "error getting pwm data\n"); pdata->dimming_mode = DIMMING_PWM; pwm_apply_args(chip->pwmd); } @@ -243,11 +242,9 @@ static int mp3309c_parse_fwnode(struct mp3309c_chip *chip, num_levels = ANALOG_I2C_NUM_LEVELS; /* Enable GPIO used in I2C dimming mode only */ - chip->enable_gpio = devm_gpiod_get(chip->dev, "enable", - GPIOD_OUT_HIGH); + chip->enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_HIGH); if (IS_ERR(chip->enable_gpio)) - return dev_err_probe(chip->dev, - PTR_ERR(chip->enable_gpio), + return dev_err_probe(dev, PTR_ERR(chip->enable_gpio), "error getting enable gpio\n"); } else { /* @@ -265,8 +262,7 @@ static int mp3309c_parse_fwnode(struct mp3309c_chip *chip, } /* Fill brightness levels array */ - pdata->levels = devm_kcalloc(chip->dev, num_levels, - sizeof(*pdata->levels), GFP_KERNEL); + pdata->levels = devm_kcalloc(dev, num_levels, sizeof(*pdata->levels), GFP_KERNEL); if (!pdata->levels) return -ENOMEM; if (device_property_present(dev, "brightness-levels")) { @@ -336,21 +332,21 @@ static int mp3309c_probe(struct i2c_client *client) if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) return dev_err_probe(dev, -EOPNOTSUPP, "failed to check i2c functionality\n"); - chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL); + chip = devm_kzalloc(dev, sizeof(*chip), GFP_KERNEL); if (!chip) return -ENOMEM; - chip->dev = &client->dev; + chip->dev = dev; chip->regmap = devm_regmap_init_i2c(client, &mp3309c_regmap); if (IS_ERR(chip->regmap)) - return dev_err_probe(&client->dev, PTR_ERR(chip->regmap), + return dev_err_probe(dev, PTR_ERR(chip->regmap), "failed to allocate register map\n"); i2c_set_clientdata(client, chip); if (!pdata) { - pdata = devm_kzalloc(chip->dev, sizeof(*pdata), GFP_KERNEL); + pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL); if (!pdata) return -ENOMEM; @@ -367,11 +363,10 @@ static int mp3309c_probe(struct i2c_client *client) props.type = BACKLIGHT_RAW; props.power = FB_BLANK_UNBLANK; props.fb_blank = FB_BLANK_UNBLANK; - chip->bl = devm_backlight_device_register(chip->dev, "mp3309c", - chip->dev, chip, + chip->bl = devm_backlight_device_register(dev, "mp3309c", dev, chip, &mp3309c_bl_ops, &props); if (IS_ERR(chip->bl)) - return dev_err_probe(chip->dev, PTR_ERR(chip->bl), + return dev_err_probe(dev, PTR_ERR(chip->bl), "error registering backlight device\n"); /* In PWM dimming mode, enable pwm device */ @@ -383,8 +378,7 @@ static int mp3309c_probe(struct i2c_client *client) pwmstate.enabled = true; ret = pwm_apply_might_sleep(chip->pwmd, &pwmstate); if (ret) - return dev_err_probe(chip->dev, ret, - "error setting pwm device\n"); + return dev_err_probe(dev, ret, "error setting pwm device\n"); } chip->pdata->status = FIRST_POWER_ON;