From patchwork Thu Feb 8 17:20:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 198251 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:50ea:b0:106:860b:bbdd with SMTP id r10csp45787dyd; Thu, 8 Feb 2024 01:28:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IHsG4zng219kWzmlfP2cfB1zBdwLoxrRIjRViA/ah7ieZVcPiSaUnVuHMH+LG2A0lODQipQ X-Received: by 2002:a25:bc92:0:b0:dc6:d7b6:cce9 with SMTP id e18-20020a25bc92000000b00dc6d7b6cce9mr8184884ybk.57.1707384499009; Thu, 08 Feb 2024 01:28:19 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707384498; cv=pass; d=google.com; s=arc-20160816; b=AduMOpozIV2keSWG3gda5fxRSFAJeqLt0gXmUybV+hTjTQBLHOZC+V1FKuJA1fxrQV gUK2c5Cf8QPAIkdY2KjmFoPrUX0AJdF1BfITSja2FcRnRukQqNVXZhHNgcNQ3ITXmltw lXDsGXyVO/wEaF/cI8JqhIn1g9C+CkPRCOu9ZW1Yiw9th6gkLMbDS0ZPzLQnISjvD/CG Du/qGgZ8PnMl9IE6T8Qr3I1LuC+GSsS2wm3kwqbjQuDV5hXN8RKoQQ888vTSAY0NDGOX 98lrdEmkcjUTEzHUSvSpTp6ifoxsMZC6Xf1OR4PiEOW2Q4jg29Aauoqx5+vMsIKRuJjI V+oQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=WGk0ITX1+D1LANQg31ZBRZNR3Vo7h96pnJQyOWxzpB0=; fh=b3Oua5JyTSS1E1Ud9OuJcg72ErcXaKs2f8iSK2uQbKw=; b=d460VzSjN7OLZAEKUekGeTpkbbc/0FJDB991Jdf6i08oEJNlRgD7eI5KpnMB0DUMJa XsGWth77lxN1MUn1bzM4VzFZ/nchEej52mY4tarwly1ri+A6heT5Krg7fsQrZpB2YBf6 FBh8cl6eXU09tUmd+3VFYWM1Egc5OtGI658+awWGWiQ7zy2OxxZjxDPg+jEQBwm5PQrm /2wmdX5uJAVp28a55BdYhZ2C0wGxsbhGguflPBpS1DtaBv0aauUCb/lEDAH7YN8/nGiP qwspPQTcIVLvFd468gVjBZikP4beczLbGCaOBejBLPay84i1p/Ww9V62GWjXbi3TLuRn UL3w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=huaweicloud.com); spf=pass (google.com: domain of linux-kernel+bounces-57738-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-57738-ouuuleilei=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=2; AJvYcCXpHrylabdDXQhxJVyc+VTU1Ent7DSU69C2Ukj0JcYFeXYZzeDFydppGuF0Mu8ahshlBWcajjBI4644TKE5A12P28B6uQ== Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id n68-20020a632747000000b005cee61cfde6si3476229pgn.437.2024.02.08.01.28.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 01:28:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-57738-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=huaweicloud.com); spf=pass (google.com: domain of linux-kernel+bounces-57738-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-57738-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id B6D57286471 for ; Thu, 8 Feb 2024 09:28:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0B13F7867B; Thu, 8 Feb 2024 09:23:17 +0000 (UTC) Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 434476EB70; Thu, 8 Feb 2024 09:23:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707384195; cv=none; b=RIfMk8sRY4aN7zI4aO0yUfSUBvVU/1i/+3C2gPfe4WpMYUsCipDtFjFm59rf6UC7nxgF7mAQooWGVT0ytIpLgWiuKzUEqsjj9D6AUflFauxmWj/PS2F0v8KVpX0uTHTjNY8pPwLRJhfs3wVh5XfsIvnuRBdiDl++InKISW5cQl0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707384195; c=relaxed/simple; bh=lHarguMikZ9Dwi9bzYFO+dQtmAomG+c+e8LUgIJpUgA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Pw/0Lm4l9YWuAGcRqwthZa5Y5O6KNTWiCp5cQs6Iv0ierJd5KPEzLdNARLtPB0S5SiMzXF8nc31e7e/SRSIAAwfAIBWjS8oC87EZaHARTS+NsAdU5dG7bdR2py0T5CtplBr9q5r45unKLDTY6HhnfXCXM1nF6625z/xO/8JSFxc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com; spf=pass smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.93.142]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4TVs3F3W4yz4f3kk6; Thu, 8 Feb 2024 17:23:05 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.75]) by mail.maildlp.com (Postfix) with ESMTP id 50E361A0172; Thu, 8 Feb 2024 17:23:08 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP2 (Coremail) with SMTP id Syh0CgAnSQx4ncRl3tGXDQ--.8574S8; Thu, 08 Feb 2024 17:23:08 +0800 (CST) From: Kemeng Shi To: viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 6/7] fs/writeback: correct comment of __wakeup_flusher_threads_bdi Date: Fri, 9 Feb 2024 01:20:23 +0800 Message-Id: <20240208172024.23625-7-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20240208172024.23625-1-shikemeng@huaweicloud.com> References: <20240208172024.23625-1-shikemeng@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-CM-TRANSID: Syh0CgAnSQx4ncRl3tGXDQ--.8574S8 X-Coremail-Antispam: 1UD129KBjvdXoWrZFy8Zw4kZr4xXr45ZFykAFb_yoWfWFc_JF W8tr4DGFZFgFs8J3WxZ3Z3JF92g3ykCF45uFySkF98J3WY9r97Zr4kZFyDJw1jvayUWFWx G347Wr40v39IkjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbfAYFVCjjxCrM7AC8VAFwI0_Wr0E3s1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l87I20VAvwVAaII0Ic2I_JFv_Gryl82 xGYIkIc2x26280x7IE14v26r126s0DM28IrcIa0xkI8VCY1x0267AKxVW5JVCq3wA2ocxC 64kIII0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM2 8EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4j6r4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0D M28EF7xvwVC2z280aVCY1x0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc 02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAF wI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JMxAIw28IcxkI7V AKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCj r7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6x IIjxv20xvE14v26r1I6r4UMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAI w20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x 0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IU0TqcUUUUUU== X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790322408604653226 X-GMAIL-MSGID: 1790322408604653226 Commit e8e8a0c6c9bfc ("writeback: move nr_pages == 0 logic to one location") removed parameter nr_pages of __wakeup_flusher_threads_bdi and we try to writeback all dirty pages in __wakeup_flusher_threads_bdi now. Just correct stale comment. Signed-off-by: Kemeng Shi Reviewed-by: Jan Kara --- fs/fs-writeback.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c index e8868e814e0a..816505d74b2f 100644 --- a/fs/fs-writeback.c +++ b/fs/fs-writeback.c @@ -2345,8 +2345,7 @@ void wb_workfn(struct work_struct *work) } /* - * Start writeback of `nr_pages' pages on this bdi. If `nr_pages' is zero, - * write back the whole world. + * Start writeback of all dirty pages on this bdi. */ static void __wakeup_flusher_threads_bdi(struct backing_dev_info *bdi, enum wb_reason reason)