From patchwork Thu Feb 8 16:58:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 198630 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:50ea:b0:106:860b:bbdd with SMTP id r10csp499151dyd; Thu, 8 Feb 2024 14:52:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IGZguBIy4LBwK59HvkDOfVf1FKJef6BFTU+6zPaHbV5kW6+KANVVz6iuIhHK+8fuIsCzHKD X-Received: by 2002:a17:906:4096:b0:a38:5f1f:ce9a with SMTP id u22-20020a170906409600b00a385f1fce9amr526728ejj.20.1707432721048; Thu, 08 Feb 2024 14:52:01 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707432721; cv=pass; d=google.com; s=arc-20160816; b=qg+OwnvVHOev9dylEgrORZp+0LEglrrsz62wiNiwF8VYCUyH3km56T8iYuyKvFKW8c nPYZy3Y4GJcRylEKo6PwB9j/rKOC36D/CvzhU3U9S7/nbkfAK+jdoFGI6Yw1IBEqtdBp BIJxCy8qYVKIfD13eycLlW7fYL2yY9JGnO9lfwNDdGwlL15yUIdaYHfAt/ZJlYE0llOb TfSWUIc9KORERFrPfdR5r7pKTAu+b9swJ2GFoADTwJObqcGm+ZQYZ1hbKLJcrmtpM3cY caOXG0ciOK5W9YS/uxK0Lyb+JESiyReHNdaA2y/eXQjTTxuHTfRkDAmR4T0q7mhZJX+e Hi4A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=AOqpC7l/E/vfwk/M1hwkJOZablnU70sx8ddiG/mlhW8=; fh=XgEAYES78HqTg+lX+LUO2jPh9sGpVixgu20CRm45/L8=; b=CwuPONRMU6AM5C7LFdjQXD2RFufbFmm85x7yyP+wj5OK1djIm5tu+fUW1LvSJquTkK KqWKjBO4qYToAjHWzxg3VhUC8Dt0aNUNRUh94Mje3PHtiL/Whk/LuIfI/sCtls1ALACf OLrQR6xdaX71VuEjzm5s3qg91ed3sJWn9ZkUsxMwP55w464csx1gVzhiPBmp/LkdkHp6 +32q4wuqrUeBCUe60OOqgTbU7VAmd1IUO5jvKcrOf6HsBRbXoGdIRQRPnnslCu+9f7RU 5ApJY45YCcYdfwMyR663QQwx/BiNhBcnpCtcGcl2x1S19MOOkSe7hBc1Hi+4q8sk3U7r zUMg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="PL5U/jqa"; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-58552-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-58552-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com X-Forwarded-Encrypted: i=2; AJvYcCURznWxu5Jycql65AtaUov7SaZ9/8V/URrVVY45rsvG4lPkk06YrbZza8O0ciUQuuNCec208yyWDL5X4DxaM189N5sJsw== Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id lo25-20020a170906fa1900b00a3bb8758a8csi128551ejb.385.2024.02.08.14.52.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 14:52:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-58552-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="PL5U/jqa"; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-58552-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-58552-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 0A7B21F26985 for ; Thu, 8 Feb 2024 18:46:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A688C29CF1; Thu, 8 Feb 2024 18:45:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="PL5U/jqa" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AFB0208DC; Thu, 8 Feb 2024 18:45:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.19 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707417955; cv=none; b=sl2PvgEX4Cuoo4LSgTFfpXY8qCcKD+bsyxzZFc0WkO7ACFkL85KASlRWqRQpaLVMSDokCtX56hc7SVqRGjJGJ8XdzMk+0Y5KtSR+lw11bBqGO6yedaH0tQK80+S3cEmG3qSHhj+n0JCIGWdtCDJFnAEb7agtXUy5FGvZrCml7zg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707417955; c=relaxed/simple; bh=5fFTptxgaNSrb8/J39Uzrc6cETbfYvICnOp+m4GRuCg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YZaSlBxmJnSFOYEpWp+yfwccduVqjtuQZeM3B99CAYFG3wjeA27fUf2X33lPfaqhfETU/hPp321wL9jujhYzyctZeNU0tYYyjuw9+u8vSrMWIjGL5Kw3SOjU/E8gvSvvzzhhUgLEQezMe1olGS0NIRup7gMMYYxGGGM/2HyMaDQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=PL5U/jqa; arc=none smtp.client-ip=192.198.163.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707417954; x=1738953954; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=5fFTptxgaNSrb8/J39Uzrc6cETbfYvICnOp+m4GRuCg=; b=PL5U/jqaYvanJNb1WeP9R17EfjaHTUI9mCROp5OAvtmcR/gim5r68/9q rk9Dvuti3lnxUJayJhC6+kRrTgY9lo+tHcVOiDKkhxSA9TKuh7pkm/KSR /GUQ7ZU4Fq0Hd4ibtKOExn7lbBbipDC4GgZ8EDs6+ywcC0NEfpxfL4027 YvBrj5I1t88BQvVg40HYUH+GuRTmvpBxMGIHQNPhjz/+YaEgazxKXQzqz jKGwTJxT8QJzgCq1IM6MwGKxi0iMWvR5dzkq/MJDuPT7xjr/1NO9uykCy /kWTZQXW5qId6StBSOg0PHfYqetH1rdG71h2b78R+5W4sGEQzZBI9oASf w==; X-IronPort-AV: E=McAfee;i="6600,9927,10978"; a="1185242" X-IronPort-AV: E=Sophos;i="6.05,254,1701158400"; d="scan'208";a="1185242" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2024 10:45:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10978"; a="934214462" X-IronPort-AV: E=Sophos;i="6.05,254,1701158400"; d="scan'208";a="934214462" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 08 Feb 2024 10:45:49 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 82899157E; Thu, 8 Feb 2024 18:59:41 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Miguel Ojeda , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robin van der Gracht , Paul Burton , Geert Uytterhoeven Subject: [PATCH v1 11/15] auxdisplay: ht16k33: Move ht16k33_linedisp_ops down Date: Thu, 8 Feb 2024 18:58:54 +0200 Message-ID: <20240208165937.2221193-12-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240208165937.2221193-1-andriy.shevchenko@linux.intel.com> References: <20240208165937.2221193-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790372973130240674 X-GMAIL-MSGID: 1790372973130240674 We will need the update functions to be defined before ht16k33_linedisp_ops. Move the latter down in the code. No functional change intended. Signed-off-by: Andy Shevchenko --- drivers/auxdisplay/ht16k33.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c index 0cdf3fbdf81e..75c4a8d31642 100644 --- a/drivers/auxdisplay/ht16k33.c +++ b/drivers/auxdisplay/ht16k33.c @@ -440,18 +440,6 @@ static void ht16k33_keypad_stop(struct input_dev *dev) disable_irq(keypad->client->irq); } -static void ht16k33_linedisp_update(struct linedisp *linedisp) -{ - struct ht16k33_priv *priv = container_of(linedisp, struct ht16k33_priv, - seg.linedisp); - - schedule_delayed_work(&priv->work, 0); -} - -static const struct linedisp_ops ht16k33_linedisp_ops = { - .update = ht16k33_linedisp_update, -}; - static void ht16k33_seg7_update(struct work_struct *work) { struct ht16k33_priv *priv = container_of(work, struct ht16k33_priv, @@ -489,6 +477,18 @@ static void ht16k33_seg14_update(struct work_struct *work) i2c_smbus_write_i2c_block_data(priv->client, 0, ARRAY_SIZE(buf), buf); } +static void ht16k33_linedisp_update(struct linedisp *linedisp) +{ + struct ht16k33_priv *priv = container_of(linedisp, struct ht16k33_priv, + seg.linedisp); + + schedule_delayed_work(&priv->work, 0); +} + +static const struct linedisp_ops ht16k33_linedisp_ops = { + .update = ht16k33_linedisp_update, +}; + static int ht16k33_led_probe(struct device *dev, struct led_classdev *led, unsigned int brightness) {