diff mbox series

[09/12] spi: s3c64xx: get rid of the OF alias ID dependency

Message ID	20240208135045.3728927-10-tudor.ambarus@linaro.org
State	New
Headers	Received-SPF: pass (google.com: domain of linux-kernel+bounces-58184-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; From: Tudor Ambarus <tudor.ambarus@linaro.org> To: broonie@kernel.org, robh@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, conor+dt@kernel.org, devicetree@vger.kernel.org, arnd@arndb.de, Tudor Ambarus <tudor.ambarus@linaro.org> Subject: [PATCH 09/12] spi: s3c64xx: get rid of the OF alias ID dependency Date: Thu, 8 Feb 2024 13:50:42 +0000 Message-ID: <20240208135045.3728927-10-tudor.ambarus@linaro.org> In-Reply-To: <20240208135045.3728927-1-tudor.ambarus@linaro.org> References: <20240208135045.3728927-1-tudor.ambarus@linaro.org> Precedence: bulk MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX
Series	spi: s3c64xx: remove OF alias ID dependency \| [00/12] spi: s3c64xx: remove OF alias ID dependency [01/12] spi: dt-bindings: introduce the ``fifo-depth`` property [02/12] spi: s3c64xx: define a magic value [03/12] spi: s3c64xx: allow full FIFO masks [04/12] spi: s3c64xx: determine the fifo depth only once [05/12] spi: s3c64xx: retrieve the FIFO depth from the device tree [06/12] spi: s3c64xx: allow FIFO depth to be determined from the compatible [07/12] spi: s3c64xx: let the SPI core determine the bus number [08/12] spi: s3c64xx: introduce s3c64xx_spi_set_port_id() [09/12] spi: s3c64xx: get rid of the OF alias ID dependency [10/12] spi: s3c64xx: deprecate fifo_lvl_mask, rx_lvl_offset and port_id [11/12] spi: s3c64xx: switch gs101 to new port config data [12/12] spi: s3c64xx: switch exynos850 to new port config data

Commit Message

Tudor Ambarus Feb. 8, 2024, 1:50 p.m. UTC

  Compatibles that set ``port_conf->{rx, tx}_fifomask`` are now safe to
get rid of the OF alias ID dependency. Let the driver probe even without
the alias for these.

With this we also protect the FIFO_LVL_MASK calls from
s3c64xx_spi_set_fifomask().

Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
---
 drivers/spi/spi-s3c64xx.c | 4 ++++
 1 file changed, 4 insertions(+)

diff mbox series

Patch

diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index 40de325bd094..d2d1c9767145 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -1203,8 +1203,12 @@  static inline const struct s3c64xx_spi_port_config *s3c64xx_spi_get_port_config(
 static int s3c64xx_spi_set_port_id(struct platform_device *pdev,
 				   struct s3c64xx_spi_driver_data *sdd)
 {
+	const struct s3c64xx_spi_port_config *port_conf = sdd->port_conf;
 	int ret;
 
+	if (port_conf->rx_fifomask && port_conf->tx_fifomask)
+		return 0;
+
 	if (pdev->dev.of_node) {
 		ret = of_alias_get_id(pdev->dev.of_node, "spi");
 		if (ret < 0)