From patchwork Thu Feb 8 12:20:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 198358 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:50ea:b0:106:860b:bbdd with SMTP id r10csp123861dyd; Thu, 8 Feb 2024 04:20:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IH+zynqGxJbVHPfEAKdZlixpu7FfFXukzaBWeWOV63l55sio0ZHJ2hn1IRipuCvsuEmxk38 X-Received: by 2002:a17:907:1112:b0:a38:1d44:dc54 with SMTP id qu18-20020a170907111200b00a381d44dc54mr5359057ejb.48.1707394842239; Thu, 08 Feb 2024 04:20:42 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707394842; cv=pass; d=google.com; s=arc-20160816; b=ulnkNOh1WP/5kz0qCXy01gvji29vIReHzPHoC0MYmLFxQ4UA30BIOADUUqTu0PL6t8 SpDmjYHnutC2IzTliJ5cA4C80DDalXs7SXHDTAjG0dFJXbvOK4tb3SncpCA+5FxJQ9hu yPKGLao/ONL3bqtR6mOVf9CB3oWV876aSpqmxIgwViDXPSBXi08oB08phb/OR7xi2B40 Y99D1DCHrlwikuva54GgKnQo+NXCdPhP8iEUZZnSlLvOsD06xk7JZ7Lp2ehiZ8bipvvJ 3Wd/nrMqWI6rM4D93dj7OqLbbrTKVTBH2TTuGdYwWF6my7lsDYaNS6Fkbx9/vBxtDUk/ 7aIg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=72psFLs8Gi+MNEJgx2lwnlswN63/mhrnZDzpSoNcpqc=; fh=uMw1VsndbN862C+zwItOLghUWgTkm10LiYP7sb+h0VM=; b=zCBnZTy3vLmDGOqRZk01JcwXAItZoQ/CG+5mETPO4XQ3SU5MdQe9trws70/memLS/2 rOfmt2HBsbeck9iEclwLM07g56VPx1xdLcrrkL2bUOq3c4r0okw+7jdclZDle8jPKyo/ 69HWcweHMoo9pnLbyjH6fcS0voO7NkHDDZYyCUcQjvzd4SHwZ45LZC6z8ifJOo2ZphRR Ixkmk7xIyCocbhAevGloBTVONOn/skZytmI+v1L4bmlzAT0lb4NJGnP3z3w5+d74OU3U A7KDU29wyiDfF7WRV6kxvgODfVqrobLSlB7TVe4urakq1cMwCNMeBIyxXxccR7rSN3RD tcsw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="ZbDu/bjn"; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-58042-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-58042-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com X-Forwarded-Encrypted: i=2; AJvYcCVYruecysTTxlmfaee9NqmiYXnzdO+WbjvEPPx0olTocWN01JmpMt5kfhhp2bTAJY+MLvhGv35oM/P6DaoTaaPcH4EeSQ== Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id gl18-20020a170906e0d200b00a3ba261d09dsi615920ejb.709.2024.02.08.04.20.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 04:20:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-58042-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="ZbDu/bjn"; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-58042-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-58042-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 9B9281F2AA08 for ; Thu, 8 Feb 2024 12:20:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A492471B38; Thu, 8 Feb 2024 12:20:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZbDu/bjn" Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60D316A029; Thu, 8 Feb 2024 12:20:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707394818; cv=none; b=u0IsJ0s84IRe9bS8fjpP0BKLuFeQfehpN64zhdxESZRigYNHzfnJHqmrQ/IQcYBSZPBgdgiYIsPEbggj7THSR8lBigvIj7pJQpHHzpkXptePnh1zNIj6iy3n9MiemwZfDqz9Xns2cGIMyqeNr6JKEPMjvbqOISH9JsiaH9OgT50= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707394818; c=relaxed/simple; bh=1/jElOUkOjtycqTK7uBY+Fqg6b2L402KOEq/KFj5Lvw=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Type; b=NX0UUW3PftQp7FZPSIqlgj+XPotr44VpeSdiuanKtR6YIr3dK5aXHMAMVcZMSXf3MZuR1WJ84GdIK5fkTWnHeJfjkauLhLVNwgiIzEopJD3VT1OuiZHjJeKt6oJAjeP0HaLG04KM6PSDD2DSbcN5dxKzY3uQzyi3zQrDk26rIk4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZbDu/bjn; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-511717231bfso374250e87.2; Thu, 08 Feb 2024 04:20:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707394814; x=1707999614; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=72psFLs8Gi+MNEJgx2lwnlswN63/mhrnZDzpSoNcpqc=; b=ZbDu/bjnHzI54pLS2rmiI/0zsGt4CAY9+SXrBjF1DAmMbQ+3tSsPlQf8svAmTvZkas UzM59oujXfX4pXI4meQUZHz37rHpB6P/BXG/2eecsumx+TsK85QwEn5kcGnhPEcBD0ef V6xI+q0sZ29tx4ZxKDVkqalZq05/lq6uvFnaEh/DAZGZFWxBzkSgyVpuP5DbUAci1vy5 8eRtH2QZcwbqexZvxoAyMlbUE0ODh0oFVWK7fGq0pyDqwMD7dm3TfpObyUXvQaYEk9gS 1uneRam1tmOsKSuQL2N1xsuu8U5guC3XZvNC/1bfn4CGO12vcIdCcuX0+PzJMpCuk0iF Ll8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707394814; x=1707999614; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=72psFLs8Gi+MNEJgx2lwnlswN63/mhrnZDzpSoNcpqc=; b=L4wzViiKF8y7DQhBPCmJSV1igtgOcUOD9NDt807wMedeF9qxdIe+dddnv9CypDhykT dJYJSxLPxy121D1YwGtBAGQggu3XBPVMrURcTI+AH5GFestwHw48g3he3jZLtMSkyqEr M0rk412dIjuviecyQw1PeB2T6u09SxV8davDxZQrQcbE51J6P1029seYAQP4ZMWNp/YB XUD8Dm8NHU1lEeFaw0MVbfBnXOszTDBSKNyY+WJ8jGZHqY99yRzl8fM2vddZRFsK75HB FszBgSTmIqEFikc/2gQyXhk379DX0JiNgl6BMEbsGQbqSSimKVU0t+95km6xb5KoVspE ECGA== X-Gm-Message-State: AOJu0YywJj6odoSqCIJMvQDIni3rcQlI0s+r7h8BuTtl3YO4uDtuRXld UDWyCjwfGxIXUEe8+1F04oQ20+eV5FmcpPvxibQhOTYvxfAHbipp X-Received: by 2002:a05:6512:1ce:b0:511:6f52:9592 with SMTP id f14-20020a05651201ce00b005116f529592mr867243lfp.62.1707394814110; Thu, 08 Feb 2024 04:20:14 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUj10yafoWt1eIWzfE3DFvv66rQwqJhRT1Gjr9TL7+Pt4Uy3nGc0MnTLVQPVAxpcZUeYU95/mgzLBQ63zX9B7ozVyMhU3JsIEMUjm1Rss/BXuinS8M6wqgppfHkWh/gJL/1A6q406YOib8rhQ2X1yTAlECjRturQ5qYaDVI7D5vJGkWMlgt6QvbRtzJYXWR5+m4NBEVyWny0g8dXYVhG5iwczNIJuI1PMtt3+8NoIYtL66/++4lOBkJUPeDy1NMv2QPiR8f+HCoAGh+6bTk++CVeeRWwA3N7Jzyn+zOhAuPuhXfIJ1G2m0gY2J+7+YHR1Ku1HqfXwTdVgX6WCEG97UDvg4E4H0= Received: from localhost (cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net. [80.193.200.194]) by smtp.gmail.com with ESMTPSA id r17-20020a05600c35d100b0040fdb17e66csm1489447wmq.4.2024.02.08.04.20.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 04:20:13 -0800 (PST) From: Colin Ian King To: Iyappan Subramanian , Keyur Chudgar , Quan Nguyen , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][next] drivers: net: xgene: remove redundant assignment to variable offset Date: Thu, 8 Feb 2024 12:20:12 +0000 Message-Id: <20240208122012.2597561-1-colin.i.king@gmail.com> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790333254260032733 X-GMAIL-MSGID: 1790333254260032733 The variable offset is being initialized with a value that is never read, it is being re-assigned later on in either path of an if statement before being used. The initialization is redundant and can be removed. Cleans up clang scan build warning: drivers/net/ethernet/apm/xgene/xgene_enet_cle.c:736:2: warning: Value stored to 'offset' is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King --- drivers/net/ethernet/apm/xgene/xgene_enet_cle.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_cle.c b/drivers/net/ethernet/apm/xgene/xgene_enet_cle.c index de5464322311..8f104642897b 100644 --- a/drivers/net/ethernet/apm/xgene/xgene_enet_cle.c +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_cle.c @@ -733,7 +733,6 @@ static int xgene_cle_setup_rss(struct xgene_enet_pdata *pdata) u32 offset, val = 0; int i, ret = 0; - offset = CLE_PORT_OFFSET; for (i = 0; i < cle->parsers; i++) { if (cle->active_parser != PARSER_ALL) offset = cle->active_parser * CLE_PORT_OFFSET;