From patchwork Thu Feb 8 09:19:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bhargav Raviprakash X-Patchwork-Id: 198238 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:50ea:b0:106:860b:bbdd with SMTP id r10csp43937dyd; Thu, 8 Feb 2024 01:23:08 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCV7cwjMj6JVitmTPELVQsJCL9/nGPdc7X9F9RaAzUhYLCuqSaZdKd5Gu7Roz8mPlJnJ+AnLQclwZqJUF6DtrU2HdsDO8A== X-Google-Smtp-Source: AGHT+IFT38Kkg9EFF+xWR3kXJhnZ8Nmtuf+xLyfp0/bosGM2HKmK46K+HnkWnHkB7POJ5SNxCy3G X-Received: by 2002:a05:6830:12d2:b0:6dd:db5a:d924 with SMTP id a18-20020a05683012d200b006dddb5ad924mr9237944otq.1.1707384188483; Thu, 08 Feb 2024 01:23:08 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707384188; cv=pass; d=google.com; s=arc-20160816; b=hGbnmcVaBnXBLTLoJmMX3OXmvtP3jUzrpmOwO4Q3LZrrEJCUI1/zQBEjCA1L+h6dum tu613lDFyYJmxgluCvCF2bl4R62h+5SE+SCID3XOwUOn7YqmeASyO5BYcPi+uY6MWSg8 eBKTzb3ILFHjp0mFBv947rtYUbjvJac750x4pUXH55CNcJJq/VaiWwrDuhHoCfjxTH1Z ITdstru6iDc9hVs2xAWwr9AFlw2dgZNxo7qXAaYE+aMYiCMnUrdSagLJP9iJGMt4F80d 2wEJlt6hiEq5C4r3vQTVHSIOt9aphWhTDxhliZU7g4dFr46NiJJP8aOWjnnBbA9fvU8w bCFg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:ironport-sdr; bh=YeLYVQm/pXOq8S5WvohMeVvsq2tyK0FfHWV4LvNOzDk=; fh=q5IQyMZP8iQ3KHBRQgpYhDyAAhL1V8tYM9qBXhSiXS0=; b=BgtkWhyy7EGOKwfmWrotWJZbrwXdNgem53O4jyC0vRAuQpG2XhN1xntH/1pwU80+D9 jNiKKwIUyIq4A5TgNShyhHgUWviLaOGpFeQhLSOl0Ggfb30PqPPirQd8S3Kta7m1Ujqi 7jiHQ0WJjHviP6G2t4qRhl4Yc93m4hP99V2GbKJIxwqr7ZV7Px670fx1A8CQWdaYCn3i by62HYVlaPxgKEYg8ynVz+6pdnJkz3lOa54Xk+Z7cLtnj8meHPXRriLgnVObG7kuJNzV YPM66rjKcBOuvYm0aD9QxGrqX8GERL0kg7mnjREqEnrRzIG/5j08uHPj2QdmWgTwKnJA f3pw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=ltts.com dmarc=pass fromdomain=ltts.com); spf=pass (google.com: domain of linux-kernel+bounces-57721-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-57721-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ltts.com X-Forwarded-Encrypted: i=2; AJvYcCWfGu5HQ9CayxsigUgZyCYK6kYNPVMAv/svZ+XrstnSx6j1dSrPpJFsyp1/cqvmVEPHTBXAJ99GZF/fOR0/Cs4vHZwl/A== Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id a62-20020a639041000000b005d8b8ca425esi3506598pge.308.2024.02.08.01.23.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 01:23:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-57721-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=ltts.com dmarc=pass fromdomain=ltts.com); spf=pass (google.com: domain of linux-kernel+bounces-57721-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-57721-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ltts.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 2949A289320 for ; Thu, 8 Feb 2024 09:23:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 34B086F51A; Thu, 8 Feb 2024 09:21:03 +0000 (UTC) Received: from esa2.ltts.com (unknown [14.140.155.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 259906EB57 for ; Thu, 8 Feb 2024 09:20:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=14.140.155.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707384061; cv=none; b=a6avkQeL84DPJETtGYnfrvuC04Tp8VbegSY4tLOd7Cbc709FOO+LtrI2/AiayBXoy6qjxf5xyvRgbGlf3RZmZ4uGdMtbdQh5rkgv+xrbOnUIhxEjarISZWIgMuBGIVhaLgr9EV6nNAk9M+4UWSe6xEiWgzNosfDyiVpVTFsvUUQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707384061; c=relaxed/simple; bh=QqiVaGyVZLVdQRUJj79HXou64FEpupT0GmSSU1mSm4Y=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=P1Ux/cAhvshiKSe2KxQkitt5LX6lk/KHvApJ25HbNnmCSHD9Rv08KmKAjIZBKa8a7Li1sZSeGjOXnZ47JmpkuUgWBzp+lbZszra5QdJqgRwFzQMoxanI1VcBbQH554Gwu1x4hYFF5SH6dG2ToHvPh3RynLC+Tmg+o/KpRfUeiSw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ltts.com; spf=pass smtp.mailfrom=ltts.com; arc=none smtp.client-ip=14.140.155.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ltts.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ltts.com IronPort-SDR: Gq/uKNyyoayZsZ9dBSP0JzXXATKZhXyq9fRRqGqpkqmW9IkTAAA+wIMr8VPzkJrFTowcSEUgp8 fZ4tksnHm2ew== Received: from unknown (HELO localhost.localdomain) ([192.168.34.55]) by esa2.ltts.com with ESMTP; 08 Feb 2024 14:49:39 +0530 From: Bhargav Raviprakash To: linux-kernel@vger.kernel.org Cc: m.nirmaladevi@ltts.com, lee@kernel.org, Bhargav Raviprakash Subject: [PATCH v1 02/13] mfd: tps6594: use volatile_table instead of volatile_reg Date: Thu, 8 Feb 2024 14:49:22 +0530 Message-Id: <20240208091922.1206916-3-bhargav.r@ltts.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240208091922.1206916-1-bhargav.r@ltts.com> References: <20240208091922.1206916-1-bhargav.r@ltts.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790322082960585541 X-GMAIL-MSGID: 1790322082960585541 In regmap_config use volatile_table instead of volatile_reg. This change makes it easier to add support for TPS65224 PMIC. Signed-off-by: Bhargav Raviprakash --- drivers/mfd/tps6594-core.c | 16 ++++++++++------ drivers/mfd/tps6594-i2c.c | 2 +- drivers/mfd/tps6594-spi.c | 2 +- include/linux/mfd/tps6594.h | 4 +++- 4 files changed, 15 insertions(+), 9 deletions(-) diff --git a/drivers/mfd/tps6594-core.c b/drivers/mfd/tps6594-core.c index 783ee5990..089ab8cc8 100644 --- a/drivers/mfd/tps6594-core.c +++ b/drivers/mfd/tps6594-core.c @@ -319,12 +319,16 @@ static struct regmap_irq_chip tps6594_irq_chip = { .handle_post_irq = tps6594_handle_post_irq, }; -bool tps6594_is_volatile_reg(struct device *dev, unsigned int reg) -{ - return (reg >= TPS6594_REG_INT_TOP && reg <= TPS6594_REG_STAT_READBACK_ERR) || - reg == TPS6594_REG_RTC_STATUS; -} -EXPORT_SYMBOL_GPL(tps6594_is_volatile_reg); +static const struct regmap_range tps6594_volatile_ranges[] = { + regmap_reg_range(TPS6594_REG_INT_TOP, TPS6594_REG_STAT_READBACK_ERR), + regmap_reg_range(TPS6594_REG_RTC_STATUS, TPS6594_REG_RTC_STATUS), +}; + +const struct regmap_access_table tps6594_volatile_table = { + .yes_ranges = tps6594_volatile_ranges, + .n_yes_ranges = ARRAY_SIZE(tps6594_volatile_ranges), +}; +EXPORT_SYMBOL_GPL(tps6594_volatile_table); static int tps6594_check_crc_mode(struct tps6594 *tps, bool primary_pmic) { diff --git a/drivers/mfd/tps6594-i2c.c b/drivers/mfd/tps6594-i2c.c index 899c88c0f..c125b474b 100644 --- a/drivers/mfd/tps6594-i2c.c +++ b/drivers/mfd/tps6594-i2c.c @@ -187,7 +187,7 @@ static const struct regmap_config tps6594_i2c_regmap_config = { .reg_bits = 16, .val_bits = 8, .max_register = TPS6594_REG_DWD_FAIL_CNT_REG, - .volatile_reg = tps6594_is_volatile_reg, + .volatile_table = &tps6594_volatile_table, .read = tps6594_i2c_read, .write = tps6594_i2c_write, }; diff --git a/drivers/mfd/tps6594-spi.c b/drivers/mfd/tps6594-spi.c index 24b72847e..5afb1736f 100644 --- a/drivers/mfd/tps6594-spi.c +++ b/drivers/mfd/tps6594-spi.c @@ -70,7 +70,7 @@ static const struct regmap_config tps6594_spi_regmap_config = { .reg_bits = 16, .val_bits = 8, .max_register = TPS6594_REG_DWD_FAIL_CNT_REG, - .volatile_reg = tps6594_is_volatile_reg, + .volatile_table = &tps6594_volatile_table, .reg_read = tps6594_spi_reg_read, .reg_write = tps6594_spi_reg_write, .use_single_read = true, diff --git a/include/linux/mfd/tps6594.h b/include/linux/mfd/tps6594.h index 1d8969594..6c5a2889f 100644 --- a/include/linux/mfd/tps6594.h +++ b/include/linux/mfd/tps6594.h @@ -1344,7 +1344,9 @@ struct tps6594 { struct regmap_irq_chip_data *irq_data; }; -bool tps6594_is_volatile_reg(struct device *dev, unsigned int reg); +extern const struct regmap_access_table tps6594_volatile_table; +extern const struct regmap_access_table tps65224_volatile_table; + int tps6594_device_init(struct tps6594 *tps, bool enable_crc); #endif /* __LINUX_MFD_TPS6594_H */