From patchwork Wed Feb 7 20:22:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Zhang X-Patchwork-Id: 198098 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp2522756dyb; Wed, 7 Feb 2024 13:45:11 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXjwLhG+EICEiynFijdlsEYfmtBICEn8tT6UUUCt6cYK6LE7EIISWUfIUbujejZOwhPke+W/7KOO/l9dJ6jPlzvCmguJg== X-Google-Smtp-Source: AGHT+IGiecTcqmNOOXoPtmb0x/WpBXVSCoHpL0I5nBHD9/hwQpEAqiJXrIes/E3SOt2fHbnu/ZxR X-Received: by 2002:ae9:e647:0:b0:783:f534:cb54 with SMTP id x7-20020ae9e647000000b00783f534cb54mr7346901qkl.69.1707342311700; Wed, 07 Feb 2024 13:45:11 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707342311; cv=pass; d=google.com; s=arc-20160816; b=Np9Sev7bDH8zZVJLwbA7f9Xiz4KW1UJWI716E+k7nzuY0dNKDAV9KS798U6ucdKcol 0JZfUASxG6NfamuAcPGF5SnbSjFyRx/wLC2EYZeHaYLZHYj6bhrLT9vYJlxvySU4qm7p K2UjacsyeiUGXOQsxMC/hlN2BUv7/LxrwpFi7KmqQqh68ObMFUOMd2rUk5R+cU4lO+ZS 2Vs9g7dBSLbP1+N8Zf2E4Yf5cuEIYVSDaV9uyCdWBU3M5uKZj9FYcUGUi1/INB7soSnH MNndqc43JSDL2TfAC+iyATW7JKOpX1LIl1uXfZNGNgedat2RhbRDE49emopCF+aOGoaL 8HSA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature:dkim-filter; bh=Zt71AErWnW14KdC6HZEUWnKYHx2oYqbAd2ymCiwl3HM=; fh=FjcL+X3vDK3tHkCMgGDgGE8aeSRRI4pNiiNDbY42ukU=; b=LrgUnHVzCJSnMEhPVArR5Xj45Drz5CiMD93w66Are1ORS6qtHnV/I+0+NWqUnu6qHX 88X20ZeaX/WHRPvhLdCRNbBHL7lGvj1o+ieP27DAMbcKOxfLmFXsN6N4uD3/SN/0QiQt FHsoVKkLZmbkDLQ7ZaqLMbtIr9AYcXCJDxk0wKgMjgLnrEu/u+UbbIGjKQ83cvvnvPA0 lhs6bKV9MgYV9ffYZ7ae9NVV3+j/IWi9MPrNO1hpBqMbu8t8Khdk42ITvROzt9o61/23 BYNe4YPA5FdkzpQDRqLthO2l2dc4O7sJa+KCB2oPqpUt0/HnRCRHXaFILRmf93dffMhV 9sOA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@broadcom.com header.s=dkimrelay header.b=ZIPVbQpS; arc=pass (i=1 dkim=pass dkdomain=broadcom.com dmarc=pass fromdomain=broadcom.com); spf=pass (google.com: domain of linux-kernel+bounces-57023-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-57023-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com X-Forwarded-Encrypted: i=2; AJvYcCX2nLD9AbdlXr4sG0GN7TCdkzAg3GVSFTYSJNp/F1UV8YYddKUS7xSIZ53ncKKArm2e2PmvUjeoHOdhdAzEcIS5nx8CVg== Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id bi39-20020a05620a31a700b00785635b9afbsi2270918qkb.538.2024.02.07.13.45.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 13:45:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-57023-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=dkimrelay header.b=ZIPVbQpS; arc=pass (i=1 dkim=pass dkdomain=broadcom.com dmarc=pass fromdomain=broadcom.com); spf=pass (google.com: domain of linux-kernel+bounces-57023-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-57023-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 416A01C26EE7 for ; Wed, 7 Feb 2024 20:26:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EEB0F12F380; Wed, 7 Feb 2024 20:24:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="ZIPVbQpS" Received: from relay.smtp-ext.broadcom.com (relay.smtp-ext.broadcom.com [192.19.144.205]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF82912F369 for ; Wed, 7 Feb 2024 20:24:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.19.144.205 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707337462; cv=none; b=B2B1vMFqxWC0AF4Nd4dVZQotPAdGJH4ZEfhpszLNcvcWhGrqzf9mFhYskleCmyiwvKLOlt2O1e2vjDW+QboH3FveC4Dvo0rDryiu6Wn2waWZc0uR57XWK9h90fqFf6Bum8c3wRi0PououNn8wEVZ5Q7JnQjjEODfxioGG64eTWM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707337462; c=relaxed/simple; bh=SEUbGpLY/kY+cXDOt4nGhWXvuLxy9O4W4aujYHBLgx4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Q5gsj7cseglQz7mweZdXP186IIUPotDlFfW7c2h4KgaqVu03hLm1sbAWeU5HAQ2FGVbSAe/d94BAODY4clqKv/S8IEAGZnYYzeysbDzRo0wtg4IODBN+QvYuBqGjLlsz5CkacDo2gwp3tPRjwC6D8FFSpGOLER6FLD194b8Y7JY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=ZIPVbQpS; arc=none smtp.client-ip=192.19.144.205 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Received: from mail-lvn-it-01.lvn.broadcom.net (mail-lvn-it-01.lvn.broadcom.net [10.36.132.253]) by relay.smtp-ext.broadcom.com (Postfix) with ESMTP id CBF2DC0000EA; Wed, 7 Feb 2024 12:24:19 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com CBF2DC0000EA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1707337459; bh=SEUbGpLY/kY+cXDOt4nGhWXvuLxy9O4W4aujYHBLgx4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZIPVbQpSX+4Q7HG6G31j2tj52V5Arp1KquoQWdsWog6U5WWgkqi3EuS9Mb/mfm/vG iupk/k2CeHLXY/uNw7oSFDFmxis6bDppBvoExe0bmXBT+N5/i7Qn9vW2LW7esNO+9E FaBYjVXDts+CWijp8FMkWVhw49fT3YEFF79dJKEA= Received: from bcacpedev-irv-3.lvn.broadcom.net (bcacpedev-irv-3.lvn.broadcom.net [10.173.232.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail-lvn-it-01.lvn.broadcom.net (Postfix) with ESMTPSA id 3286918041CAC4; Wed, 7 Feb 2024 12:24:18 -0800 (PST) From: William Zhang To: Linux MTD List , Linux ARM List , Broadcom Kernel List Cc: f.fainelli@gmail.com, kursad.oney@broadcom.com, joel.peshkin@broadcom.com, anand.gore@broadcom.com, dregan@mail.com, kamal.dasu@broadcom.com, tomer.yacoby@broadcom.com, dan.beygelman@broadcom.com, David Regan , William Zhang , Miquel Raynal , linux-kernel@vger.kernel.org, Vignesh Raghavendra , Brian Norris , Richard Weinberger Subject: [PATCH v5 12/12] mtd: rawnand: brcmnand: update log level messages Date: Wed, 7 Feb 2024 12:22:57 -0800 Message-Id: <20240207202257.271784-13-william.zhang@broadcom.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20240207202257.271784-1-william.zhang@broadcom.com> References: <20240207202257.271784-1-william.zhang@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790278171777673727 X-GMAIL-MSGID: 1790278171777673727 From: David Regan Update log level messages so that more critical messages can be logged to console and help the troubleshooting with field devices. Signed-off-by: David Regan Signed-off-by: William Zhang Reviewed-by: William Zhang --- Changes in v5: - Update the commit message Changes in v4: - Revert the log level change for correctable ecc error Changes in v3: None Changes in v2: - Added to patch series drivers/mtd/nand/raw/brcmnand/brcmnand.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c index 7ce2b267676f..e50582b45182 100644 --- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c +++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c @@ -1143,7 +1143,7 @@ static int bcmnand_ctrl_poll_status(struct brcmnand_host *host, if ((val & mask) == expected_val) return 0; - dev_warn(ctrl->dev, "timeout on status poll (expected %x got %x)\n", + dev_err(ctrl->dev, "timeout on status poll (expected %x got %x)\n", expected_val, val & mask); return -ETIMEDOUT; @@ -2196,7 +2196,7 @@ static int brcmnand_read(struct mtd_info *mtd, struct nand_chip *chip, return err; } - dev_dbg(ctrl->dev, "uncorrectable error at 0x%llx\n", + dev_err(ctrl->dev, "uncorrectable error at 0x%llx\n", (unsigned long long)err_addr); mtd->ecc_stats.failed++; /* NAND layer expects zero on ECC errors */