From patchwork Wed Feb 7 16:36:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Max Staudt X-Patchwork-Id: 197984 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp2356787dyb; Wed, 7 Feb 2024 08:42:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IHb7DWlKkKDVZ6Xu9MQ3rLp83QaS3NrCugA3gnJ4LS+WKtkG2qMXnoVwyKPkkkpDIXMe62e X-Received: by 2002:a05:6871:6a3:b0:218:f001:10bf with SMTP id l35-20020a05687106a300b00218f00110bfmr6373496oao.35.1707324133776; Wed, 07 Feb 2024 08:42:13 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707324133; cv=pass; d=google.com; s=arc-20160816; b=SZ63rj/Mr3jX92q2c8TtvUR/1u/PTa/w9sysYJdaxQ3hmjlAlvhl6BXmft/XkqzxPF m+C198LY7Lm44tx6fyB0/vpVMOI93SszdYXx3eO0/j4byVo41AdCt9neXhYjPVMBCXKc G1p5n6wIRQS8vKORZCpoO8+dkgO2XxOZ48MGl9KW/50sTU+SofitFsRTX8oRlIOCQXOJ unHySlJ5QeyKlJqhhkfRe1IZz3GWq/4FOPbYBXw2DgeFuoyQdmkT/gJzADfKQc3a69Qp wbUgj8va5tvwjWL6mMFgwnpYh+Lt7HKAPQOQLcMnj3a1gJMCLuitm0DLzOw8IojI4NNj sOdw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=9XoQ1cGEBVAP26sn/kYXSlqM2SvncsCnA71ZRUcS508=; fh=VolOH7Q0DxjqppVVUAaJqWsvlSks59L0hqly6sfDc9M=; b=epxGkTl7mdP2XlMHVGrFKlh5DlfJj7/03mklg+Njb4lmQATXatbs/P8SXoUEcalXmn a/8isa2Ts5lIQk8LlFH/T9QXMH/0uUjwAuNcJ8nj7OF5kXPjWZADN+E3T6y8Rq2Qanb+ URY7qyQNakQyhPiGnfClT6pbj/tzf082ymAQdBKiKGOgZuH6guohGmBrlVICifo6zq5j ctuYt5DX8INNPndAa/TbpQ8MAVEj9mveBl640Z2Ngvo3XgiiyMbv+CWxG/VQmPjt9qfr rweXWYDUAVqYE52qseHogVlcv/7CwsXo7w0mHxTASNs6Mw9ndvMeLCQR4rAtqiImNWTw JI7w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=enpas.org); spf=pass (google.com: domain of linux-kernel+bounces-56780-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56780-ouuuleilei=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=2; AJvYcCVoSG/CSPDturiSxAwc0ueMbOmwHldstF8V+FDT0ePfgPw0FGK3Jx+VGVOj5tF2rU8jfHCTRw2Mq0Usr4QFLRxLfHkskg== Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id j62-20020a638b41000000b005ce016cce21si1773084pge.191.2024.02.07.08.42.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 08:42:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-56780-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=enpas.org); spf=pass (google.com: domain of linux-kernel+bounces-56780-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56780-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 37B17B28C2B for ; Wed, 7 Feb 2024 16:38:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C745082D68; Wed, 7 Feb 2024 16:37:44 +0000 (UTC) Received: from mail.enpas.org (zhong.enpas.org [46.38.239.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E045823BF; Wed, 7 Feb 2024 16:37:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.38.239.100 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707323863; cv=none; b=iZ6IJItjKGV+Xkema5l8n5dq/GfxxZ/4JKY55dO5/bjdaXDD3DxWP2hwKuXHsb0brkRUPKFyCPA3Re+Hbkp5TeOzEl3WBOHNkM/dzA1DIUVp5m2zUzmz7iBkdCNlSFiNry7KT6CXR+XcW8X3zy5EqsXVzXzpaOZ40k/FKmrEDBs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707323863; c=relaxed/simple; bh=lOHItdgJbiCuF+QTQQRRcLdSwBfpIamrEpzDEwqonUA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=fuqZhe5xJt33j/2XwLLNQbN3yP+jCMIv2PXs1jAPoe3/CR8vVGtHVuKZHdjGqYiWwiB1fwOUe7w3fx69qRWTJhvfpmODtRShQyUCICOp3ofvkZxiEwAETPBMgdqSdAcawhb8pz7JSM5uz3QvpgRztXAbmD4ExkkA5YdVsLLt8+0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=enpas.org; spf=pass smtp.mailfrom=enpas.org; arc=none smtp.client-ip=46.38.239.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=enpas.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=enpas.org Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail.enpas.org (Postfix) with ESMTPSA id C04F7100BB9; Wed, 7 Feb 2024 16:37:31 +0000 (UTC) From: Max Staudt To: Roderick Colenbrander , Jiri Kosina , Benjamin Tissoires Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, max@enpas.org Subject: [PATCH v2 2/5] HID: playstation: DS4: Don't fail on FW/HW version request Date: Thu, 8 Feb 2024 01:36:44 +0900 Message-Id: <20240207163647.15792-3-max@enpas.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240207163647.15792-1-max@enpas.org> References: <20240207163647.15792-1-max@enpas.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790259111002221133 X-GMAIL-MSGID: 1790259111002221133 Some third-party controllers can't report firmware/hardware version. Unlike for the DualSense, the driver does not use these values for anything in the DualShock 4 case, but merely exposes them via sysfs. They will simply be 0x0. Signed-off-by: Max Staudt --- drivers/hid/hid-playstation.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid-playstation.c b/drivers/hid/hid-playstation.c index 7f50e13601f0..df50ca4dab90 100644 --- a/drivers/hid/hid-playstation.c +++ b/drivers/hid/hid-playstation.c @@ -2558,8 +2558,8 @@ static struct ps_device *dualshock4_create(struct hid_device *hdev) ret = dualshock4_get_firmware_info(ds4); if (ret) { - hid_err(hdev, "Failed to get firmware info from DualShock4\n"); - return ERR_PTR(ret); + hid_warn(hdev, "Failed to get firmware info from DualShock4\n"); + hid_warn(hdev, "HW/FW version data in sysfs will be invalid.\n"); } ret = ps_devices_list_add(ps_dev);