Message ID | 20240207145307.1626009-6-angelogioacchino.delregno@collabora.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-56664-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp2282348dyb; Wed, 7 Feb 2024 06:54:49 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCV0foGXlbxhEpivNfwBPKWUjSxiaZS23FPqhqnOHVmvQp5ylEpMYw5jpqa3Ehay4BLsKBWKMR/trIUDWl4ziNDyQe/atA== X-Google-Smtp-Source: AGHT+IFv/Bbh7hBEsFtf4WfDEZQmVLrgt2NVVWW0G/9+fVRTXRUOzebeOSPTDXv9bhKQYVxunN4/ X-Received: by 2002:a05:6102:1609:b0:46d:387e:8499 with SMTP id cu9-20020a056102160900b0046d387e8499mr3313207vsb.4.1707317689176; Wed, 07 Feb 2024 06:54:49 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707317689; cv=pass; d=google.com; s=arc-20160816; b=uiCG34CDLFUMfF6a5t8467DZMh5+R//+kn8pGW8Y/bjk8TBVYv/O094VS73egih2hu KI6JD2fArftXTPiaSE1kdEfdKXCThaSrCIuadr9/Nx3ExWPrUgRoSuZ4qNDznkoQUUNJ erhZGayu88nk1NjDkAvjvtA6EQwBbes/+CV/E32t+LnbZBWGuUZatqolFMZpHolv6qlJ LfOC4TTqkGGDa+nDIbLVezC5yU2RnoxAn2gb7W7N+UOdiSpmC118c8bzVsXKEb/t3OEM Fb1UilQw4oNo/cosY1x/VsvglUF8Q6tzF0W7qT2kwsjL5YNlMApe278ygmn10zlFuSIn rOxQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=/JogCYJM62udzVwF90i+MXqQdcdBnCXj8P/xacH64kU=; fh=9/AGdyLg/veRpLKgHGMYhgs3Z2G1aqLKN7RCDvH4GQY=; b=E66CMgdyE5USgZLpxIQluuD0ciPRRn6v84TvnkEJbPJTzmLUGenJdrv2WfDNMOMh3q LUlVqPhw2eKbALIpoANLXrsUrgoI6t58dn8jQ7BKp6LsKFHH44vHONciwbOkZHmnek4j FImMWNXjYPbVMvi2N/57LEKOohcH8LHkMQSwiUM4HTTkfyco3ItOjS4NxC3j1KPDZzGT 72oldrDQ9vyMzaObU3IFunwaB+WmHVOPcJ/0Bswy+zVJJGUjy6dWNM8I+dEsYNJnEFv9 UN2NPAGn2mlvidiKhGUTUKIyo6AgJCjJWLUaKW0y+14jm9bKL4ipWfLuPCvQfHD70TVB RNZw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=quFidrzv; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-56664-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56664-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com X-Forwarded-Encrypted: i=2; AJvYcCXwbFa1Hhju/2HsX/SvBCkiT+d4ZbNeuurohm3sSzGJovApc7tpaDKpG5LKlg8x+Fdkex409MA4JD8D60sMnYDDoGHErQ== Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id w19-20020a0562140b3300b0068cbad9bb85si1187886qvj.490.2024.02.07.06.54.48 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 06:54:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-56664-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=quFidrzv; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-56664-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56664-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id C70431C25562 for <ouuuleilei@gmail.com>; Wed, 7 Feb 2024 14:54:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AA2848063B; Wed, 7 Feb 2024 14:53:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="quFidrzv" Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B1CA7FBA2 for <linux-kernel@vger.kernel.org>; Wed, 7 Feb 2024 14:53:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707317602; cv=none; b=NYEujJQum5+JV+NdCSUaNZTLTh3YOGLqin4IihvSRXlcZSNGk9chMk0yPDFzZHAwrLptaCSoWugjzca9oXG0stytMzp8FGTAfFRlmyWWttL+6OPwNK6oV1/TI+CIOkMjySm6v7uezCwwT8iiZsm8Kmw9FDY5NtwHsIBl5Sel4mM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707317602; c=relaxed/simple; bh=FiS8mUqacAQe89zDNq0f1XThl37jG415BRlGEjthz3s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ip3DlXOMzTAnb1gMmsbtM9XdXjMW/HyO9CmCkPzfGq1vd/MitR6pD+DoPhxPuA6LkR5JdSc87G5qUuNJKVyvHk7yibS6DXaB+yAub1PJWs1X6a/LgPsBFGrqsS9fYaMfx66Xf07DvWrXGOxSe4t4i0Y8jLWxHkg+T1aZOc+h15I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=quFidrzv; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1707317599; bh=FiS8mUqacAQe89zDNq0f1XThl37jG415BRlGEjthz3s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=quFidrzvgOMNyNGO8uk50aUtnYd/jjBrVroNsjFupIrKXJjidt4USkkWePzqEfV3z uaWkKcZGWbrWcijUHy5OBKbH8Kz+xByeHUd/Plb51UVr77D75e/eZ5OKIArE6yhmbW pEwB0wapDN2Y0SYh9pmiGvQi9Cmia/Xe6BoKq0rfagkSuux1xyb4yxk7bxJc4ohI/o U1Bc5EA5vSuWqrY7bN6N7mkkf2VX9iEQnGvlLXPY6ZfH7PLjbqhlep4emvb1z/cPYM DwyOxAjh/YIgf7qlWuJlt4huPJVrDpZbLGQIqHBDpadlHmUs36VUth9KJR75b/LcOo 23ci/V5sLA3fA== Received: from IcarusMOD.eternityproject.eu (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id E3A35378207B; Wed, 7 Feb 2024 14:53:18 +0000 (UTC) From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> To: chunkuang.hu@kernel.org Cc: fshao@chromium.org, p.zabel@pengutronix.de, airlied@gmail.com, daniel@ffwll.ch, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@collabora.com, Alexandre Mergnat <amergnat@baylibre.com> Subject: [PATCH v5 5/9] drm/mediatek: dsi: Replace open-coded instance of HZ_PER_MHZ Date: Wed, 7 Feb 2024 15:53:03 +0100 Message-ID: <20240207145307.1626009-6-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240207145307.1626009-1-angelogioacchino.delregno@collabora.com> References: <20240207145307.1626009-1-angelogioacchino.delregno@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790252353372690451 X-GMAIL-MSGID: 1790252353372690451 |
Series |
MediaTek DRM - DSI driver cleanups
|
|
Commit Message
AngeloGioacchino Del Regno
Feb. 7, 2024, 2:53 p.m. UTC
In mtk_dsi_phy_timconfig(), we're dividing the `data_rate` variable, expressed in Hz to retrieve a value in MHz: instead of open-coding, use the HZ_PER_MHZ definition, available in linux/units.h. Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- drivers/gpu/drm/mediatek/mtk_dsi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Comments
Hi, Angelo: On Wed, 2024-02-07 at 15:53 +0100, AngeloGioacchino Del Regno wrote: > In mtk_dsi_phy_timconfig(), we're dividing the `data_rate` variable, > expressed in Hz to retrieve a value in MHz: instead of open-coding, > use the HZ_PER_MHZ definition, available in linux/units.h. Reviewed-by: CK Hu <ck.hu@mediatek.com> > > Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com> > Signed-off-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c > b/drivers/gpu/drm/mediatek/mtk_dsi.c > index a330bb94c44a..52758cab0abf 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -13,6 +13,7 @@ > #include <linux/phy/phy.h> > #include <linux/platform_device.h> > #include <linux/reset.h> > +#include <linux/units.h> > > #include <video/mipi_display.h> > #include <video/videomode.h> > @@ -238,7 +239,7 @@ static void mtk_dsi_mask(struct mtk_dsi *dsi, u32 > offset, u32 mask, u32 data) > static void mtk_dsi_phy_timconfig(struct mtk_dsi *dsi) > { > u32 timcon0, timcon1, timcon2, timcon3; > - u32 data_rate_mhz = DIV_ROUND_UP(dsi->data_rate, 1000000); > + u32 data_rate_mhz = DIV_ROUND_UP(dsi->data_rate, HZ_PER_MHZ); > struct mtk_phy_timing *timing = &dsi->phy_timing; > > timing->lpx = (60 * data_rate_mhz / (8 * 1000)) + 1;
diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index a330bb94c44a..52758cab0abf 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -13,6 +13,7 @@ #include <linux/phy/phy.h> #include <linux/platform_device.h> #include <linux/reset.h> +#include <linux/units.h> #include <video/mipi_display.h> #include <video/videomode.h> @@ -238,7 +239,7 @@ static void mtk_dsi_mask(struct mtk_dsi *dsi, u32 offset, u32 mask, u32 data) static void mtk_dsi_phy_timconfig(struct mtk_dsi *dsi) { u32 timcon0, timcon1, timcon2, timcon3; - u32 data_rate_mhz = DIV_ROUND_UP(dsi->data_rate, 1000000); + u32 data_rate_mhz = DIV_ROUND_UP(dsi->data_rate, HZ_PER_MHZ); struct mtk_phy_timing *timing = &dsi->phy_timing; timing->lpx = (60 * data_rate_mhz / (8 * 1000)) + 1;