From patchwork Wed Feb 7 12:04:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 197867 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp2178233dyb; Wed, 7 Feb 2024 04:07:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IHCsdCagwRlc5P5yNY6NS9ugyctYZFtPooY8uWlf4V0Dw5qTJpBqcvYNKpmxLAeBX8iq9+o X-Received: by 2002:a05:6808:6548:b0:3bd:f05f:c847 with SMTP id fn8-20020a056808654800b003bdf05fc847mr5808997oib.59.1707307644535; Wed, 07 Feb 2024 04:07:24 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707307644; cv=pass; d=google.com; s=arc-20160816; b=zn6kWlF7DabU8SW6PkW6Pu0Z6PAycolA6EO/8z260sqxB/yfNwb1jto9T++MxR6HWm eQcp2CNuHy9wE7fENq4PWnhAQYMJ8Qe/3GLlEjqYw6umq5Q8TIJmua2fyq3eVpBV6jKT vpnXK6vO0s/usldiRMfnEl6tdFsDRSdVch/wfSJLEiO6VYU7Mw/uNcX50Q1etQlMO3fx qKOXBeXI7MmA5e0fGG11ZNcxYwAUE6Vgw97PBcj3JGuapIvRVNkUYgDg075+n0uOiPu4 MR+Ly+0d+4cJNNP3JrUvBZITClH5LbPR3lTUpdqg6UEkC+/0onLyarX69nbM8hHGID4c murQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=FVi6POW2wsm4t/zvRlXFF0rH5aMJzAofhX+zIRsv7I8=; fh=Lii0OQGkpGA8v+VyJELweOpttWClsWUdYODw7ha53Wo=; b=BxCa+LlQZ0AoAQhxtl13E22Qbwt9IJZ2HV8hgEtelyQt3tZOo3u38S2oqGt9hV3PMC kdso5jMHriZ+UEMD1gppvmgdLnGPw3VidebcRYyMDzP6H+LMuoe+PAcwpKJtzFPtK4vp NhJTXhNin1AH00z4MQj0dxkWb0g+bRjxG9lx9quhp2J4ONuy5J/k3xF1yE5t1G0pMCF2 7+VzWB31cKDq0C1GseoDSjrUs2bHe/UFQKB1BsQ24dxDFgCsoRrVDv6cphMDyC79o9dk 5hBjLJjUQGPgB+Vsbh0JA76BV98HQa5+KOVf7rDSXv7tpRB8chsm5KuAITAG6mhH83Yh BmtA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WEzeKvAi; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-56444-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56444-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org X-Forwarded-Encrypted: i=2; AJvYcCXUNRTUeN1s5LSW3LlZj6Jp/YKgtNKAo2Im1rl+pHjIhaM3+6KTmw0rnq/EA6jlfypQntrhiuxR6xrCzQn26fkVMI/NIQ== Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id s19-20020a05620a29d300b0078396013dcasi983723qkp.374.2024.02.07.04.07.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:07:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-56444-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WEzeKvAi; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-56444-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56444-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 4372C1C214CA for ; Wed, 7 Feb 2024 12:07:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9ED995CDC2; Wed, 7 Feb 2024 12:04:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WEzeKvAi" Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 903193C6BF for ; Wed, 7 Feb 2024 12:04:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307492; cv=none; b=HEUbfu03YGOYAnpVsC3RVShULGN38VRuECl9ONOo1Jf3Bd3lag5FakUOccWRr5uCtZbZILvEQNqgCOSOU/kQN0Sr1tgdhf5mko9CDxje4SM0T3HcRNwxC9DOgkHft6KBIPLeZ46wuhWfzUkSlUQIQmCOy+zRNDWCJtcFoB5WtxI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307492; c=relaxed/simple; bh=tcvkG3IuArguTBs5+oJ4pHS+pBXtBmiVEQi3ZFzSJVw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eIGo2iAiHGp/ngpFCJv1yS9K7S3QBo93ZuWHYcnpX0fYzqJ6/3xjQ7UX2dIhqCyltgElkNbm0BIRlYTscr/mi5YzbYmEGdqyNyex97QZeZuZdisM5QQCbFgHRozNZgSTQrzKHDy5ndx6O/f28KwqAHOpnjptvq/blLSMKcqMqh4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=WEzeKvAi; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-33aea66a31cso347825f8f.1 for ; Wed, 07 Feb 2024 04:04:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707307485; x=1707912285; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FVi6POW2wsm4t/zvRlXFF0rH5aMJzAofhX+zIRsv7I8=; b=WEzeKvAiBYJ11nViHOd83qD6En8/8FvY/Lrt7E6VmP5kHWpJWAiPNteXf781b8Z0KN M4I2rLgW5y6J/6Fvt1anoT6ljNBAGFy7jYVAh9efx0mz9x10C6m1FLCzEYWrN6oYHMAA EhdzIqLCU/Y3FoeDJaqB0nlXtMEcF4Nxyw6qVyVVzeesbhr0C/W01UiUZ+5M7SpAnY52 TaEfgEvb+yGxuZvbGpj2Yk7eF3RkcNq7Wmg+rwif7ubLxstwLpBwvppRMZ4QJ9eYNltx G83rR9UcTw0ZV99b1Q9zVLZ8951tyKOJgiKnY+CoszvUWLkVCeX1QXThYziM48Wvi8SJ wB0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707307485; x=1707912285; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FVi6POW2wsm4t/zvRlXFF0rH5aMJzAofhX+zIRsv7I8=; b=pLca3Xnxi/sNiCzUszKORjyp/kKVEuRYBws6rvRsO/pHpfRM+UMBjfIPK5x9iGwolI AiFUUPuIXn3T4BPY21bkLpLRgsZ0xeUkXI18Ej4J0YIRx9JVgmCWyahU+B/BBZlZPkeT 8isfMA+4CGWXhMsIOE3cQ+OUvHUudb/pyhBUp9zt3+OMy1H80BJn24ApNzJCHDkjQyjo 45GBLSB50pCzSYzXGnnaMrj/soEg2AgUHkOac2mbXJHx+tCkMHyi20W7ijAu0lEyPLWK gYf9sAAK9BG2zvjlPypNcKGBR0fy7Xlzn2KtKreHgj/CFY98v7L5cq4Vdc6zA5TOKyUI ctgw== X-Gm-Message-State: AOJu0Yz+uuPvFEUrNpBVpHHNNaUYl5uJFcKQ3TJoiDEN5G3n8OOt2J3Q yfOZ21j2+Xq6zFBra9PeEojz7XyrtwrmZSoico+M7ktBLaxgxvwNRMnj78BlZhpLmFA8BWZlc7T Opu8= X-Received: by 2002:a5d:4607:0:b0:33b:470b:a377 with SMTP id t7-20020a5d4607000000b0033b470ba377mr3299506wrq.14.1707307485006; Wed, 07 Feb 2024 04:04:45 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXi65c/JIRFTcB5no6O1BT/UfOn7r6G5SsTR4Z1TpJ0xLXYSEO2dQ8pmguXkT9/GofcRmzGYPdz0fLqHy9WI4a9XJLu3ZnH2Y9FhQi4PDPTefydw/FXp0JQtGr82udzshBWEwHTq/ukZqEGmTgQDxXgZKKcMQz4293qjEAvXeXRXEjw+2LJFJFzkMCAjUPIy2EwFnSSn1Rcf3TD4M9DSGgPluoqPt7AOM3bC8R3yqBTqe257ajA3dLN+Nb9xI1RvZ3e8jl5a0QbUHAU/4cqLTRo9wqmHEMMeE+sp293eRNHt+Pb26Q9/k8suUDvadfCyMwnnfIlezqEhf5mn+b0C9ciQO/h6jcD6zZICEw8NhICH3JYbAJvPF2oW3veyX2zvgE2xfCgHAsF58hu8iAECJH5ek3RQOAwpxUnoez02e0fHyx6RJVrC5Ol2XZ5DCo6HWiI/P7Q+Y7q+ObowYJyZv0UtKdvVf1kNWBr9zFS+g9ndwPxU+PgHm2AjDBBYQ== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id d15-20020a5d644f000000b0033b44a349e1sm1349967wrw.38.2024.02.07.04.04.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:04:44 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v5 08/17] spi: s3c64xx: remove else after return Date: Wed, 7 Feb 2024 12:04:22 +0000 Message-ID: <20240207120431.2766269-9-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240207120431.2766269-1-tudor.ambarus@linaro.org> References: <20240207120431.2766269-1-tudor.ambarus@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790241820838121646 X-GMAIL-MSGID: 1790241820838121646 Else case is not needed after a return, remove it. Reviewed-by: Andi Shyti Reviewed-by: Sam Protsenko Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index e3e7d625f3fe..0b42d28d2019 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -410,12 +410,10 @@ static bool s3c64xx_spi_can_dma(struct spi_controller *host, { struct s3c64xx_spi_driver_data *sdd = spi_controller_get_devdata(host); - if (sdd->rx_dma.ch && sdd->tx_dma.ch) { + if (sdd->rx_dma.ch && sdd->tx_dma.ch) return xfer->len > FIFO_DEPTH(sdd); - } else { - return false; - } + return false; } static void s3c64xx_iowrite8_32_rep(volatile void __iomem *addr,