From patchwork Wed Feb 7 12:04:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 197869 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp2178916dyb; Wed, 7 Feb 2024 04:08:25 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWbxGNEHS8aKh5+W2kf7KOWVwEph3B/7BINbwdFyLxC8xSknH7DK0DrvG3v0mC8tcGtoIM2ceFWjE0cCtlHip8yXJ+9eQ== X-Google-Smtp-Source: AGHT+IGod6fJsTkioUCpeLcwz6u/wK0Zncw22tsTO36uTSEJiPa62DLnX38WaONyZe+Ids2snY+t X-Received: by 2002:a05:620a:4085:b0:785:8c13:bfec with SMTP id f5-20020a05620a408500b007858c13bfecmr6690901qko.43.1707307705338; Wed, 07 Feb 2024 04:08:25 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707307705; cv=pass; d=google.com; s=arc-20160816; b=s1//NM/WoJe705CdzUhOPAn7Z8NCa146E9/Cv1S/In3rftRgEMXar5EKibkfh1xcCQ ne0hlLqcnngWSTiSvHJ+I+zJACgb6r+N9L332zwUG28DlMW9hiZP7vwLYdCvnw7UuRbM RA3oqZA08gfIA6OpMha9a0TwzbsJ5GTBwfQzNBb+jKQfXs0QJOEQ2hk/PCumtN0EBM6w grsVUpwxeIcFyUq4or02ONzY2XzPT2Ndfbker5JQ18ImPtcJWGHgcWIuD9FG42EDJckX mWXij6f7/CqXzqkk9ARXFPIsJqYU+pEKj8aYIxHFoVPlhm5qFHl8XD7A+jbrN1LC/8Kn 5cig== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=QyB/rIEWzg0qFsjqRP7XGwF0lM74d/iwYjphW748AMs=; fh=zxGkrPRFGsRzee2GG57A83cwLrJbiP7SI7qHLm+AosE=; b=HsU6IbMKu22czHShFyn54jigb1Y/Vb60NtLsgKyfCi7K1sjd2IAXbR3TlRaeUU379S +Us94kiCYt9CQAC3XPojVLTCgW5jIdrsOk6sUEpRMbyUnMVN15FsLiA2xBFfXXU/OgM0 l7NLgqVc9uJhJZDKAu2g8YjAqRD/L1XapFk5Vb/pHPimaiOTEFbG9ZmT2rsjlL+5jDV+ s6R97cjHkWFwNNDyVl10u5qD4vuynEVz3YVSxU0yyB4cfzR2hdjtr7B/9jZIRbOh/mY6 3MN+KwYHa6L5ptulBpe/EJqDL0ZS6X4vJfyw+bmOFVGGAKWPv0U3EJBmEJ1Xkk70SDgM +8hg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zHC9BZ2V; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-56450-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56450-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org X-Forwarded-Encrypted: i=2; AJvYcCUEr2e9Ru6lnWsCeHuspexPbgSnU2evtVfZRvszGkH2Mu1cFopIRm9h6MXw7x7NMXzR34drSuNbbBGCZtm6SmDMs3MKMg== Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id s19-20020a05620a29d300b0078396013dcasi983723qkp.374.2024.02.07.04.08.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:08:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-56450-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zHC9BZ2V; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-56450-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56450-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 262991C22C91 for ; Wed, 7 Feb 2024 12:08:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B72FB5F47C; Wed, 7 Feb 2024 12:04:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zHC9BZ2V" Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FAE75A7AA for ; Wed, 7 Feb 2024 12:04:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307495; cv=none; b=tXq6NFnm1gyb7A0DnV/2GB/a7+4okKM7sQGbmCikDfYMqguZ7vCzmfwAk9fm2Bg+u8UV4swoE3uhsnGzHWEfNI/XIofYrw5TfjimuI5MD8vsHO93tCHuw4hfiN0t5/m0kLirS34t6YWbNFNBJ2m3wLsMyUlH3ncx5/mRnIaoaqw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307495; c=relaxed/simple; bh=UUTdIh3Xj1RnoDrVpRDf7wnRZi1N2KMZYs/hAqRGeLE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iUOXIdJIx7lfnlLw7D72gIO4OUddRkovK1O/+5MOLuNgoLGyD5h54JwOMfMQ02CeW2YnuFQ9Tzk+nuXz8GSlQUO7WKJ5N59lWqWr5RMNA0NmoOjPaprjX3T/KZjXd8MHZ7JzfFdvjTnjVBTkEX0fmOKNHVvU2XyUzzL7Q3XdmIs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=zHC9BZ2V; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-33b45e8a670so325565f8f.3 for ; Wed, 07 Feb 2024 04:04:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707307489; x=1707912289; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QyB/rIEWzg0qFsjqRP7XGwF0lM74d/iwYjphW748AMs=; b=zHC9BZ2VYIAuvCjT7sGQrvpL5XP0IlBLVfn+E3qKoNvV0C0ItjsMO1huR7mlFp4AWM xKhR7vsFeoVDOo5Sq6VVE/YAPtl6mwcQ+SiJ6HEbh1np9Cody/ChjoygE7mKI0CUfKvL DWjBbhSuZS1ywJJH1UwWerJEd89cWx5JtZ9wmJ20Sh/D+UOfLcIi5IEoFazw1ydR8zea 1v6QZYGrU6LnH2lOBJLJz1Cx+FQmruUAhvzgLTIFbWhLl4vESbbyEzkIkeKv6BvLA5ny lJMtOGzWSWZjd2gGlUlFZv71ttPkcWnb2G9JtWjVcE/Rspq/w1sc6Ora+w7z+0BpXqwD tRxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707307489; x=1707912289; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QyB/rIEWzg0qFsjqRP7XGwF0lM74d/iwYjphW748AMs=; b=jUYMHyjqD0BhCTrMPFgDcGbiyjGn+tPD8fh5SAfMbvTjuN61bBgrDup24jVjHRaWIU LF2P0e9jU5sRVzBlf1YfF0EYkLWKpbywwNWSKAfSxqRIANx9Bms4AP0XWNYQ7NOq/skm UD0Phyj5oTYIrFMmMHSnUw6lE7aYHcYNd4LlGm7vvIWY+XV7lCyFLhI008DwXiVS/486 NK1VxTA3g2miwmO0+fdxYv0CJSdL9do9jTUNmG4NHC0mgMdjxaaZU64GgTc5/M7RBVdW H/b8fgYIFGZGIsrP2wiZPbE5PcIR1NUj/iXhxUQHvtSQH787UhFcCpNsAOCwPw3qDv4E yiQQ== X-Forwarded-Encrypted: i=1; AJvYcCW+VJiwd7wFmC6noJnv0FBULpkpEwHYZFlC6Ag1Vag/ssiChHuQTthboVW9a9eGemK/fA4wEJOxSMShl15Y7OSG/IMGQekA93d9ekkS X-Gm-Message-State: AOJu0YynEZx6FMwlAyWHUMd7tQFIyggm0j9i4fnnfeKAzplGnoqZwI7J 2IMr1ywGUSRz5EEZZpJmcnPFdBL1NGscV/SIG5+DvOrzbw8dLsyJV84CWVcDw7g= X-Received: by 2002:a5d:6989:0:b0:33b:1ae4:10be with SMTP id g9-20020a5d6989000000b0033b1ae410bemr3112553wru.46.1707307488917; Wed, 07 Feb 2024 04:04:48 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWPoi9waljrhcc9Du9f7ChdJiFb7bX6DdMzhB6TZiVx1S6gG/nPe729BwNqPKcVyZuuPdA0jWoPjSZwBlPwgoGv4/+7VcutaOWWT7HZ/3E8KzjuD0LOtpjL0KJJBvdcnNnl7DjKH9MgkFM+oOQxMagBpYbUSNp+A0jDqH8NN2oxDXjkv9Czp7X62NXW5WDOIraHpUkXlQrhFTumVMhvNi2/fuvQOmrhzuwXTN5b0Xg+BD8zux/iMilXXTbwuTHqAP03e4h0gtwf0TXw8YZnH5aDaUAcLltEVIOw3dI8iuambt30B7iLPUkTQcl5whcPC6+OBnzA0glExTxAon0OgcvfTnCNygZplHw+HOEJkdkfLPNEFmao4a8VIZQiPLVaARwFsy4ppTJHvaD9+xssFBf4zYZUcC60X4vqjIWfKWGON6SA6CBFPOQg56CTSps8XueWb71vVnuDitaohl0PNzBRtFUQfoQZtyrmFl5+hfaKawwtkHi2Hh19s739xw== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id d15-20020a5d644f000000b0033b44a349e1sm1349967wrw.38.2024.02.07.04.04.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:04:47 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v5 11/17] spi: s3c64xx: propagate the dma_submit_error() error code Date: Wed, 7 Feb 2024 12:04:25 +0000 Message-ID: <20240207120431.2766269-12-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240207120431.2766269-1-tudor.ambarus@linaro.org> References: <20240207120431.2766269-1-tudor.ambarus@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790241884109158987 X-GMAIL-MSGID: 1790241884109158987 DMA submit should just add the dma descriptor to a queue, without firing it. EIO is misleading and hides what happens in DMA. Propagate the dma_submit_error() error code, don't overwrite it. Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 1f7356f6e5d2..ba17c5a04eef 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -324,7 +324,7 @@ static int prepare_dma(struct s3c64xx_spi_dma_data *dma, ret = dma_submit_error(dma->cookie); if (ret) { dev_err(&sdd->pdev->dev, "DMA submission failed"); - return -EIO; + return ret; } dma_async_issue_pending(dma->ch);