[v3,4/4] ARM: configs: at91: Enable LVDS serializer support

Message ID 20240207102802.200220-5-dharma.b@microchip.com
State New
Headers
Series LVDS Controller Support for SAM9X75 SoC |

Commit Message

Dharma Balasubiramani Feb. 7, 2024, 10:28 a.m. UTC
  Enable LVDS serializer support for display pipeline.

Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
Acked-by: Hari Prasath Gujulan Elango <hari.prasathge@microchip.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
---
Changelog
v2 -> v3
- No Changes.
---
 arch/arm/configs/at91_dt_defconfig | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Krzysztof Kozlowski Feb. 20, 2024, 8:45 a.m. UTC | #1
On 07/02/2024 11:28, Dharma Balasubiramani wrote:
> Enable LVDS serializer support for display pipeline.
> 
> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
> Acked-by: Hari Prasath Gujulan Elango <hari.prasathge@microchip.com>
> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> ---
> Changelog
> v2 -> v3
> - No Changes.
> ---

In other email thread you mentioned that this depends on driver changes,
while that's only partially correct. This patch does not make sense if
others are not accepted, but the others are not dependency for this one.
This should go via arm soc.

In the future, please state clearly dependencies in cover letter or each
patch changelog (so ---, not commit msg).

Best regards,
Krzysztof
  
Dharma Balasubiramani Feb. 20, 2024, 8:50 a.m. UTC | #2
Hi Krzysztof,

On 20/02/24 2:15 pm, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On 07/02/2024 11:28, Dharma Balasubiramani wrote:
>> Enable LVDS serializer support for display pipeline.
>>
>> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
>> Acked-by: Hari Prasath Gujulan Elango <hari.prasathge@microchip.com>
>> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
>> ---
>> Changelog
>> v2 -> v3
>> - No Changes.
>> ---
> 
> In other email thread you mentioned that this depends on driver changes,
> while that's only partially correct. This patch does not make sense if
> others are not accepted, but the others are not dependency for this one.
> This should go via arm soc.
> 
> In the future, please state clearly dependencies in cover letter or each
> patch changelog (so ---, not commit msg).

Understood, Thanks for the comprehensive explanation. I will take care 
of this in future.

> 
> Best regards,
> Krzysztof
> 

-- 
With Best Regards,
Dharma B.
  

Patch

diff --git a/arch/arm/configs/at91_dt_defconfig b/arch/arm/configs/at91_dt_defconfig
index 71b5acc78187..6a7714beb099 100644
--- a/arch/arm/configs/at91_dt_defconfig
+++ b/arch/arm/configs/at91_dt_defconfig
@@ -143,6 +143,7 @@  CONFIG_VIDEO_OV2640=m
 CONFIG_VIDEO_OV7740=m
 CONFIG_DRM=y
 CONFIG_DRM_ATMEL_HLCDC=y
+CONFIG_DRM_MICROCHIP_LVDS_SERIALIZER=y
 CONFIG_DRM_PANEL_SIMPLE=y
 CONFIG_DRM_PANEL_EDP=y
 CONFIG_FB_ATMEL=y