From patchwork Wed Feb 7 03:47:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: alexs@kernel.org X-Patchwork-Id: 197723 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp1981390dyb; Tue, 6 Feb 2024 19:45:09 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXWChkVrnStXzUpSB96SpXi+dhNM7SS17QGgDiQ9csO0QQrJmIyQ7rMRBo8JBGiUYrQoVrJm592JW8dxvQTS0yNS9B5JQ== X-Google-Smtp-Source: AGHT+IFXgHitr5w90d9Msn///J0FH4VbeVO12uyyl6dibIfQyak8uC4ZkIXf+JQcj/LRdN+fkaEk X-Received: by 2002:a05:6a20:8f07:b0:19e:9dc4:522d with SMTP id b7-20020a056a208f0700b0019e9dc4522dmr2708593pzk.2.1707277509568; Tue, 06 Feb 2024 19:45:09 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707277509; cv=pass; d=google.com; s=arc-20160816; b=iK539b53MaZsIsNPnl2TozkEwBmeHpxojJgQ7TqxBJbyOdfilV+LUOp5aMtBZtwlei cyZH+pwTHDaHzgUVeKtX0x7XbHVjZWBRBHgPZIGmyu5PxDueSh6Ec4Hihy+gpsRl5zyU l72rkSbtHPzWaVLpaP6JFqRRuORNQGCgjk/fhHY+xwYQB7Gnrm4RbdNF2jbl0p30dZHO 8ZlaCijCf/MAlxs4muifB9mIPVaniuJEJGjyASLXJWCJFAw0rwnG51+tfL1cQQNxErRM PlkwWChom7oh5iUuhI+vcJv9msf/ONhfjIWwDqVWYuBFxJvrq/W6ja5UqeYs22YtNElB L62g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=hC+wTqBhmX1pbzHJm2ef3XAbHrltQyryPIKacY/kE18=; fh=LCmw56rM0E1npX/1TlTnP8S4vn7w7RBpAckxM7AGlxo=; b=vvI4rHEHeFSKg+IZzLtGsGZfluEZcNuP52HyuySm2nHEWvrDikG5BXgxM5yxGfOqXd TBwTmwn5KGiDIzZNW2tKcHm6kzzwriGdVzCwSxsDC90vIAHOf6rFM0pzbIYzac2yeXHV EguPQj5UbcXG1ZO5lhq2OusHHT6okRETzm2Sa98ikNHrk1HIiH3sJxW8MmL0E0dldv+7 gjMpObA257vmJfz5s/uO2bNMUvnbzV7ggRpDdYaHOqQf2uWRSZYRLxg5OouPG3H4Aim6 wfrbixginnttmCzu1GUFXIHx+BkEeFidNQVarkdWC13OlcmPu4LpDRtqa5AEZb6v18zw 9N2g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="snmTf/yo"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-55906-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55906-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCUyyW+5AqRVCy79NQ5gmMl0IPmnet9tAUMkfHwvDsSpMr3d/EyiDmBgPO0+9JjDSjU9c2D9CTPKin7uw4ZwsnsWoBFZOQ== Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id l12-20020a65680c000000b005dc35c340a1si151126pgt.9.2024.02.06.19.45.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 19:45:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-55906-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="snmTf/yo"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-55906-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55906-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id C7E0C286A12 for ; Wed, 7 Feb 2024 03:44:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1978E1BF3A; Wed, 7 Feb 2024 03:44:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="snmTf/yo" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63C6615E86 for ; Wed, 7 Feb 2024 03:44:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707277454; cv=none; b=HrDmD+ddv1tML/mGFrveXp6Jl2E43J/u4hG6AaYGKZIcCpDNCl3hXLmXTIN9Sn626mVeQS4cp/JzXxhD+d/8FrIRAU9D1fRFUIvILcaJUCvw3hpJbIbch+kqKYGEfNM4oJnv752jkSOyoPPTWxrl7zxVvvJY5GQHASc2ERfwZH4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707277454; c=relaxed/simple; bh=8blD+uBMrelaCyYwKVTuyE+VAFxDX4apKVm3xaEDk4Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=keudBAlMtGxwBFwZFGrsZ7ZthJ3GEprlqBzWIFIoqi2dEmMR4Abee2NrsxouMY9S19n1R/tNlGBL6qwZz/zNZCtmUIAmeuVjftGrgLMuOMlR3M5VT0DZhHvGvEAn8xuMtj3IZ3DdTeOXBsk3lscVOblKt4nDKPUVm3es38pUYXY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=snmTf/yo; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8F0BC43394; Wed, 7 Feb 2024 03:44:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707277453; bh=8blD+uBMrelaCyYwKVTuyE+VAFxDX4apKVm3xaEDk4Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=snmTf/yoiXRg69vxtX7HWuGaeYpHFH8rX2TAMaj1+FoxJ46nelr6wtU1GUAU0aOa3 8w1kNKdQjyes4Ej/qWfhAcADRJpkS3R179ZznsS5lsR+4uc4KFNewrP6EXgxKGVjor d0G94TZHis5V7bV6QfNGvsqYT0hzQf00b4dLjAR20IbPI2ocNeXIKqrBzzh1cuxh3M mNd9HcTmNNx+lgh+yDeW9/vIV4SQGPpkOXnsciyzbHnTJTfQ3qDyvUCFE83AoINlQh UO36mcMZY/2tC31RoJdN7ljPUxZAcWLcDTh/2e2Fc5K3gxMzkpfA6eB3P4V0vvIVvo rYizEE1JSLfVg== From: alexs@kernel.org To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Daniel Bristot de Oliveira , Valentin Schneider , linux-kernel@vger.kernel.org, ricardo.neri-calderon@linux.intel.com, yangyicong@hisilicon.com Cc: Alex Shi Subject: [PATCH v4 2/4] sched/fair: remove unused parameters Date: Wed, 7 Feb 2024 11:47:02 +0800 Message-ID: <20240207034704.935774-2-alexs@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240207034704.935774-1-alexs@kernel.org> References: <20240207034704.935774-1-alexs@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790210221660730550 X-GMAIL-MSGID: 1790210221660730550 From: Alex Shi sds isn't used in function sched_asym(), so remove it to cleanup code. Fixes: c9ca07886aaa ("sched/fair: Do not even the number of busy CPUs via asym_packing") Signed-off-by: Alex Shi Reviewed-by: Ricardo Neri To: Valentin Schneider To: Vincent Guittot To: Juri Lelli To: Peter Zijlstra To: Ingo Molnar Reviewed-by: Valentin Schneider --- kernel/sched/fair.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 533547e3c90a..607dc310b355 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -9749,7 +9749,6 @@ static bool sched_use_asym_prio(struct sched_domain *sd, int cpu) /** * sched_asym - Check if the destination CPU can do asym_packing load balance * @env: The load balancing environment - * @sds: Load-balancing data with statistics of the local group * @sgs: Load-balancing statistics of the candidate busiest group * @group: The candidate busiest group * @@ -9768,8 +9767,7 @@ static bool sched_use_asym_prio(struct sched_domain *sd, int cpu) * otherwise. */ static inline bool -sched_asym(struct lb_env *env, struct sd_lb_stats *sds, struct sg_lb_stats *sgs, - struct sched_group *group) +sched_asym(struct lb_env *env, struct sg_lb_stats *sgs, struct sched_group *group) { /* Ensure that the whole local core is idle, if applicable. */ if (!sched_use_asym_prio(env->sd, env->dst_cpu)) @@ -9940,7 +9938,7 @@ static inline void update_sg_lb_stats(struct lb_env *env, /* Check if dst CPU is idle and preferred to this group */ if (!local_group && env->sd->flags & SD_ASYM_PACKING && env->idle != CPU_NOT_IDLE && sgs->sum_h_nr_running && - sched_asym(env, sds, sgs, group)) { + sched_asym(env, sgs, group)) { sgs->group_asym_packing = 1; }