From patchwork Wed Feb 7 03:47:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: alexs@kernel.org X-Patchwork-Id: 197725 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp1984922dyb; Tue, 6 Feb 2024 19:56:07 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUPERtmI9ERBCwxJ0HG4EcsS4gB3MIlQQ+YhwHEkqorH8zf43fUc9t2x0YtQijGQVxrh8YQzD2bKeb9G9aXK0vrLpCdOQ== X-Google-Smtp-Source: AGHT+IFH3lY6sEQ/8xO1dCZRiNjD7AYlfWqk9AdXt07dyXZejOys+RFpi4sNR2ExfIQDt9Bijb1t X-Received: by 2002:a05:6902:2847:b0:dc2:5553:ca12 with SMTP id ee7-20020a056902284700b00dc25553ca12mr4201602ybb.14.1707278167519; Tue, 06 Feb 2024 19:56:07 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707278167; cv=pass; d=google.com; s=arc-20160816; b=XwEZ7BGNf74bQMoZEwB5WVuDURCcktUImswB4brzu+4Oh/NMCeaG62auzq+D6y2wn+ QowXL4guzXJtDKFLnOWWW1z8cNnihQQwWeFqsJB3aGnCKMiZRxyVF2D3zgr8Nw6ZOSTU JMh79xeQdpz96oEtGHu8wFKa/MJYD6F+Tg6ALszMYXJZobUmlPg4Y4Gf0hkyC+aSA+2C fWNRUJ/zWd8XKT9k5qvAoF8xIUcrtgBDGHMFwrZpj8byJWd80N1QaFXa0I4bIBRzyYBr 86cDT+rC87dv0x1YFS8bPOEgdKQNIf7DvVPGx7FN+f+HwocziVD1FD0ZBL9Qe/wIZ0z4 ojOw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=5+hZBjq6GH2fdXcTSYktDVP+nwXHAjtey9f1/nH6+hs=; fh=SuMIPsKSigXdZn3vYf6IwFdoj9SpbTmQ0ufMotKUrYo=; b=ZSU3g72GU0rhMB5gFl7UHF8cfFCTp8Zhn2RGY1b+BpGSoPjkUQpIuAkAiashXb/9SX /4wtU/0nFHVIB2STpiITfx0vNbVc2vBrEKbjpwdlZfG47zJTtMfrJLXCPgW9sECh8n+e gtKjvTcypx5gN6qQjoUQNzASAjP12iuJejOmfkpCsn8VEaHW5UdwuG+3dzRmHUUG32rW 6ROQaDt+6vTg2tEIYcppdzc51YQ7iCNsLmMvUlF/5sQWZS/n595JEo4S8HgjpZIQawkx PWntMYuK0LSf2vv1GGJYMuTwiUAbOusD40HL1lEzopfPpbV9OP0HIzzkiv1dYxhcqVOk gRQQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lczDQgnf; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-55905-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55905-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCXxikVqkvd7HSJCiVy0dhvD0RoqQkjjg8UN/hriN5jA4OhOaPc0s7G6E/yB3KsszAZO4DGZ4qIr8sd9QjKb4ABeKxYr9Q== Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id l28-20020a63ba5c000000b005cdbeb8228dsi499422pgu.433.2024.02.06.19.56.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 19:56:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-55905-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lczDQgnf; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-55905-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55905-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 26171B292CB for ; Wed, 7 Feb 2024 03:44:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9B39514AB2; Wed, 7 Feb 2024 03:44:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lczDQgnf" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C554B12E74 for ; Wed, 7 Feb 2024 03:44:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707277450; cv=none; b=DHc1T0fK7sLWmJsFcYHpOBV2MIyGK9WlNymvOEUFcI5LZiq38CU/6zyAcU3V/6UmuY7x2YeaXFDsD3jGKDx3vFvu9JANSdVquKbLmVAdnw2atjmy8uA+dtgogN7NsI1LYH1OFJpvfl1bvGz/imyyDPyBlngxh+w4ddhDR+G/FLg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707277450; c=relaxed/simple; bh=7vUiNV5G3nvvwfoetaYLt/ii5ihVPI2ja1/aLjEI590=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=qscFHHmNAiJYDHZJuwlcOZ9/OqzWfoampphDLhvL73eVTOt/ipFlF/urBdT8DbWPmjqZfe97RNDVXBn+ZwDC4NPvAzpzhCDlrw2NFIrhyrnwW2KEXJaRWcLvuNJ8cQ3l0AoB6W9uBRjOkG/yyjmfPjaTJQjqHXyl593/r+dhDts= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lczDQgnf; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B701C433C7; Wed, 7 Feb 2024 03:44:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707277450; bh=7vUiNV5G3nvvwfoetaYLt/ii5ihVPI2ja1/aLjEI590=; h=From:To:Cc:Subject:Date:From; b=lczDQgnfgJOCY4MK/ePzFHE6JOGKVK8GTmB6IaxhfwXYjnpCndTNp392dkhjX8MaK TddRliBpzoeVAdGAUV4lEhA0WsAgm6z1stDQWyrY3JgjK9aEmpomLCi9zOToOsBuGo ygqCFnhLcXEG4V8YR7+ScGCyPzCtfz7Sprl9026ckxNUagfUv0aW5hj5HvJrDzvjEM 9bQMEJN7Zl5thJCqnPvCtyxGS43vu30Ue4JKOtyJgnkWtOlSfQ5swhfesApv80T/VO 5V3T7k58nNF7Eqc5II3Ka/UIq2lEND0ZdEaIrlgAXr6689pIN7UX4chlgGeswf3tfT Nkj+2BSao0WoA== From: alexs@kernel.org To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Daniel Bristot de Oliveira , Valentin Schneider , linux-kernel@vger.kernel.org, ricardo.neri-calderon@linux.intel.com, yangyicong@hisilicon.com Cc: Alex Shi Subject: [PATCH v4 1/4] sched/topology: Remove duplicate descriptions from TOPOLOGY_SD_FLAGS Date: Wed, 7 Feb 2024 11:47:01 +0800 Message-ID: <20240207034704.935774-1-alexs@kernel.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790210911613844723 X-GMAIL-MSGID: 1790210911613844723 From: Alex Shi These flags are already documented in include/linux/sched/sd_flags.h. Also add missing SD_CLUSTER and keep the comment on SD_ASYM_PACKING as it is a special case. Suggested-by: Ricardo Neri Signed-off-by: Alex Shi To: Valentin Schneider To: Vincent Guittot To: Juri Lelli To: Peter Zijlstra To: Ingo Molnar Reviewed-by: Ricardo Neri Reviewed-by: Valentin Schneider --- kernel/sched/topology.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index 10d1391e7416..0b33f7b05d21 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -1551,11 +1551,12 @@ static struct cpumask ***sched_domains_numa_masks; * * These flags are purely descriptive of the topology and do not prescribe * behaviour. Behaviour is artificial and mapped in the below sd_init() - * function: + * function. For details, see include/linux/sched/sd_flags.h. * - * SD_SHARE_CPUCAPACITY - describes SMT topologies - * SD_SHARE_PKG_RESOURCES - describes shared caches - * SD_NUMA - describes NUMA topologies + * SD_SHARE_CPUCAPACITY + * SD_SHARE_PKG_RESOURCES + * SD_CLUSTER + * SD_NUMA * * Odd one out, which beside describing the topology has a quirk also * prescribes the desired behaviour that goes along with it: