diff mbox series

[v1] perf kvm powerpc: Fix build

Message ID 20240206235902.2917395-1-irogers@google.com
State New
Headers
Series [v1] perf kvm powerpc: Fix build |

Commit Message

Ian Rogers Feb. 6, 2024, 11:59 p.m. UTC 
  Updates to struct parse_events_error needed to be carried through to
PowerPC specific event parsing.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Fixes: fd7b8e8fb20f ("perf parse-events: Print all errors")
Signed-off-by: Ian Rogers <irogers@google.com>
---
 tools/perf/arch/powerpc/util/kvm-stat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Namhyung Kim Feb. 7, 2024, 12:01 a.m. UTC | #1 
On Tue, Feb 6, 2024 at 3:59 PM Ian Rogers <irogers@google.com> wrote:
>
> Updates to struct parse_events_error needed to be carried through to
> PowerPC specific event parsing.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Fixes: fd7b8e8fb20f ("perf parse-events: Print all errors")
> Signed-off-by: Ian Rogers <irogers@google.com>

Acked-by: Namhyung <namhyung@kernel.org>

Thanks for the quick fix!
Namhyung


> ---
>  tools/perf/arch/powerpc/util/kvm-stat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/arch/powerpc/util/kvm-stat.c b/tools/perf/arch/powerpc/util/kvm-stat.c
> index d9a0ac1cdf30..c8357b571ccf 100644
> --- a/tools/perf/arch/powerpc/util/kvm-stat.c
> +++ b/tools/perf/arch/powerpc/util/kvm-stat.c
> @@ -114,7 +114,7 @@ static int is_tracepoint_available(const char *str, struct evlist *evlist)
>
>         parse_events_error__init(&err);
>         ret = parse_events(evlist, str, &err);
> -       if (err.str)
> +       if (ret)
>                 parse_events_error__print(&err, "tracepoint");
>         parse_events_error__exit(&err);
>         return ret;
> --
> 2.43.0.594.gd9cf4e227d-goog
>
Namhyung Kim Feb. 7, 2024, 9:47 p.m. UTC | #2 
On Tue, 6 Feb 2024 15:59:02 -0800, Ian Rogers wrote:
> Updates to struct parse_events_error needed to be carried through to
> PowerPC specific event parsing.
> 
> 

Applied to perf-tools-next, thanks!

Best regards,
diff mbox series

Patch

diff --git a/tools/perf/arch/powerpc/util/kvm-stat.c b/tools/perf/arch/powerpc/util/kvm-stat.c
index d9a0ac1cdf30..c8357b571ccf 100644
--- a/tools/perf/arch/powerpc/util/kvm-stat.c
+++ b/tools/perf/arch/powerpc/util/kvm-stat.c
@@ -114,7 +114,7 @@  static int is_tracepoint_available(const char *str, struct evlist *evlist)
 
 	parse_events_error__init(&err);
 	ret = parse_events(evlist, str, &err);
-	if (err.str)
+	if (ret)
 		parse_events_error__print(&err, "tracepoint");
 	parse_events_error__exit(&err);
 	return ret;