From patchwork Tue Feb 6 22:04:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Armin Wolf X-Patchwork-Id: 197660 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp1850318dyb; Tue, 6 Feb 2024 14:06:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IEXlYK/weRVMhd/mfoWkwg/mmrOnHQzuGphXY+7UGYNhlPD1aQ1zQU8jY7/cWOD7Tp9KdUz X-Received: by 2002:a05:6358:88c:b0:172:d79f:1841 with SMTP id m12-20020a056358088c00b00172d79f1841mr1084041rwj.7.1707257185886; Tue, 06 Feb 2024 14:06:25 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707257185; cv=pass; d=google.com; s=arc-20160816; b=X5QA4rqkh7jIAfF2cQXsteDnNgw7ZvRZo6/slIbeHqQVIS8d+RrQR6mjr+v9YyTAG4 2KBIkGwgYB845hIlfLzyoIlhkRZqYQljfI3Ve1Ak2ZWFoDbxvdYDQUduimr2Fr/GIIX8 fmg2fllIqzej+aHXPQ9wvLPg/DX3UOwALlB9rkdEqNtkEbPsn3sc8o21ciEuZecoB+Pb hHn/kUkTftT4Wi8QsIABmnCBVTB503S3EX7APwVX3oPjzhTlTWHH9O7kjNWuKCdNMySz Yfxiaio23AGlf2EcchYT+0glSzAcRBA5p1VZ7AktiGFMz3U2BBJcVmxDbVYnz4Jb+zpE sJHw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=nHUHUVg6AER9VNCp9R8Wr68FOAFMXtAH+czxJBiyDyg=; fh=0DY8f37xwIaXQeOlYSRfdvy3FTYfvx9tmGIGcNWRzI4=; b=bNyseXmvOaooFI0F5FidHkT/2wmMv1lV61D5weN4t5rsXI7jEEwgmAF5kJLUoJt8am 5a2l7XngKfCWkFSb8mXSDQ8UdMMajjL5WRGiBgXBLHQ4u8NE1JowZwSyjnYySEhtzVk0 nTuKwpvD/3lcP+h3YI2lnCLNgZF3SuMnfyrFWzqQO9gDACnBSaQ2H+tB23sq6c+bTAZR sdQ+KnTH/oisr9trPTXK0qFfj4vPtHnwhbSagiNqZ39wFlcZQlarm3q8pHZ3z05zkwSI JDUhJJ7zlqcbe2cHBLyWJcaDIoSpJ7USGwzUOFzkcpCpmJkKDbHXBdDEWYIFQpPtyHlO uPiw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmx.de header.s=s31663417 header.b=MxWKY3jK; arc=pass (i=1 spf=pass spfdomain=gmx.de dkim=pass dkdomain=gmx.de dmarc=pass fromdomain=gmx.de); spf=pass (google.com: domain of linux-kernel+bounces-55670-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55670-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=gmx.de X-Forwarded-Encrypted: i=1; AJvYcCWU05aUyVAWreu7HEVAWv5VhpkzVvFReJfRrFXggwFNa8TBd2oeuYSlpKSW02tUWqOfxHI3Xl7eoZ+51JLfvNLAixQ5BQ== Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id t31-20020a63461f000000b005cfda2f8f08si2228018pga.452.2024.02.06.14.06.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 14:06:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-55670-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmx.de header.s=s31663417 header.b=MxWKY3jK; arc=pass (i=1 spf=pass spfdomain=gmx.de dkim=pass dkdomain=gmx.de dmarc=pass fromdomain=gmx.de); spf=pass (google.com: domain of linux-kernel+bounces-55670-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55670-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=gmx.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 9BD7C280D2B for ; Tue, 6 Feb 2024 22:06:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E4E811CF9C; Tue, 6 Feb 2024 22:05:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.de header.i=w_armin@gmx.de header.b="MxWKY3jK" Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A7191BDE7; Tue, 6 Feb 2024 22:05:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707257114; cv=none; b=lr+QDmsxIg5TRnScmEV4EFNtD7G8eWFK/QTE/V/EFlk55U0veCxMeEfbLSlks5F4g9s4i4C5KQr5D6XdTtLy5+KUXko2/As7XzjS44hM6EOKcpEr//aHDJIc4udHDL9K5B9LFh11gD+7O6jSKLGCi7oAG+n2uG8P95xcgEK0IXY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707257114; c=relaxed/simple; bh=2PZ9F0FDkdVbqGbkUnpibkVEhoyYv+tqjfurNqK2CQQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=YgP8KhEaapXQPWnswqxJQFePmARwLuBjhu5coCuMaEh9wywj89nXylanTsOz20xtCgH3HIbV/GbhCnknL7nvhVENSJK8rww/3QsMJXGNwWklE0nkEWhMNbzJufsqE2s540K+C03UWTfVxLD5OXjEN4w9FI26VSs0n7TOg05rscQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de; spf=pass smtp.mailfrom=gmx.de; dkim=pass (2048-bit key) header.d=gmx.de header.i=w_armin@gmx.de header.b=MxWKY3jK; arc=none smtp.client-ip=212.227.15.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1707257105; x=1707861905; i=w_armin@gmx.de; bh=2PZ9F0FDkdVbqGbkUnpibkVEhoyYv+tqjfurNqK2CQQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=MxWKY3jKu5UyB2iR5D3Qpo5+94ZcqcmJPPAEiQHkfZHInCNnyrL0+WNhMpSfa+SW sRq8sB0JYMJqgYs+usICt/8TpbbMqlB9/+OM4JtTbP99NqJXAwhQ3py9f+JIbpzh1 ZJ6YDRuX77jk7IzOdqO1s7TMN+U9Ipa15odjmsa8e23PYBEMO1D9CqmNSfmHJx4v7 /R1yeW5F/zQFVmRhRRQ+ov5pVFsU/tbMAZhd8FPImIfcMCGC8Fvy42g5CZyfRmnv3 TBBjTRdoS/PDv0rXBuLmv/oRaBqH9f9uxCV7A8k65r0KBeXyEQ3E8ht+WWv9B4M4z d3PKDeVSbfguD053ow== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from mx-amd-b650.users.agdsn.de ([141.30.226.129]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MSKuA-1rQu0v38p6-00SdAN; Tue, 06 Feb 2024 23:05:05 +0100 From: Armin Wolf To: hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/4] platform/x86: wmi: Replace pr_err() with dev_err() Date: Tue, 6 Feb 2024 23:04:47 +0100 Message-Id: <20240206220447.3102-4-W_Armin@gmx.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240206220447.3102-1-W_Armin@gmx.de> References: <20240206220447.3102-1-W_Armin@gmx.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:sjpexojcG9PhmG/lOiKCA5maxHpxMZEgTZaPWlB9tq2zb8HGmDY zlAqeQl95KlNkQ1wItLe0qWIbeY9EcaIVIfhV3kgRCJ2VIqdaJhAnnteCsp/5bOIuqI/nNY q1OMxCzQmUKzbpaAsvzsDdOKFs30qpCrrXWIwTfDtMfQao/UbS1/tOknnIvPaldV2OIICDX t0Qp9kl8iUnzpjL7eZqJw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:Tc5kJptXQpU=;/a1v9N+iZs6Y4ZYwWs/5ujvMmEe 3jpcwle5lBWYMfHu4D6xaejL0nw3LauiM4qKb+U5yjctQ1BRuEUBByuq8jrerwP4Jd6KAg5QB lX2OFKZrT1NmPA0tVuFF1IK5/kEPGbtNvKkg2bJeAjH+9/76WKZ4bPOQcsoQQ8/ckiHdSPq58 Mskvw8owdjdjOlpBjrNPNXP69zFcTwgz5cRuGitxb9w8Po1C8Fl+Knyr3K6+zk9TPIX0XvFqg MWoXbBFGFAwqIgmDa3JuDSh4f5KGX5nu5JUegOEMNuevtzcwsejCd5ngWecWA5HT6uAnYJfa5 kMnJIV9jhG+kQaDDmurzrGcXrbwXE3STOoFQdult8eBA6rrpedAf/QZVloZ3G9luDU5qlT5Uu L7MmfXyhPJjoVBgEq8BVLsuSFJvT67UlitPuf/L3oFwp6vRf7Mjtp+Pv6FSiKSMuMBrhx7fTb Bn9LUJozJNBJSyvoNTwTrgoWTM4H89DRY9ig/QLwDQHWcQ5sRw9aJFu2+UZk0QgPuY0X4vUi2 g9p0YeFGqrHoSgST3EJBLuyCsz6+vCNrEoWSiZRMcydbByc+aPixTnITsDX+y7kjQOQ/AGITI teRv84gQBAxE7xa4i8N8lS81oYjyQcbGhm5W0a3kBgGhQ612cbXBjStixbbbyLG6XsdUIYNzD XkAsY3a3urVyddjE5sSx4p0ebyyjCFiwleREsDlffP2KN/ISFH0JYUnIGmcu/tK4O3/q/4u6G 9PbBHRmgGFEOMI1qauQJ1ZiqIaqKnkIyv/kUf85V6qLHfefdUu7oEUR79x/2dJVmHIc+XfRF+ tFeeXK1VkukHH7U+2hVWMDNtD0gAB+XqEgVrLiGfn3AiQ= X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790188911003291973 X-GMAIL-MSGID: 1790188911003291973 Using dev_err() allows users to find out from which device the error message came from. Signed-off-by: Armin Wolf --- drivers/platform/x86/wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.39.2 diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c index 396344523bce..63906fdd0abf 100644 --- a/drivers/platform/x86/wmi.c +++ b/drivers/platform/x86/wmi.c @@ -1339,7 +1339,7 @@ static int acpi_wmi_probe(struct platform_device *device) error = parse_wdg(wmi_bus_dev, device); if (error) { - pr_err("Failed to parse WDG method\n"); + dev_err(&device->dev, "Failed to parse _WDG method\n"); return error; }