From patchwork Tue Feb 6 21:42:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hugo Villeneuve X-Patchwork-Id: 197662 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp1854009dyb; Tue, 6 Feb 2024 14:14:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IER4DG7tZqA1U0w0Gu0tVMV0MEv9/HADmh4VmXhK6FtnFMUrwdcSufHGS98bIDA+WaxOxhw X-Received: by 2002:a17:902:ed44:b0:1d9:8bb4:3fdf with SMTP id y4-20020a170902ed4400b001d98bb43fdfmr2866514plb.10.1707257695442; Tue, 06 Feb 2024 14:14:55 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707257695; cv=pass; d=google.com; s=arc-20160816; b=sovvMllNx+Q1e/NynYO1dFdarf2q4bAx8wRwxOicG6LECezbp2TRv9E/r9btK4va2C /o3qbZ8uN2AVJJhuzrqxSKDIuunU8fThpXkn8tZtN5HJL275Sec8ecRYJfv1d/zLup80 JhQG4z/vx2XgS7nFXxvWJC5gdOklOKTZVy8ZtwafPx9rs1ut4ZVt3CJZiVOC24oNg38q nvMJZPOBKxq++UMvj+xhDwhJfhMRTXk2Jaz66aN7wXvW9TwM0K6wPZh/lpBRiLjb7fRb kNj5LxCOms+eRNS+GqWD93h/AMScWzuFSjd6f97nb77ISL8GPLpEG+nQjiKIs+94Bbzv +oUA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:cc:to:from:dkim-signature; bh=/gIgOLz3wVbfgBdtwAQlAKb78cdDXKUGPHpE/f9zKGA=; fh=rU5oQpic7BYKm/eHtBws823weiChb30DBMNSHK9Qi9M=; b=JT2ZoFokSdtN2DNtjSApE3+zoxCr79Vv8oR/7PX+WVi/SOHQ3cnXH3/kxAViRB+wnw RSGM86+TtxxDzpVVPRXZqTtiIOs9nl5ooylCFoWW3igiic1gsjUSRj/VwtmB1WIL1bw5 xbDfMVh7pspJ0h4MBUSXscdLVFicDiLO11T68MM8z1MDM2yOZZ+QJ8O7woiegp8X5d2/ r8n8/6HPw6L36tKDJ/zY7Y1xb19ZtS/wc95lqRM4I7jipzagNsmh4+3wVmvE/Ay7kh1a 6u9pTaZOOJEWdLoajMEQkyztJrPdD0XYIvjDDGGpPmmV3na4pjdeWC9zz67EcNV5EQCQ rf8g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@hugovil.com header.s=x header.b=tZKBoaC3; arc=pass (i=1 spf=pass spfdomain=hugovil.com dkim=pass dkdomain=hugovil.com); spf=pass (google.com: domain of linux-kernel+bounces-55679-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55679-ouuuleilei=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=2; AJvYcCXKon9meaGXsTEl5LJQQfIr/qWsLqGOVvRfFG/0teyjALoxTu/vWlTp0pxWXjfVvBM1GZ871YF/WoaOKF4fY1f2EOWwrg== Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id 5-20020a170902c14500b001d941c96b6dsi7142plj.647.2024.02.06.14.14.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 14:14:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-55679-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@hugovil.com header.s=x header.b=tZKBoaC3; arc=pass (i=1 spf=pass spfdomain=hugovil.com dkim=pass dkdomain=hugovil.com); spf=pass (google.com: domain of linux-kernel+bounces-55679-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55679-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 347F928639C for ; Tue, 6 Feb 2024 22:14:55 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E99601C2B3; Tue, 6 Feb 2024 22:14:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=hugovil.com header.i=@hugovil.com header.b="tZKBoaC3" Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81AD71C282; Tue, 6 Feb 2024 22:14:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=162.243.120.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707257675; cv=none; b=YnXCm4uUdCx0UevGlT3zyJkTZFdVuj9L/KJwVxfu7E2wRYAzsL94/B/lFCyOguASv2x7HutGvmthlpcpb5zAgK2XXgL+EjFrDZJkOPmxmp16+jeVAWngCBHmhctVe1WLzCWy2VcWNxP6M61beCoQj+VaXCeX76Vy6VNVt2PknsE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707257675; c=relaxed/simple; bh=iX/jZ6x7JPoYKfE3wKn+A8vOt4Aa7voggEBapOK97Ys=; h=From:To:Cc:Date:Message-Id:In-Reply-To:References:MIME-Version: Subject; b=oXHiidwUXdOQ7Fzu/YoVToHlQlebzff0YJw/Lmb690T46svKtAFimPZIWvTXpZfIJn1BdUqfeZ1eL2mbKoSg3BeAtm3rK6Tt/jDtYLK/FaqI7XI/WjA6AxxlhbRA17KWhqmE+a8lO/4xAqwz7LOENq5KFNCWjbnt1AAM08h6QN4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=hugovil.com; spf=pass smtp.mailfrom=hugovil.com; dkim=pass (1024-bit key) header.d=hugovil.com header.i=@hugovil.com header.b=tZKBoaC3; arc=none smtp.client-ip=162.243.120.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=hugovil.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=hugovil.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Cc:To :From:subject:date:message-id:reply-to; bh=/gIgOLz3wVbfgBdtwAQlAKb78cdDXKUGPHpE/f9zKGA=; b=tZKBoaC3ZXbwdefK2ul98OxQOu +NLmQ458ajNMpM/OUl+yI5we2ugABI4KlRluVAZXMcdob+jH65KXAlGOPqsyzDT2Y7uJu24uQyK38 HrTD1yTEoLl+a3++D+L20vtGNU3qAXwkoAQ8qWGyDGqMxFVRUUVGqu1aUky3toR9lrfY=; Received: from modemcable168.174-80-70.mc.videotron.ca ([70.80.174.168]:41434 helo=pettiford.lan) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from ) id 1rXTCm-0006XX-Dx; Tue, 06 Feb 2024 16:42:13 -0500 From: Hugo Villeneuve To: gregkh@linuxfoundation.org, jirislaby@kernel.org Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, hugo@hugovil.com, Hugo Villeneuve Date: Tue, 6 Feb 2024 16:42:05 -0500 Message-Id: <20240206214208.2141067-2-hugo@hugovil.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240206214208.2141067-1-hugo@hugovil.com> References: <20240206214208.2141067-1-hugo@hugovil.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SA-Exim-Connect-IP: 70.80.174.168 X-SA-Exim-Mail-From: hugo@hugovil.com X-Spam-Level: X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * -0.0 T_SCC_BODY_TEXT_LINE No description available. Subject: [PATCH 1/4] serial: sc16is7xx: simplify and improve Kconfig help text X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790189445466309009 X-GMAIL-MSGID: 1790189445466309009 From: Hugo Villeneuve Simplify and improve Kconfig help text for SC16IS7XX driver: Especially get rid of the confusing: "If required say y, and say n to..." in each of the I2C and SPI portions. Capitalize SPI keyword for consistency. Display list of supported ICs each on a separate line (and aligned) to facilitate locating a specific IC model. Signed-off-by: Hugo Villeneuve --- drivers/tty/serial/Kconfig | 24 ++++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index ffcf4882b25f..48087e34ff52 100644 --- a/drivers/tty/serial/Kconfig +++ b/drivers/tty/serial/Kconfig @@ -1028,9 +1028,18 @@ config SERIAL_SC16IS7XX select SERIAL_CORE depends on (SPI_MASTER && !I2C) || I2C help - This selects support for SC16IS7xx serial ports. - Supported ICs are SC16IS740, SC16IS741, SC16IS750, SC16IS752, - SC16IS760 and SC16IS762. Select supported buses using options below. + Core driver for NXP SC16IS7xx serial ports. + Supported ICs are: + + SC16IS740 + SC16IS741 + SC16IS750 + SC16IS752 + SC16IS760 + SC16IS762 + + You also must select at least one of I2C and SPI interface + drivers below. config SERIAL_SC16IS7XX_I2C bool "SC16IS7xx for I2C interface" @@ -1041,9 +1050,7 @@ config SERIAL_SC16IS7XX_I2C default y help Enable SC16IS7xx driver on I2C bus, - If required say y, and say n to i2c if not required, - Enabled by default to support oldconfig. - You must select at least one bus for the driver to be built. + enabled by default to support oldconfig. config SERIAL_SC16IS7XX_SPI bool "SC16IS7xx for spi interface" @@ -1052,10 +1059,7 @@ config SERIAL_SC16IS7XX_SPI select SERIAL_SC16IS7XX_CORE if SERIAL_SC16IS7XX select REGMAP_SPI if SPI_MASTER help - Enable SC16IS7xx driver on SPI bus, - If required say y, and say n to spi if not required, - This is additional support to existing driver. - You must select at least one bus for the driver to be built. + Enable SC16IS7xx driver on SPI bus. config SERIAL_TIMBERDALE tristate "Support for timberdale UART"