diff mbox series

[09/12] AMD MCE: use smp_call_func_single_fail

Message ID	20240206185710.062560408@redhat.com
State	New
Headers	Received-SPF: pass (google.com: domain of linux-kernel+bounces-55516-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Message-ID: <20240206185710.062560408@redhat.com> User-Agent: quilt/0.67 Date: Tue, 06 Feb 2024 15:49:20 -0300 From: Marcelo Tosatti <mtosatti@redhat.com> To: linux-kernel@vger.kernel.org Cc: Daniel Bristot de Oliveira <bristot@kernel.org>, Juri Lelli <juri.lelli@redhat.com>, Valentin Schneider <vschneid@redhat.com>, Frederic Weisbecker <frederic@kernel.org>, Leonardo Bras <leobras@redhat.com>, Peter Zijlstra <peterz@infradead.org>, Thomas Gleixner <tglx@linutronix.de>, Marcelo Tosatti <mtosatti@redhat.com> Subject: [patch 09/12] AMD MCE: use smp_call_func_single_fail References: <20240206184911.248214633@redhat.com> Precedence: bulk MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8
Series	cpu isolation: infra to block interference to select CPUs \| [00/12] cpu isolation: infra to block interference to select CPUs [01/12] cpu isolation: basic block interference infrastructure [02/12] introduce smp_call_func_single_fail [03/12] Introduce _fail variants of stop_machine functions [04/12] clockevent unbind: use smp_call_func_single_fail [05/12] timekeeping_notify: use stop_machine_fail when appropriate [06/12] perf_event_open: check for block interference CPUs [07/12] mtrr_add_page/mtrr_del_page: check for block interference CPUs [08/12] arm64 kernel/topology: use smp_call_function_single_fail [09/12] AMD MCE: use smp_call_func_single_fail [10/12] x86/mce/inject.c: fail if target cpu is block interference [11/12] x86/resctrl: use smp_call_function_single_fail [12/12] x86/cacheinfo.c: check for block interference CPUs

Commit Message

Marcelo Tosatti Feb. 6, 2024, 6:49 p.m. UTC

  Convert arch/x86/kernel/cpu/mce/amd.c from smp_call_function_single
to smp_call_func_single_fail, which will fail in case
the target CPU is tagged as block interference CPU.

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>

diff mbox series

Patch

Index: linux-isolation/arch/x86/kernel/cpu/mce/amd.c
===================================================================
--- linux-isolation.orig/arch/x86/kernel/cpu/mce/amd.c
+++ linux-isolation/arch/x86/kernel/cpu/mce/amd.c
@@ -19,6 +19,7 @@ 
 #include <linux/cpu.h>
 #include <linux/smp.h>
 #include <linux/string.h>
+#include <linux/sched/isolation.h>
 
 #include <asm/amd_nb.h>
 #include <asm/traps.h>
@@ -970,6 +971,7 @@  store_interrupt_enable(struct threshold_
 {
 	struct thresh_restart tr;
 	unsigned long new;
+	int ret, idx;
 
 	if (!b->interrupt_capable)
 		return -EINVAL;
@@ -982,8 +984,15 @@  store_interrupt_enable(struct threshold_
 	memset(&tr, 0, sizeof(tr));
 	tr.b		= b;
 
-	if (smp_call_function_single(b->cpu, threshold_restart_bank, &tr, 1))
+	idx = block_interf_srcu_read_lock();
+	ret = smp_call_function_single_fail(b->cpu, threshold_restart_bank,
+					    &tr, 1);
+	block_interf_srcu_read_unlock(idx);
+	if (ret) {
+		if (ret == -EPERM)
+			return ret;
 		return -ENODEV;
+	}
 
 	return size;
 }
@@ -993,6 +1002,7 @@  store_threshold_limit(struct threshold_b
 {
 	struct thresh_restart tr;
 	unsigned long new;
+	int ret, idx;
 
 	if (kstrtoul(buf, 0, &new) < 0)
 		return -EINVAL;
@@ -1007,8 +1017,14 @@  store_threshold_limit(struct threshold_b
 	b->threshold_limit = new;
 	tr.b = b;
 
-	if (smp_call_function_single(b->cpu, threshold_restart_bank, &tr, 1))
+	idx = block_interf_srcu_read_lock();
+	ret = smp_call_function_single_fail(b->cpu, threshold_restart_bank, &tr, 1);
+	block_interf_srcu_read_unlock(idx);
+	if (ret) {
+		if (ret == -EPERM)
+			return ret;
 		return -ENODEV;
+	}
 
 	return size;
 }