Message ID | 20240206165815.2420951-1-colin.i.king@gmail.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-55344-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp1675307dyb; Tue, 6 Feb 2024 08:58:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IHhpPDdBNTCUiLufqIoQTGArR9+LL3PJLTLJTtq/8C9mzYZlrDTB5k65xFEPa7E5FbPwyPh X-Received: by 2002:a9d:6b91:0:b0:6dd:de75:7fa6 with SMTP id b17-20020a9d6b91000000b006ddde757fa6mr3251258otq.2.1707238725009; Tue, 06 Feb 2024 08:58:45 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707238724; cv=pass; d=google.com; s=arc-20160816; b=IXSnlL6D6QJLzY3cq9IY+WMvl/9j8DN5JlJO72qZ6AN4s71G2sApyRs44rlaDlG8lF wik2q0gTsgvNR0CsJC1pUpXqhpt3yQVezsotiTgH98hvMjSdbDmg5g8YIF7RjZ5uZqag qgffZ2W0Ak5BgEXEA0vkZxfsdrWYj9/ly9AYDvSv3Ki1xl0ECpX8rqrm60DTqK6BR+DJ GwzZgu6LfntyAVoCJpBGE2WAzrRhWHA8+Yav2nDrYzwVA7NjgkN9ZCEUvh2S54Qit1ka NKOPutyfCUB0y6PEisc1IhYLt7tHCQBojMT97P0i5x9zL0ZzlzVICb7Uys2WxI4D8JTQ tW0Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=FpWfVPtZyIRe4tMPnVQIwrCljpvDfI1aUeaW61DEyv8=; fh=F5PSH+9/vB0HkEa+LVxXMwjYU5EVq0X5HUMygxSZvPc=; b=FbwJCGCCA49egSIyo2CFVuK+8jIsH8mScupEt4NeRby8uvRzFnBLNE1HBL3P64n0F6 rguWKinGSz3PZVxwXhsYWTAtstSkMtGLLRXaWw1sGAvCaAgHct0/K96LbqbqpZrOzzdt tkQ4/VoC7P9SpZdt19lt4vQTIIQcHWpVf/CFnz2LBaebh175/UDoRQApPVFJmCNN7r12 qq4u8qpYIBUbFVWYo5YaIRgwBJd2cWmAtkt767dDQnqEBjsg+xU5caPcONBUzChYKoLd +BqoWbcA/K03HYbK4v0+t+ago9jmam9FVQRR46O9F0YEIk9BDGP9J5tp6OQ+9Q4tE22o de6Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=mMSsntPh; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-55344-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55344-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com X-Forwarded-Encrypted: i=1; AJvYcCUg2vTz6/B6fU1/MCxMyy22MKeT7FOmu9OST1V4eblYSM21PSS5sFKZFJj8MJqaLnDpc4mPcT2CGV0ggP/BRYuiztURyw== Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id j26-20020a63595a000000b005cfb2c44526si1937179pgm.862.2024.02.06.08.58.44 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 08:58:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-55344-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=mMSsntPh; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-55344-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55344-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id BB46F284378 for <ouuuleilei@gmail.com>; Tue, 6 Feb 2024 16:58:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 648FEBA3F; Tue, 6 Feb 2024 16:58:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mMSsntPh" Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 190254A3C; Tue, 6 Feb 2024 16:58:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707238699; cv=none; b=X+vkmdBP7eT09aBDmamDuK12J2VemvBNP3aNSl1wFNRpcKr6Z3XvF+VvYfQd+7OLpYcAmHVhldw9nIWJtGGxUpEt1aybLlyyoFc9493k//Qpz48iz8l9nD9rit3rLIbY41yWIGLf7J2aigtIKD6HXDyL3fH14v+kdlgOtJEWtSE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707238699; c=relaxed/simple; bh=IdGQoheNjb8G5fdor0IH8nunrSsx54asoMuoAJyHVJY=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Type; b=ad9gYarjGxdjffhkrZ/ICkP4FKLDolNG7hQi7Yr8Xo23K0XYvASSI7hhr8hsyl487i6zmKNMbLo3MsBcaEaHqzJx49ZKergUx+nsZBO1Lgy2qIMowScLHqv+SB33jLOlKKVxcaiHuXszWQv2eu8gphJmFVmO1SbLru3iNR1ba9A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mMSsntPh; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-40fdd65a9bdso17141345e9.2; Tue, 06 Feb 2024 08:58:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707238696; x=1707843496; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=FpWfVPtZyIRe4tMPnVQIwrCljpvDfI1aUeaW61DEyv8=; b=mMSsntPhi1Jz/FEVFI2dOWwCIWyIAz6BLf9N1awnLj/grvyfuZpGeTZvcJr0wcFtEi qzTOWhia8oXDcyoGHhXPWsudT+ZQQVpuwJWyRlEo+U9nn25en9O1OWsA1EvMY+7pl4pB BPkyUsSxeCwm2ZkHr1/IbuHQWc1dqH9xKeXs0hkHbLhXwWATZ/l/VMDS5GXStDBSMGS5 ngCl1Zq2KW7l5Q6wxrlSPSdepjP8H6uiZ/1n5tttsfHPxYpBB1C9G+Tz1+wc9kLMyImt kGEQAVgvZ88yA0t5ZGzMwVV0aXzK4e0NDOQWO5T85jI3GbHAjdlPKf+W5bmf608OPi14 tfqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707238696; x=1707843496; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FpWfVPtZyIRe4tMPnVQIwrCljpvDfI1aUeaW61DEyv8=; b=WxVJDTeh3RQkgfWTTLDoVThDcUvXDpbw8dKVhe2GXbhsNGzXRiQiIboBqX+A8g8+Oo rhyLOK0SoR55QWroHZKeOIEGhiuNQSEVbNU5QFrZB7BdCANJ9aFKoxfBuhpEtQyDLdkv BIXa4qjAMOp1SKbZY5XOSXOx2kw1bxKOfBuew2w5xu+Aro/09ubszY+qDFdzSVPebNjP JMz9OOaEolFVbQNz5wD6tSIPv4BDfCpSPsdzw+WssMph19zKuKXngarY64Y47GeAxi/Z LS4GGVpYkT6wgdI++OUn5ZMq6ykyZjkJYqnAUrKPMXlnfsvICr8UPb/8l9kLCYTJ4F3R j9zQ== X-Gm-Message-State: AOJu0YxgLUkzf0rnv5VV3Hk1QT2ihwEvTrjZm3CMB4XkufDpL2F5Tg6x mbWfPiEhMwDVOsnd6yHm8k4EOLy+B8j8iTSUTP8cmZcC2qyYS9VK X-Received: by 2002:a05:600c:13d6:b0:40e:aecc:25ac with SMTP id e22-20020a05600c13d600b0040eaecc25acmr2340388wmg.30.1707238696098; Tue, 06 Feb 2024 08:58:16 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXgUJgHjdWLMR5qWhDoQ1lfspPlTjku3N4xA800FGcdyLjfPK3/fxEcG6N3KlcY0COr7tyX2Ix6c4LIn43GTM/UqM7UfRlRWAfnTlv5XbNy6CXmJ3xb8XRRR6p4eSkR29hY9aV2FUIzX9BWf7buQ/qAuzvXBfgffow4hacUe9ZS4BPRvTVcXD5cEVNVAPMP0ZpQ42nQYpGcMyNghI/WHHKMxo4X75Sd58qxQVPeV0LUDPn5RyArXZ6tpFNvHoSaAjqtYJx3I487x2qj8dRlNPtpH5gcRF2qx4i91U1jyicTBO7gHaskeen+WvoD82WECmaizY1pDYAT Received: from localhost (cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net. [80.193.200.194]) by smtp.gmail.com with ESMTPSA id o14-20020a05600c4fce00b0040fdd7cbc8dsm2533912wmq.47.2024.02.06.08.58.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 08:58:15 -0800 (PST) From: Colin Ian King <colin.i.king@gmail.com> To: Saeed Mahameed <saeedm@nvidia.com>, Leon Romanovsky <leon@kernel.org>, "David S . Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org, linux-rdma@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net/mlx5: remove redundant assignment to variable object_range Date: Tue, 6 Feb 2024 16:58:15 +0000 Message-Id: <20240206165815.2420951-1-colin.i.king@gmail.com> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790169553368025455 X-GMAIL-MSGID: 1790169553368025455 |
Series |
net/mlx5: remove redundant assignment to variable object_range
|
|
Commit Message
Colin Ian King
Feb. 6, 2024, 4:58 p.m. UTC
The variable object_range to log_header_modify_argument_granularity
is being assigned a value that is never read, the following statement
assigns object_range to the max of log_header_modify_argument_granularity
and DR_ICM_MODIFY_HDR_GRANULARITY_4K, so clearly the initial
assignment is redundant. Remove it.
Cleans up clang-scan build warning:
drivers/net/ethernet/mellanox/mlx5/core/steering/dr_arg.c:42:2: warning:
Value stored to 'object_range' is never read [deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/net/ethernet/mellanox/mlx5/core/steering/dr_arg.c | 3 ---
1 file changed, 3 deletions(-)
Comments
On Tue, Feb 06, 2024 at 04:58:15PM +0000, Colin Ian King wrote: > The variable object_range to log_header_modify_argument_granularity > is being assigned a value that is never read, the following statement > assigns object_range to the max of log_header_modify_argument_granularity > and DR_ICM_MODIFY_HDR_GRANULARITY_4K, so clearly the initial > assignment is redundant. Remove it. > > Cleans up clang-scan build warning: > drivers/net/ethernet/mellanox/mlx5/core/steering/dr_arg.c:42:2: warning: > Value stored to 'object_range' is never read [deadcode.DeadStores] > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Thanks Colin, Reviewed-by: Simon Horman <horms@kernel.org>
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_arg.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_arg.c index 01ed6442095d..c2218dc556c7 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_arg.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_arg.c @@ -39,9 +39,6 @@ static int dr_arg_pool_alloc_objs(struct dr_arg_pool *pool) INIT_LIST_HEAD(&cur_list); - object_range = - pool->dmn->info.caps.log_header_modify_argument_granularity; - object_range = max_t(u32, pool->dmn->info.caps.log_header_modify_argument_granularity, DR_ICM_MODIFY_HDR_GRANULARITY_4K);